Opened 9 years ago

Closed 8 years ago

Last modified 3 years ago

#872 closed Bug (fixed)

sbcblk_clio.F90: bug in dynamic allocation.

Reported by: mathiot Owned by: nemo
Priority: highest Milestone:
Component: OCE Version: trunk
Severity: Keywords: allocation/deallocation
Cc:

Description

There is a bug about the dynamic allocation in sbcblk_clio.F90 in subroutine blk_oce_clio, blk_ice_clio, blk_clio_qsr_oce and blk_clio_qsr_ice.

  • In subroutine blk_oce_clio, checks on wrk_in_use and on wrk_not_release are wrong. You have to test 2d variables and not 3d varaibles.
  • In subroutine blk_ice_clio, some 3d workspace arrays are unavailable. I suggest to change wrk_3d_1 and wrk_3d_2 by wrk_3d_4 and wrk_3d_5.
  • In subroutine blk_clio_qsr_oce, some 2d workspace arrays are unavailable. I suggest to change wrk_2d_1 to wrk_2d_6 by wrk_2d_4 to wrk_2d_9.
  • In subroutine blk_clio_qsr_ice, some 2d workspace arrays are unavailable. I suggest to change wrk_2d_1 to wrk_2d_6 by wrk_2d_5 to wrk_2d_10.

In attachment the corrected file with my suggestions.

Best regards,

Pierre Mathiot

Commit History (0)

(No commits)

Attachments (1)

sbcblk_clio.F90 (53.6 KB) - added by mathiot 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by mathiot

comment:1 Changed 8 years ago by vichi

  • Resolution set to fixed
  • Status changed from new to closed

Routines for dynamic allocation have been changed and now the working arrays are properly allocated

comment:2 Changed 4 years ago by nicolasmartin

  • Keywords dynamic removed

comment:3 Changed 3 years ago by nemo

  • Keywords allocation/deallocation added; allocation removed
Note: See TracTickets for help on using tickets.