Opened 9 years ago

Closed 9 years ago

Last modified 3 years ago

#913 closed Bug (fixed)

vvl not running in pure zco

Reported by: rblod Owned by: nemo
Priority: low Milestone:
Component: OCE Version: release-3.4
Severity: Keywords: VVL ZCO
Cc:

Description

zco option (ln_zco) isn't compatible with vvl due to missing initialization of scales factors (only the substitute are initialized in zgr_zco).
Fix: initialize scale factos rather than substitute in zgr_zco:

      DO jk = 1, jpk
         gdept(:,:,jk) = gdept_0(jk)
         gdepw(:,:,jk) = gdepw_0(jk)
         gdep3w(:,:,jk) = gdepw_0(jk)
         e3t (:,:,jk) = e3t_0(jk)
         e3u (:,:,jk) = e3t_0(jk)
         e3v (:,:,jk) = e3t_0(jk)
         e3f (:,:,jk) = e3t_0(jk)
         e3w (:,:,jk) = e3w_0(jk)
         e3uw(:,:,jk) = e3w_0(jk)
         e3vw(:,:,jk) = e3w_0(jk)
      END DO

By the way I'm not sure maintaining a specific zco option which is basically a particular case of zps really worth it, especially since we've suppressed key_zco and associated performance gain (we just have the ability to read a bathy_level file). Having zps activated, rn_e3zps_rat=1 and rn_e3zps_min big enough could make it as well.

Commit History (1)

ChangesetAuthorTimeChangeLog
3282rblod2012-01-27T14:08:19+01:00

Fix for zco and vvl, see ticket #913

Change History (8)

comment:1 Changed 9 years ago by rblod

  • Resolution set to fixed
  • Status changed from new to closed

comment:2 Changed 4 years ago by nicolasmartin

  • Keywords VVL added; vvl removed

comment:3 Changed 4 years ago by nicolasmartin

  • Keywords nemo_v3_4_alpha added

comment:4 Changed 4 years ago by nicolasmartin

  • Milestone 2012 Stream 1: User Interfaces deleted

Milestone 2012 Stream 1: User Interfaces deleted

comment:5 Changed 4 years ago by nicolasmartin

  • Keywords ZCO added; zco removed

comment:6 Changed 4 years ago by nicolasmartin

  • Keywords nemo_v3_4* added; nemo_v3_4_alpha removed

comment:7 Changed 3 years ago by nemo

  • Keywords release-3.4* added; nemo_v3_4* removed

comment:8 Changed 3 years ago by nemo

  • Keywords release-3.4* removed
Note: See TracTickets for help on using tickets.