New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
2009WP/2009Stream3/VVL (diff) – NEMO

Changes between Version 10 and Version 11 of 2009WP/2009Stream3/VVL


Ignore:
Timestamp:
2009-06-21T11:16:58+02:00 (15 years ago)
Author:
gm
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • 2009WP/2009Stream3/VVL

    v10 v11  
    7171=== 5. To be done === 
    7272 ==== 5.1 bug corrections ==== 
    73 - correct forcing term in salinity equation:  remplace emps by fsalt, a salt flux so that : 
     73 - correct forcing term in salinity equation:  [[BR]] 
     74            remplace emps by fsalt, a salt flux so that : 
    7475            in vvl case   d(e3 S)/dt = ... + fsalt                             (salt flux only)[[BR]] 
    7576            without vvl  d(e3 S)/dt = ... + fsalt + emp * SSS      (salt flux + concentration/dillution effect)[[BR]] 
    76             see [wiki:2009WP/2009Stream3/LeapFrogC#a-trasbc.F90] 
     77            see [wiki:2009WP/2009Stream3/LeapFrogC#a-trasbc.F90][[BR]] 
    7778 - correct the left-hand-side of the momentum equation in vector invariant formulation :  
    7879            time derivative of e3 should not be not included in the left hand side of the momentum equation [[BR]] 
    7980            solve dU/dt = ...  and not d( e3 U)/dt = ... ). [[BR]] 
    8081            Change to be done in both dynnxt AND dynspg (_ts and flt) 
     82            '''In dynnxt.F90'''   perform the thickness weighted time leap-frog and  Asselin filter only in ln_dynadv_vec=FALSE and lk_vvl=TRUE., in other word unweighted operation if  n_dynadv_vec=T and NOT lk_vvl. So replace the 2 two [[BR]] 
     83 
     84{{{ 
     85      IF( ln_dynadv_vec .OR. .NOT. lk_vvl ) THEN      ! applied on velocity 
     86         part AAA 
     87      ELSE                                            ! applied on thickness weighted velocity 
     88         part BBB 
     89      ENDIF 
     90}}} 
     91       By 
     92 
     93 {{{ 
     94      IF( ln_dynadv_vec .OR. .NOT. lk_vvl ) THEN      ! applied on velocity 
     95         part BBB 
     96      ELSE                                            ! applied on thickness weighted velocity 
     97         part AAA 
     98      ENDIF 
     99}}} 
     100 
     101    In addition : (1) the masking of ua, va can be moved inside the key_bdy case ; (2) all the comment have been updated. The resulting subroutine can be found in attachment (). 
     102           
    81103 - ensure that BDY and OBC are working with the new time-stepping strategy 
     104        in particular obc_dyn_bt  seems to modify the sshn field. This should be wrong with the new time strategy  
    82105 - label all fse3 with its adequate time label (before, now, after) everywhere in the code. Some may be wrong today. 
    83106 - suppress mu* 3D arrays, and anly use instead 2D arrays