New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
2009WP/Release_v3.2 (diff) – NEMO

Changes between Version 25 and Version 26 of 2009WP/Release_v3.2


Ignore:
Timestamp:
2009-07-06T12:14:26+02:00 (15 years ago)
Author:
gm
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • 2009WP/Release_v3.2

    v25 v26  
    3838 
    3939 
     40 
     41 
    4042 - '''ENV'''ironment [[BR]] 
    4143||#409|| ins_make [ -t "target host" ] || '''???''' || || 
     44 
    4245||#407|| alias and csh || '''???''' || || 
     46 
    4347||#396|| Add a first guess of ORCA2_LIM_PISCES configuration in libIGCM || || || 
     48 
    4449||#240|| setting up and running NVTK on new target || '''Claude''' action. Some point already solved. To be achieved in v3.2 '''???''' || NVTK || 
     50 
     51 
    4552 
    4653 - '''LIM2''' [[BR]] 
    4754||#194|| LIM-2 damping option || true identified bug. No real pressure to solve it urgently || limdmp_2.F90  '''==> v3.3''' or later || 
     55 
    4856||'''#364'''|| wrong sign in lbc_lnk for gradients in limadv.F90|| True identified bug, easy to fix. To be done in v3.2 (cf. '''limadv_2.F90''' in attachment   and with style correction '''limadv_2_gm'''. Note that in the _gm there is !!gm comments associated to optimisation modification that would change the results if there are wrong )|| limadv_2.F90 || 
     57 
     58 
    4959 
    5060 - '''LIM3''' [[BR]] 
    5161||#464|| Hard coded number of ice categories || true identified bug. No simple solution. || limdia.F90 '''==> v3.3''' or later || 
     62 
    5263||'''#439'''|| Array index out of bounds in limsbc.F90 || true identified bug. easy to fix. To be done in v3.2 (cf. '''limsbc.F90''' in attachment and with style correction '''limsbc_gm.F90'''. Note that in the _gm there is !!gm comments associated to optimisation modification that would change the results if there are wrong ) || limsbc.F90 || 
     64 
    5365||#400|| LIM3 : useless akappa and alambd arrays ?||We agree, a cleaning of useless array is required. Should be done latter, when introducing EVP rheology in LIM2.  || '''==> v3.3''' || 
     66 
    5467||'''#364'''|| wrong sign in lbc_lnk for gradients in limadv.F90|| We agree, to be done in v3.2 (cf. '''limadv.F90''' in attachment and with style correction '''limadv_gm.F90'''. Note that in the _gm there is !!gm comments associated to optimisation modification that would change the results if there are wrong )|| limadv.F90 || 
     68 
    5569||#354|| ORCA-LIM3 MPI problem? || Apparently, it was a user error. The ticket can be closed. '''Rachid''', do you agree? ||  invalid || 
    5670||#243|| simplification of computation of snow-ice energy in limthd_ent || I (Gurvan) don't understand this ticket. Ask Martin for further info. ||  postponed form v3.3 || 
     71 
    5772||#195|| LIM-3 a damping option should be added for regional configurations || pending issue, can be included in '''Brice''' timetable || '''==> v3.3''' or later || 
     73 
     74 
    5875 
    5976 - '''OFF''' [[BR]] 
    6077||#320|| update modules of the off-line || '''Christian''', off-line should be OK for v3.2, no? || OFF || 
    6178 
     79 
     80 
    6281 - '''OPA''' [[BR]] 
    6382Physics[[BR]] 
    6483||#462|| Bug in zdftmx when using zdfddm || change the order of the call in step. '''Done'''  || step.F90 || 
     84 
    6585||#459|| RGB light penetration + ocean color: paper documentation||'''Gurvan'''|| DOC || 
     86 
    6687||#458|| tidal mixing: paper documentation||'''Gurvan'''|| DOC || 
     88 
    6789||#457|| tidal mixing: optimisation|| code provided by Gurvan in attachment of the ticket. Test NVTK ('''Claude/Gurvan''')|| zdftmx.F90 || 
    68 ||#435|| wrong index in ldfslp.F90|| this is not a bug, nevertheless, updated comments in the routine are required, see '''ldfslp.F90''' in attachment where comments and style have been updated|| ldfslp.F90 || 
     90 
     91||'''#435'''|| wrong index in ldfslp.F90|| 2 points here: (1) wrong signin the lbc related to pn2 in the computation of the slope just below the mixed layer. This is definitively a bug that have to be corrected in v3.2 (see '''ldfslp.F90''') ; (2) replace ik = MAX( 1, nmln(ji,jj) , nmln(ji+1,jj) by ik = MAX( 1, nmln(ji,jj)), but this is not a bug! updated comments in the routine are required (see '''ldfslp_gm.F90''' in attachment) where comments on the reason why we are doing this have been added (also some style improvments)  || ldfslp.F90 || 
     92 
    6993||'''#371'''|| Mixed laplacian and bilaplacian operators || Lap-bilap option, code provided and checked through the NVTK. '''Gurvan''' for code review: as provided it does not work, waiting for a reply from ed.blockley. '''probably not in v3.2'''  || dynldf.F90 , ldfdyn.F90 , ldfdyn_oce.F90 || 
     94 
    7095||'''#361'''|| Proposal for diaptr || Required for IPPC runs, routines provided. '''Claude + Gurvan''' ? || diaptr.F90 + namelist || 
     96 
    7197||'''#239'''|| diaptr code duplication / deficiencies|| clearly a problem to be solved...  '''who? Claude/Sebastian?'''|| diaptr.F90 || 
     98 
    7299||#356|| eosbn2: should we update the equation of state ? || This should be added in the roadmap 2010 together with an option for P instead of z in eos || '''==> v3.4''' or later || 
     100 
    73101||#331|| No bottom friction if mbathy=2 || to be solved together with #233. See Andrew work || || 
     102 
    74103||'''#233'''|| bottom friction issue... || true identified bug. A clean solution is under development by Andrew.  To be done in v3.2 || || 
     104 
     105 
    75106 
    76107Vertical coordinate[[BR]] 
    77108||'''#434'''|| mesh_zgr inconsistency when using zps || I (Gurvan) think that JMM is right, we should return back to 3D arrays and recompute the e3tp etc  after the check of the bathymetry ! '''Sebastian+Gurvan''' ? || domain, domzgr.F90, domwri.F90|| 
     109 
    78110||#381|| bugs in "subroutine zgr_sco" || to be checked || domzgr.F90 || 
     111 
    79112||#366|| sbot_min not properly used in hybrid coordinate option (zgr_sco module in domzgr)||  small true identified bug. easy to fix. To be done in v3.2 ('''Gurvan''')  || domzgr.F90 || 
     113 
     114 
    80115 
    81116VVL re-activation [[BR]] 
    82117||'''#382'''|| bugs in "subroutine dom_vvl" fse3w computation || Already corrected see domzgr_substitute.h90 || '''ticket to be closed''' || 
    83118||#337|| partial cells and vvl || This contains an improvement to the hydrostatic pressure gradient correction in vvl case. To be checked by '''Rachid + Gurvan'''. In the trunk, we are currently using the sco correction which works || '''==> v3.2 or v3.3''' || 
     119 
    84120||'''#232'''|| Optimization of dynspg_ts with key_vvl || Already included in the trunk (see dynspg_ts).  || '''ticket to be closed''' || 
     121 
    85122||'''#329'''|| vvl and time splitting || 2 points here: (1) correct thickness timestep : should be OK in Rachid's latest version of dynspg_ts ; to be checked in '''v3.2'''. (2) removal of asselin filter on the barotropic part in dynnxt.F90 : I (Gurvan) don't think it is a good idea. || dynspg_ts.F90|| 
     123 
    86124||'''#328'''|| vertical velocity and key_vvl || We agree. In the current trunk, the call to wzv (now ssh_wzv) is done at the begining of step. The vertical velocity has to be removed from the restart file To be done in v3.2 '''Rachid + Gurvan''' || restart.F90 || 
     125 
    87126||#209|| Bug in domvvl : wrong e3u e3v and e3f scale factors + change name of mut to ee_t || partly solved in the trunk (see domvvl). The suppression of 3D arrays (mut, muu, muv, muf) does not work, we don't understand why (it will not be done in v3.2). The change in trazdf_imp and exp are still a pending issue to be solved in v3.2 ('''Rachid + Gurvan''') || trazdf_imp.F90 , trazdf_exp.F90 || 
     127 
    88128 
    89129Surface module (SBC)[[BR]] 
    90130||#436|| Implementation of CICE and UM coupling code as part of S0.1 and S0.3 || On-going work. Waiting for Exeter input|| '''==> v3.3''' or later|| 
     131 
    91132||#406|| optimize sbcssr.F90 routine || We agree, to be done in v3.2 (cf. '''sbcssr''' in attachment and style update '''sbcssr_gm.F90''') || sbcssr.F90 || 
     133 
    92134 
    93135Bugs[[BR]] 
    94136||#433|| potential non initialized value in trazdf_imp || to be checked  '''Gurvan'''?|| trazdf_imp.F90|| 
     137 
    95138||#424|| missing lbc_lnk in sbcmod || Sebastian answer properly to this ticket. Don't think we need to do something  || invalid ? || 
     139 
    96140||#419|| Bug in dynvor_een when flux form is activated || small true identified bug. easy to fix || dynvor.F90 || 
     141 
    97142||#403|| Calculation of avmb in zdf_tke_init || true identified bug. To be done in v3.2. The idea is to add the background profile of avt and avm in the restart when tradv_cen2 is used (see '''zdfini.F90''' and '''traadv_cen2.F90''' in attachement and '''zdfini_gm''' & '''traadv_cen2''' for further style modifications) || zdfini.F90 , traadv_cen2.F90 || 
     143 
    98144||'''#377'''|| SBC fldread additions || Improvment to SBC, code provided and checked through the NVTK. '''Sebastian''' for code review? || fldread.F90 , iom.F90 , bdydta.F90 , sbcblk_clio.F90 , sbcflx.F90 , sbcice_if.F90 , sbcrnf.F90 , sbc_ssr.F90 , domain.F90 , in_out_manager.F90 || 
     145 
    99146||#375|| fldread and Interpolation on the Fly||Seem easy to do,  '''Sebastian''' do you agree?|| fldread.F90 || 
     147 
    100148||'''#365'''|| wrong scale factors used in bdyvol || small true identified bug. easy to fix. To be done in v3.2 (cf. '''bdyvol.F90''' in attachment) || bdyvol.F90 || 
     149 
    101150||'''#368'''|| bug in calendar of lim and top outputs || done for lim. status of top? '''Christian'''?|| to be closed if '''Christian''' is ok || 
     151 
    102152||#363|| Bug if key_ldfslp defined but still unrotated diffusion for tracers || To be checked... '''Gurvan ?''' || || 
     153 
    103154||#342|| wrong computation of the heat contain || almost done + should be associated with a full review for mld diag... || must be done for IPCC || 
    104155||'''#332'''|| Mistake in comment in nam_dynvor||  easy to fix. To be done in v3.2 '''Claude + Gurvan''' || namelist || 
     156 
    105157||#244|| tradmp || A priori, this was done intentionally by Gurvan. '''Gurvan''' check it again! || no action? || 
     158 
    106159||#129|| Use of F95 signed zero causes incorrect results || True identified problem. Specific compiler option added to circumvent it. A cleaner solution is to remove all SIGN instruction from the code, especially in sea-ice. ||  '''==> v3.3''' or later || 
     160 
    107161||'''#127'''|| Arrays go out of bounds || true identified bug. rather easy to fix but using a other technique than the one proposed in the ticket. To be done in v3.2 (for '''diafwb.F90''', see gm's comments and routines attached to the ticket. There is 2 other bug corrected in diafwb. For '''cla.F90''', there is several other bugs, so at the end I completely re-wrote the module, merging cla, cla_div and cla_dynspg. See gm's comments and routines attached to the ticket. ) || cla.F90 , diafwb.F90 suppress cla_div, cla_dynspg || 
    108162 
    109163IO issues[[BR]] 
    110164||#437||Distribution of "CALL iom_put" in NEMO-TOP || '''Brice, Christian'''. On going work in the trunk. To be achieved in v3.2 || whole NEMO || 
     165 
    111166||#410|| PGF90-F-0004-Unable to open MODULE file netcdf.mod (fliocom.f90: 5) || '''???''' || || 
     167 
    112168||#405|| bug in diawri_dimg.h90 ||  small true identified bug. easy to fix. To be done in v3.2 (cf. '''diawri_dimg.h90''' in attachment)  || diawri_dimg.h90|| 
     169 
    113170||'''#374'''|| Addition of clobber and chunksize when opening NetCDF files || Improvment to restart write, code provided and checked through the NVTK. '''Sebastian''' for code review? || iom.F90 , in_out_manager.F90, iom_nf90.F90 , domain.F90 , restart.F90 , limrst.F90 , limrst_2.F90 || 
     171 
    114172||#372|| problem with netcdf syncing|| Seem easy to do except it is in IOIPSL...   '''Sebastian''', do you agree?|| histcom.F90 || 
     173 
    115174||#359|| cleaning of calendar variables || '''Sebastian + Gurvan''' action? || phycst.F90 and others...|| 
     175 
    116176||#343|| no more runoff in outputs... || keep runoff in the output only with IOM outputs, no more with standard one. '''Sebastian + Gurvan''' ? || done in changeset:1482 || 
     177 
    117178||#314|| wrong name of trends output file : key_trdmld, key_trmld_trc||  '''Christian''' should fix this problem || trdmld || 
     179 
    118180||#296|| obcdta_bt out of date || To be solved together with major rewriting of OBC by MERCATOR. '''Rachid''', you agree? || '''==> v3.3''' or later || 
     181 
    119182||#237|| Undefined behaviour writing to ocean.output from multiple pes || '''Sebastian + Rachid'''  do you agree? '''Seb:''' Yes, but this concerns only the first 10 lines of ocean.output, no? It cannot be bad... we should check the same kind of things with solver.stat and time (Yann reported problems with these files wrtitten by all cpus, I don't remember if we corrected it or not.|| || 
     183 
    120184||#201|| simplified definition of the model time step || Minor improvement. in v3.2 only if we have enough time || '''==> v3.2''' or later || 
    121185 
    122186Misc. staff[[BR]] 
    123187||#447|| IOF and cutting along latitude || '''???'''  I (Gurvan) don't understand the nature of the problem. Rachid some idea? || || 
     188 
    124189||#445|| Performance of NEMO 3.1 || idem as for #447 || || 
     190 
    125191||#200|| dtatem & dtasal : cleaning - move the call from step to tradmp - merge in 1 module || This should be added in the roadmap 2010 together with the system consolidation / simplification || '''==> v3.4''' or later || 
     192 
    126193||#379|| clean lib_mpp || Already done : '''Rachid''' this ticket should be closed, no? || lib_mpp.F90, lbcnfd .F90 , lbclnk.F90  ||