Changes between Version 5 and Version 6 of 2014WP/2014_SystemSimplification_hard_coding
- Timestamp:
- 2015-10-22T09:59:51+02:00 (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
2014WP/2014_SystemSimplification_hard_coding
v5 v6 17 17 [[BR]] '''cla.F90, domzgr.F90, dynspg_flt.F90''' : 18 18 19 cross land advection only defined in ORCA2 case [[BR]](gibraltar and Bad el Mendeb straits) and no more used[[BR]] ===>>> module to be suppress ''' DONE in ''' [https://forge.ipsl.jussieu.fr/nemo/browser/branches/2015/dev_r5721_CNRS9_NOC3_LDF 2015/dev_r5721_CNRS9_NOC3_LDF] 20 '''closea.F90''' : 19 cross land advection only defined in ORCA2 case [[BR]] (gibraltar and Bad el Mendeb straits) and no more used[[BR]] ===>>> module to be suppress [[BR]]'''DONE in ''' [https://forge.ipsl.jussieu.fr/nemo/browser/branches/2015/dev_r5721_CNRS9_NOC3_LDF 2015/dev_r5721_CNRS9_NOC3_LDF] 21 20 22 suppress closed seas in forced mode (typically Caspian Sea, Azov Sea…)[[BR]]or balance their fresh water budget in coupled mode …[[BR]]'''===>>> How to deal with that ?''' idea user_defined module for close.F90 21 '''closea.F90''' : 23 22 24 [[BR]] '''diafwb.F90''' : 23 suppress closed seas in forced mode (typically Caspian Sea, Azov Sea…)[[BR]] or balance their fresh water budget in coupled mode …[[BR]] ''' ===>>> How to deal with that ?''' idea user_defined module for close.F90 25 24 26 only diagnostics of the global fresh water budget and of transport of mass salt and heat in some straits:[[BR]]Gibraltar, Red Sea, Baltic Sea etc. for ORCA 4°, 2° & 1°[[BR]]'''===>>> module to be suppress ''' idea user_defined module for that 25 [[BR]] '''diafwb.F90''' : 26 27 only diagnostics of the global fresh water budget and of transport of mass salt and heat in some straits:[[BR]] Gibraltar, Red Sea, Baltic Sea etc. for ORCA 4°, 2° & 1°[[BR]] ''' ===>>> module to be suppress ''' idea user_defined module for that 27 28 28 29 [[BR]] '''diaptr.F90''' : 29 30 30 Computes meridional transports and zonal means (of heat salt velocities). [[BR]] Inefficient on MPP as require global communication. Better to compute off line. [[BR]]Suppress the module and add the output of the vertical average of u.T , v.T , u.S, v.S [[BR]]from which exact poleward heat transport can be computed…[[BR]]'''===>>> module to be suppress (?) '''discussion still open as in ESM, they want thosediags directly in the output...31 Computes meridional transports and zonal means (of heat salt velocities). [[BR]] Inefficient on MPP as require global communication. Better to compute off line. [[BR]] Suppress the module and add the output of the vertical average of u.T , v.T , u.S, v.S [[BR]] from which exact poleward heat transport can be computed…[[BR]] ''' ===>>> module to be suppress (?) ''' discussion still open as in ESM, they want those diags directly in the output... 31 32 32 [[BR]] '''domhgr.F90''' : 33 [[BR]] '''domhgr.F90''' : 33 34 34 hard coded reduction of scale factors in some straits in ORCA configurations [[BR]] (typically straits of Gibraltar, Bab el Mandeb, Danish, Lombok, Sumba, etc). [[BR]]The input coordinates.nc file have to contain the information [[BR]](+ add in TOOLS a fortran program as an example of how to modify a coordinates.nc file)[[BR]]===>>> remove hard coded part '''DONE in '''[https://forge.ipsl.jussieu.fr/nemo/browser/branches/2015/dev_r5721_CNRS9_NOC3_LDF 2015/dev_r5721_CNRS9_NOC3_LDF]35 hard coded reduction of scale factors in some straits in ORCA configurations [[BR]] (typically straits of Gibraltar, Bab el Mandeb, Danish, Lombok, Sumba, etc). [[BR]] The input coordinates.nc file have to contain the information [[BR]] (+ add in TOOLS a fortran program as an example of how to modify a coordinates.nc file)[[BR]] ===>>> remove hard coded part [[BR]]'''DONE in ''' [https://forge.ipsl.jussieu.fr/nemo/browser/branches/2015/dev_r5721_CNRS9_NOC3_LDF 2015/dev_r5721_CNRS9_NOC3_LDF] 35 36 36 [[BR]] '''dommsk.F90''' : hard coded increase of lateral friction at the coast in some straits. Add a external file to be read that contains the specification of lateral friction (+ add in TOOLS a fortran program as an example of how to specify the input file)37 [[BR]] '''dommsk.F90''' : 37 38 38 ''' ===>>> remove hard coded part'''39 hard coded increase of lateral friction at the coast in some straits. [[BR]]Add a external file to be read that contains the specification of lateral friction [[BR]](+ add in TOOLS a fortran program as an example of how to specify the input file)[[BR]]'''===>>> remove hard coded part''' 39 40 40 [[BR]] '''domvvl.F90''' : modifications associated with the reduction of scale factors in some straits. No more necessary (addition of unaltered surface (e1e2u, e1e2v) in coordinates.nc when scale factors are reduced in some straits.41 [[BR]] '''domvvl.F90''' : 41 42 42 ===>>> remove hard coded part, modify coordinates.nc ''' DONE in '''[https://forge.ipsl.jussieu.fr/nemo/browser/branches/2015/dev_r5721_CNRS9_NOC3_LDF 2015/dev_r5721_CNRS9_NOC3_LDF]43 modifications associated with the reduction of scale factors in some straits. No more needed: [[BR]]addition of unaltered surface (e1e2u, e1e2v) in coordinates.nc when scale factors are reduced in some straits.[[BR]]===>>> remove hard coded part, modify coordinates.nc [[BR]]'''DONE in ''' [https://forge.ipsl.jussieu.fr/nemo/browser/branches/2015/dev_r5721_CNRS9_NOC3_LDF 2015/dev_r5721_CNRS9_NOC3_LDF] 43 44 44 [[BR]] '''dtatsd, dtauvd.F90''' : in ORCA_R2 case, some hand made alterations in Red and Med Seas as well as changes associated with cross-land advection. Can be removed. If someone wants similar things, he has to modify the T-S data file.45 [[BR]] '''dtatsd, dtauvd.F90''' : 45 46 46 ''' ===>>> remove hard coded part'''47 in ORCA_R2 case, some hand made alterations in Red and Med Seas as well as changes associated with cross-land advection. [[BR]]Can be removed. If someone wants similar things, he has to modify the T-S data file.[[BR]]'''===>>> remove hard coded part''' 47 48 48 [[BR]] '''istate.F90''' : analytical initial state for EEL and GYRE49 [[BR]] '''istate.F90''' : 49 50 50 ''' ===>>> to be kept'''51 analytical initial state for EEL and GYRE[[BR]]'''===>>> to be kept util USER defined modules are introduced''' 51 52 52 [[BR]] '''ldfslp.F90''' : alteration of the slope for ORCA 4° only. No more necessary53 [[BR]] '''ldfslp.F90''' : 53 54 54 ===>>> remove hard coded part ''' DONE in '''[https://forge.ipsl.jussieu.fr/nemo/browser/branches/2015/dev_r5721_CNRS9_NOC3_LDF 2015/dev_r5721_CNRS9_NOC3_LDF]55 alteration of the slope for ORCA 4° only. No more needed.[[BR]]===>>> remove hard coded part [[BR]]'''DONE in ''' [https://forge.ipsl.jussieu.fr/nemo/browser/branches/2015/dev_r5721_CNRS9_NOC3_LDF 2015/dev_r5721_CNRS9_NOC3_LDF] 55 56 56 [[BR]] '''ldftra.F90 (ldf_eiv)''' : hard coded alteration of the eiv coef. in orca2 case. Now the eiv coef. can be provided in a file57 [[BR]] '''ldftra.F90 (ldf_eiv)''' : 57 58 58 ===>>> remove hard coded part ''' DONE in '''[https://forge.ipsl.jussieu.fr/nemo/browser/branches/2015/dev_r5721_CNRS9_NOC3_LDF 2015/dev_r5721_CNRS9_NOC3_LDF]59 hard coded alteration of the eiv coef. in orca2 case. [[BR]]Now the eiv coef. can be provided in a file[[BR]]===>>> remove hard coded part [[BR]]'''DONE in ''' [https://forge.ipsl.jussieu.fr/nemo/browser/branches/2015/dev_r5721_CNRS9_NOC3_LDF 2015/dev_r5721_CNRS9_NOC3_LDF] 59 60 60 [[BR]] '''p4zsbc.F90''' : hard coded enhance coastal supply of iron for ORCA2. Since a file is provided that can contains the specificity of ORCA 2°61 [[BR]] '''p4zsbc.F90''' : 61 62 62 ''' ===>>> remove hard coded part'''63 hard coded enhance coastal supply of iron for ORCA2. [[BR]]Since a file is provided that can contains the specificity of ORCA 2°[[BR]]'''===>>> remove hard coded part''' 63 64 64 [[BR]] '''sbcrnf.F90''' : hard coded uunoff reduction only associated to the ORCA2_LIM. It is associated with an old runoff file may lead to bug!65 [[BR]] '''sbcrnf.F90''' : 65 66 66 ''' ===>>> remove hard coded part '''67 hard coded runoff reduction only associated to the ORCA2_LIM. [[BR]]It is associated with an old runoff file may lead to bug! [[BR]]===>>> remove hard coded part[[BR]]'''DONE in '''2015/dev_r5721_CNRS9_NOC3_ZDF 67 68 68 [[BR]] '''traadv_cen2.F90''' : hard coded upstream in vicinity of river mouth and freezing point. As cen2 is no more used in ORCA configuration, juste remove everything and keep a standard 2nd order centered scheme.69 [[BR]] '''traadv_cen2.F90''' : 69 70 70 ===>>> remove hard coded part ''' DONE in ''' [https://forge.ipsl.jussieu.fr/nemo/browser/branches/2015/dev_r5721_CNRS9_NOC3_LDF 2015/dev_r5721_CNRS9_NOC3_LDF](now traadv_cen.F90)71 hard coded upstream in vicinity of river mouth and freezing point. [[BR]]As cen2 is no more used in ORCA configuration, [[BR]]just remove everything and keep a standard 2nd order centered scheme.[[BR]]===>>> remove hard coded part [[BR]]'''DONE in ''' [https://forge.ipsl.jussieu.fr/nemo/browser/branches/2015/dev_r5721_CNRS9_NOC3_LDF 2015/dev_r5721_CNRS9_NOC3_LDF] (now traadv_cen.F90) 71 72 72 [[BR]] trabbl.F90 : ORCA 4° & 2°, regional enhancement of ah_bbl 73 '''trabbl.F90''' : 73 74 74 ''' ===>>> to be suppress '''75 ORCA 4° & 2°, regional enhancement of ah_bbl [[BR]]===>>> to be suppress [[BR]]'''DONE in '''2015/dev_r5721_CNRS9_NOC3_ZDF 75 76 76 '''ldfdyn.F90''' : specific viscosity in ORCA 2° and ORCA 1°. Read them in an input file (+ add in TOOLS a fortran program as an example of how generate the input file)77 '''ldfdyn.F90''' : 77 78 78 ===>>> remove hard coded part ''' DONE in '''[https://forge.ipsl.jussieu.fr/nemo/browser/branches/2015/dev_r5721_CNRS9_NOC3_LDF 2015/dev_r5721_CNRS9_NOC3_LDF]79 specific viscosity in ORCA 2° and ORCA 1°. Read them in an input file[[BR]](+ add in TOOLS a fortran program as an example of how generate the input file)[[BR]]===>>> remove hard coded part [[BR]]'''DONE in ''' [https://forge.ipsl.jussieu.fr/nemo/browser/branches/2015/dev_r5721_CNRS9_NOC3_LDF 2015/dev_r5721_CNRS9_NOC3_LDF] 79 80 80 [[BR]] '''tradmp.F90 ; trcdmp.F90''' : hard coded definition of damping area for ORCA 2°, 1°, 0.5°. Read them in an input file (+ add in TOOLS a fortran program as an example of how generate the input file) 81 '''tradmp.F90 ; trcdmp.F90''' : 81 82 82 ''' ===>>> remove hard coded part ''' 83 84 hard coded definition of damping area for ORCA 2°, 1°, 0.5°. Read them in an input file [[BR]](+ add in TOOLS a fortran program as an example of how generate the input file)[[BR]]===>>> remove hard coded part[[BR]]'''DONE in''' nemo_v3_6_STABLE 83 85 84 ---- 86 '''trcdmp.F90''' : 87 88 89 90 hard coded definition of damping in closed seas for ORCA 2°, 1°, 0.5°. [[BR]]'''===>>> Find a solution''' similar to what will be done for closed seas in OPA (close.F90)