Last edited Timestamp?
Author : Daniel Lea
ticket : #1314
Branch : dev_r4650_UKMO14.11_SETTE_OBSASM
Review : wiki:1314/Review
Description
Implement assimilation interface SETTE test
Create a SETTE test configuration which includes observation operator and increments tests, to ensure that future NEMO developments do not break OBS and ASM.
Testing
Testing could consider (where appropriate) other configurations in addition to SETTE].
| SETTE Tested | YES |
| Other model configurations | NO |
| Processor configurations tested | 4x8, 8x4, 2x8, 4x4 |
| If adding new functionality please confirm that the New code doesn't change results when it is switched off and ''works'' when switched on | YES |
(Answering UNSURE is likely to generate further questions from reviewers.)
'Please add further summary details here'
- Configurations tested: Gyre, Orca2-LIM-PISCES, SAS
Bit Comparability
| Does this change preserve answers in your tested standard configurations (to the last bit) ? | YES |
| Does this change bit compare across various processor configurations. (1xM, Nx1 and MxN are recommended). Tested with the standard SETTE configs (see above) | YES |
| Is this change expected to preserve answers in all possible model configurations? | YES |
| Is this change expected to preserve all diagnostics? ,,''Preserving answers in model runs does not necessarily imply preserved diagnostics. '' | YES |
If you answered '''NO''' to any of the above, please provide further details:
- Which routine(s) are causing the difference?
- Why the changes are not protected by a logical switch or new section-version
- What is needed to achieve regression with the previous model release (e.g. a regression branch, hand-edits etc). If this is not possible, explain why not.
- What do you expect to see occur in the test harness jobs?
- Which diagnostics have you altered and why have they changed?Please add details here........
System Changes
| Does your change alter namelists? | YES |
| Does your change require a change in compiler options? | NO |
The namelist changes are really bug fixes. If key_diaobs is set and you provide no SST data the model will fail because of the reference namelist. Therefore I have set ln_sst and ln_reysst to default to false. I also changed the default filenames and added a sea ice default.
Resources
''Please ''summarize'' any changes in runtime or memory use caused by this change......''
No change in memory. Possible slight increase in runtime due to outputting additional observation diagnostics. But very minimal/negligible.
IPR issues
| Has the code been wholly (100%) produced by NEMO developers staff working exclusively on NEMO? | YES and NO |
If No:
- Identify the collaboration agreement details
- Ensure the code routine header is in accordance with the agreement, (Copyright/Redistribution? etc).Add further details here if required..........
The developer (me) is also part of the NEMOVAR consortium.
