Changes between Initial Version and Version 1 of 2014WP/ticket/1314/Review


Ignore:
Timestamp:
2014-09-22T18:04:41+02:00 (6 years ago)
Author:
djlea
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • 2014WP/ticket/1314/Review

    v1 v1  
     1Last edited [[Timestamp]] 
     2 
     3[[PageOutline]] 
     4 
     5== For completion by the Sci/Tech/Code reviewer == 
     6'''Reviewer:''' [ Enter your name here ] 
     7 
     8=== Ticket Details, Documentation and Code changes === 
     9||Do you understand the area of code being altered and the reasoning why it is being altered?||YES/NO|| 
     10||Do the proposed code changes correspond with the stated reason for the change?||YES/NO|| 
     11||Is the in-line documentation accurate and sufficient?||YES/NO|| 
     12||Do the code changes comply with NEMO coding standards?||YES/NO|| 
     13||Is the Ticket documented with sufficient detail for others to understand the impact of the change?||YES/NO|| 
     14||Does any corresponding external documentation require updating?||YES/NO|| 
     15||If yes, which docs and have the updates been drafted?||YES/NO|| 
     16||Are namelist changes required for this change?||YES/NO|| 
     17||If yes, have they been done?||YES/NO|| 
     18||Has a completed Ticket Summary template been appended to the ticket to aid code reviews||YES/NO|| 
     19||Does this summary correspond with your understanding of the full ticket?||YES/NO|| 
     20 
     21Ticket, Documentation and Code comments 
     22 
     23Add specific Ticket, Documentation and code comments here 
     24 
     25=== Testing === 
     26||Has the NVTK and other jobs been tested with this change?||YES/NO|| 
     27||Have the required bit comparability tests been run?||YES/NO|| 
     28||Can this change be shown to have a null impact? (if option not selected)||YES/NO|| 
     29||If no, is reason for the change valid/understood?||YES/NO/NA|| 
     30||If no, ensure that the ticket details the impact this change will have on model configurations .||YES/NO/NA|| 
     31||Is this change expected to preserve all diagnostics?||YES/NO|| 
     32||If no, is reason for the change valid/understood?||YES/NO/NA|| 
     33||Are there significant changes in run time/memory?||YES/NO|| 
     34 
     35Testing Comments 
     36 
     37Add specific testing comments here 
     38 
     39Add specific testing comments here 
     40 
     41=== Code Review === 
     42||Do the code changes comply with NEMO coding standards?||YES/NO|| 
     43||Are code changes consistent with the design of NEMO?||YES/NO|| 
     44||Is the code free of unwanted TABs?||YES/NO|| 
     45||Has the code been wholly (100%) produced by NEMO developers working on NEMO?||YES/NO|| 
     46||If no, ensure collaboration agreement has been added to the ticket keywords|||| 
     47 
     48Add specific code comments or suggested alterations here. 
     49 
     50=== Review Summary === 
     51Add summary here 
     52 
     53=== Approval for the trunk === 
     54YES/NO 
     55 
     56The code reviewer may approve the change for the NEMO trunk when: 
     57 
     58 1. their requests/comments have been addressed satisfactorily. 
     59 1. the above check-list has been completed. 
     60 
     61or the code reviewer may choose to reject & assign the change back to the code author.