New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
2014WP/ticket/1314 (diff) – NEMO

Changes between Version 6 and Version 7 of 2014WP/ticket/1314


Ignore:
Timestamp:
2014-10-20T16:15:49+02:00 (10 years ago)
Author:
flavoni
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • 2014WP/ticket/1314

    v6 v7  
    1 [[PageOutline]] 
    2 Last edited [[Timestamp]] 
    3  
    4 [[BR]] 
     1[[PageOutline]] Last edited [[Timestamp]] 
    52 
    63'''Author''' : Daniel Lea 
     
    85'''ticket''' : #1314 
    96 
    10 '''Branch''' : [https://forge.ipsl.jussieu.fr/nemo/browser/branches/2014/dev_r4650_UKMO14.11_SETTE_OBSASM      dev_r4650_UKMO14.11_SETTE_OBSASM ]  
     7'''Branch''' : [https://forge.ipsl.jussieu.fr/nemo/browser/branches/2014/dev_r4650_UKMO14.11_SETTE_OBSASM dev_r4650_UKMO14.11_SETTE_OBSASM] 
    118 
    129'''Review''' :  wiki:1314/Review 
     10 
    1311---- 
    14  
    1512=== Description === 
    16  
    1713Implement assimilation interface SETTE test 
    1814 
     
    2117---- 
    2218=== Testing === 
    23 Testing could consider (where appropriate) other configurations in addition to NVTK]. 
     19Testing could consider (where appropriate) other configurations in addition to SETTE]. 
    2420 
    25 ||SETTE Tested||YES|| 
    26 ||Other model configurations||NO|| 
    27 ||Processor configurations tested||4x8, 8x4, 2x8, 4x4|| 
    28 ||If adding new functionality please confirm that the [[BR]]New code doesn't change results when it is switched off [[BR]]and !''works!'' when switched on||YES|| 
     21|| SETTE Tested || YES || 
     22|| Other model configurations || NO || 
     23|| Processor configurations tested || 4x8, 8x4, 2x8, 4x4 || 
     24|| If adding new functionality please confirm that the [[BR]]New code doesn't change results when it is switched off [[BR]]and !''works!'' when switched on || YES || 
    2925 
    3026(Answering UNSURE is likely to generate further questions from reviewers.) 
     
    3329 
    3430 * Configurations tested: Gyre, Orca2-LIM-PISCES, SAS 
    35   
     31 
    3632=== Bit Comparability === 
    37 ||Does this change preserve answers in your tested standard configurations (to the last bit) ?||YES|| 
    38 ||Does this change bit compare across various processor configurations. (1xM, Nx1 and MxN are recommended). Tested with the standard SETTE configs (see above) ||YES|| 
    39 ||Is this change expected to preserve answers in all possible model configurations?||YES|| 
    40 ||Is this change expected to preserve all diagnostics? [[BR]]!,,!''Preserving answers in model runs does not necessarily imply preserved diagnostics. !''||YES|| 
     33|| Does this change preserve answers in your tested standard configurations (to the last bit) ? || YES || 
     34||Does this change bit compare across various processor configurations. (1xM, Nx1 and MxN are recommended). Tested with the standard SETTE configs (see above) || YES || 
     35|| Is this change expected to preserve answers in all possible model configurations? || YES || 
     36|| Is this change expected to preserve all diagnostics? [[BR]]!,,!''Preserving answers in model runs does not necessarily imply preserved diagnostics. !'' || YES || 
    4137 
    4238If you answered !'''NO!''' to any of the above, please provide further details: 
     
    5046---- 
    5147=== System Changes === 
    52 ||Does your change alter namelists?||YES|| 
    53 ||Does your change require a change in compiler options?||NO|| 
     48|| Does your change alter namelists? || YES || 
     49|| Does your change require a change in compiler options? || NO || 
    5450 
    5551The namelist changes are really bug fixes. If key_diaobs is set and you provide no SST data the model will fail because of the reference namelist. Therefore I have set ln_sst and ln_reysst to default to false. I also changed the default filenames and added a sea ice default. 
     
    6359---- 
    6460=== IPR issues === 
    65 ||Has the code been wholly (100%) produced by NEMO developers staff working exclusively on NEMO?||YES and NO|| 
     61|| Has the code been wholly (100%) produced by NEMO developers staff working exclusively on NEMO? || YES and NO || 
    6662 
    6763If No: