New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
2017WP/ENHANCE-14_Jerome_SAL (diff) – NEMO

Changes between Version 4 and Version 5 of 2017WP/ENHANCE-14_Jerome_SAL


Ignore:
Timestamp:
2017-07-24T14:33:43+02:00 (7 years ago)
Author:
cbricaud
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • 2017WP/ENHANCE-14_Jerome_SAL

    v4 v5  
    2525 
    2626|| '''Action'''       || ENHANCE-14_Jerome_SAL                                                      || 
    27 || '''PI(S)'''        || Jerome Chanut, Ariane Koch-Larrouy                                         || 
     27|| '''PI(S)'''        || Jerome Chanut                                  || 
    2828{{{#!td 
    2929'''Digest''' 
     
    4040|| '''Dependencies''' || ''Depends on ...''                                                         || 
    4141|| '''Target'''       || ''Expected end 2017: development/running OK; expected to by done for Merge Party next decemberPriority or deadline''                                                   || 
    42 || '''Trac Ticket'''  || #XXXX                                                                      || 
     42|| '''Trac Ticket'''  || #1926                                                                      || 
    4343|| '''SVN branch'''   || [source:/branches//2017/dev_r8329_ENHANCE14_SAL dev_r8329_ENHANCE14_SAL    || 
    4444|| '''Previewer(s)''' || ''Names''                                                                  || 
    4545|| '''Reviewer(s)'''  || ''Names''                                                                  || 
    46 || '''Status'''       || ''!Pending/In progress/Postponed/Ready''                                   || 
     46|| '''Status'''       || ''progress''                                   || 
    4747|| '''Link'''         || [[ExtractUrl(.)]]                                                          ||   
    4848 
     
    6767=== Description 
    6868 
    69  [tf.textarea:description -id=piform -class=taform 'Describe the goal of development, and the methodology.\n\nAdd reference documents or publications if relevant.' 0 20] 
     69  add Ocean self‐attraction and loading in NEMO 
     70  see [https://doi.org/10.1016/j.ocemod.2010.01.007 Arric 2010] 
     71 
     72  
    7073 
    7174=== Implementation 
    7275 
    73  [tf.textarea:implementation -id=piform -class=taform 'Describe flow chart of the changes in the code.\n\nList the .F90 files and modules to be changed.\n\nDetailed list of new variables (including namelists) to be defined.\nGive for each the chosen name (following coding rules) and definition.' 0 20] 
     76    -  load potential is read in tide_init_load subroutine in sbctide routine 
     77    -  used in tide_init_potential  
     78    -  activivation in nam_sbctide namelist_ref block with  ln_tide_load and potential filename 
    7479 
    7580=== Reference manual and web pages updates 
    7681 
    77  [tf.textarea:manual -id=piform -class=taform 'Using part 1 and 2, define the summary of changes to be done in the NEMO reference manual (tex files), and in the content of web pages.' 0 20] 
     82TexFiles/Chapters/Chap_SBC.tex 
     83TexFiles/Bibliography/Biblio.bib 
    7884 
    79 '''''Updated on [tf.form_updated_on:] by [tf.form_updater:]''''' 
     85  
    8086 
    8187}}} 
     
    119125 
    120126|| Questions || Answer || Comment || 
    121 || Can this change be shown to produce expected impact? (if option activated)? || [tf.select:3.1 -id=piform '' Yes No NR] || [tf.textarea:3.1c -id=piform 'Add a comment?' 50 10] || 
    122 || Can this change be shown to have a null impact? (if option not activated) || [tf.select:3.2 -id=piform '' Yes No NR] || [tf.textarea:3.2c -id=piform 'Add a comment?' 50 10] || 
    123 || Detailed results of restartability and reproducibility when the option is activated. Please indicate the configuration used for this test || [tf.select:3.3 -id=piform '' Yes No NR] || [tf.textarea:3.3c -id=piform 'Add a comment?' 50 10] || 
    124 || Detailed results of SETTE tests (restartability and reproducibility for each of the reference configuration) || [tf.select:3.4 -id=piform '' Yes No NR] || [tf.textarea:3.4c -id=piform 'Add a comment?' 50 10] || 
    125 || Results of the required bit comparability tests been run: Are there no differences when activating the development? || [tf.select:3.5 -id=piform '' Yes No NR] || [tf.textarea:3.5c -id=piform 'Add a comment?' 50 10] || 
    126 || If some differences appear, is reason for the change valid/understood? || [tf.select:3.6 -id=piform '' Yes No NR] || [tf.textarea:3.6c -id=piform 'Add a comment?' 50 10] || 
     127|| Can this change be shown to produce expected impact? (if option activated)? || [tf.select:3.1 -id=piform '' Yes] || [tf.textarea:3.1c -id=piform 'Add a comment?' 50 10] || 
     128|| Can this change be shown to have a null impact? (if option not activated) || [tf.select:3.2 -id=piform '' Yes ] || [tf.textarea:3.2c -id=piform 'Add a comment?' 50 10] || 
     129|| Detailed results of restartability and reproducibility when the option is activated. Please indicate the configuration used for this test || [tf.select:3.3 -id=piform '' Yes ] || [tf.textarea:3.3c -id=piform 'Add a comment?' 50 10] || 
     130|| Detailed results of SETTE tests (restartability and reproducibility for each of the reference configuration) || [tf.select:3.4 -id=piform '' Yes ] || [tf.textarea:3.4c -id=piform 'Add a comment?' 50 10] || 
     131|| Results of the required bit comparability tests been run: Are there no differences when activating the development? || [tf.select:3.5 -id=piform '' Yes] || [tf.textarea:3.5c -id=piform 'Add a comment?' 50 10] || 
     132|| If some differences appear, is reason for the change valid/understood? || [tf.select:3.6 -id=piform '' No] || [tf.textarea:3.6c -id=piform 'Add a comment?' 50 10] || 
    127133|| If some differences appear, is the !ticket describing in detail the impact this change will have on model configurations? || [tf.select:3.7 -id=piform '' Yes No NR] || [tf.textarea:3.7c -id=piform 'Add a comment?' 50 10] || 
    128 || Is this change expected to preserve all diagnostics? || [tf.select:3.8 -id=piform '' Yes No NR] || [tf.textarea:3.8c -id=piform 'Add a comment?' 50 10] || 
     134|| Is this change expected to preserve all diagnostics? || [tf.select:3.8 -id=piform '' No] || [tf.textarea:3.8c -id=piform 'Add a comment?' 50 10] || 
    129135|| If no, is reason for the change valid/understood? || [tf.select:3.9 -id=piform '' Yes No NR] || [tf.textarea:3.9c -id=piform 'Add a comment?' 50 10] || 
    130 || Are there significant changes in run time/memory? || [tf.select:3.10 -id=piform '' Yes No NR] || [tf.textarea:3.10c -id=piform 'Add a comment?' 50 10] || 
     136|| Are there significant changes in run time/memory? || [tf.select:3.10 -id=piform '' No] || [tf.textarea:3.10c -id=piform 'Add a comment?' 50 10] || 
    131137|| ... ... ... || [tf.select:3.XX -id=piform '' Yes No NR] || [tf.textarea:3.XXc -id=piform 'Add a comment?' 50 10] || 
    132138