Changes between Version 2 and Version 3 of 2019WP/AGRIF-01_jchanut_small_jpi_jpj


Ignore:
Timestamp:
2019-05-14T11:54:32+02:00 (18 months ago)
Author:
jchanut
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • 2019WP/AGRIF-01_jchanut_small_jpi_jpj

    v2 v3  
    1313}}} 
    1414{{{#!td 
    15 Remove restriction on minimum mpp subdomain size with AGRIF. It is actually limited by the sponge size (2*nraff+nbghostcells, e.g. 9-13 points)  
     15Remove restriction on minimum mpp subdomain size with AGRIF. 
    1616}}} 
    1717|- 
    1818||=Dependencies ||                                                                        || 
    19 ||=Expected for ||                                                                        || 
     19||=Expected for || 2019WP                                                                 || 
    2020||=Ticket       || #2199                                                                  || 
    2121||=Branch       || [source:/NEMO/branches/2019/dev_r{REV}_AGRIF-01_jchanut_small_jpi_jpj] || 
    22 ||=Previewer(s) ||                                                                        || 
    23 ||=Reviewer(s)  ||                                                                        || 
     22||=Previewer(s) || S. Masson                                                              || 
     23||=Reviewer(s)  || S. Masson                                                              || 
    2424||=Link         || [[ExtractUrl(.)]]   
    2525 
    2626 
    27 == Preview  
     27== Abstract 
    2828 
    29 {{{#!box help 
    30 [[Include(wiki:Developers/DevProcess#preview_)]] 
     29{{{ 
     30AGRIF zooms have a minimum size that depends, at least, on the sponge width.  
     31Since the sponge is 2 parent grid cells wide, this leads to a minimum sub domain size of 2*nraff+nbghostcells, e.g. 9-13 points. 
    3132}}} 
    3233 
    33 == Tests 
     34{{{#!TracForm 
     35#!subcontext abstract 
     36#!submit_label 'Save Abstract' 
     37#!keep_history yes 
    3438 
    35 {{{#!box help 
    36 [[Include(wiki:Developers/DevProcess#tests)]] 
     39 
     40=== Description 
     41 
     42 [tf.textarea:description -id=piform -class=taform 'Describe the goal of development, and the methodology.\n\nAdd reference documents or publications if relevant.' 0 20] 
     43 
     44 
     45=== Implementation 
     46 
     47 [tf.textarea:implementation -id=piform -class=taform 'Describe flow chart of the changes in the code.\n\nList the .F90 files and modules to be changed.\n\nDetailed list of new variables (including namelists) to be defined. Give for each the chosen name (following coding rules) and definition.' 0 20] 
     48 
     49 
     50=== Reference manual and web pages updates 
     51 
     52 [tf.textarea:manual -id=piform -class=taform 'Using part 1 and 2, define the summary of changes to be done in the NEMO reference manual (tex files), and in the content of web pages.' 0 20] 
     53 
     54'''''Updated on [tf.form_updated_on:] by [tf.form_updater:]''''' 
     55 
    3756}}} 
    3857 
    39 == Review 
     58Once the PI has completed this section, he should send a mail to the previewer(s) asking them to preview the work within two weeks. 
    4059 
    41 {{{#!box help 
    42 [[Include(wiki:Developers/DevProcess#review)]] 
     60 
     61{{{#!Fold title=Preview tag=h2 
     62Since the preview step must be completed before the PI starts the coding, the previewer(s) answers are expected to be completed within the two weeks after the PI has sent his request. \\ 
     63For each question, an iterative process should take place between PI and previewer(s) in order to reach a "YES" answer for each of the following questions. 
     64 
     65{{{#!TracForm 
     66#!subcontext preview_ 
     67#!submit_label 'Save Preview' 
     68 
     69||= Questions =||= Answer =||= Comment =|| 
     70|| Does the previewer agree with the proposed methodology? || [tf.select:2.1 -id=preform '' Yes No NR] || [tf.textarea:2.1c -id=preform 'Add a comment?' 50 10] || 
     71|| Does the previewer agree with the proposed flowchart and list of routines to be changed? || [tf.select:2.2 -id=preform '' Yes No NR] || [tf.textarea:2.2c -id=preform 'Add a comment?' 50 10] || 
     72|| Does the previewer agree with the proposed new list of variables, including agreement with coding rules? || [tf.select:2.3 -id=preform '' Yes No NR] || [tf.textarea:2.3c -id=preform 'Add a comment?' 50 10] || 
     73|| Does the previewer agree with the proposed summary of updates in reference manual? || [tf.select:2.4 -id=preform '' Yes No NR] || [tf.textarea:2.4c -id=preform 'Add a comment?' 50 10] || 
     74|| ... ... ... || [tf.select:2.X -id=preform '' Yes No NR] || [tf.textarea:2.Xc -id=preform 'Add a comment?' 50 10] || 
     75 
     76'''''Updated on [tf.form_updated_on:] by [tf.form_updater:]''''' 
     77 
    4378}}} 
     79 
     80Once all "YES" have been reached, the PI can start the development into his development branch. 
     81 
     82}}} 
     83 
     84 
     85{{{#!Fold title=Tests tag=h2 
     86 
     87Once the development is done, the PI should complete this section below and ask the reviewers to start their review in the lower section. 
     88 
     89{{{#!TracForm 
     90#!subcontext tests 
     91#!submit_label 'Save Tests' 
     92 
     93||= Questions =||= Answer =||= Comment =|| 
     94|| Can this change be shown to produce expected impact? (if option activated)? || [tf.select:3.1 -id=piform '' Yes No NR] || [tf.textarea:3.1c -id=piform 'Add a comment?' 50 10] || 
     95|| Can this change be shown to have a null impact? (if option not activated) || [tf.select:3.2 -id=piform '' Yes No NR] || [tf.textarea:3.2c -id=piform 'Add a comment?' 50 10] || 
     96|| Detailed results of restartability and reproducibility when the option is activated. Please indicate the configuration used for this test || [tf.select:3.3 -id=piform '' Yes No NR] || [tf.textarea:3.3c -id=piform 'Add a comment?' 50 10] || 
     97|| Detailed results of SETTE tests (restartability and reproducibility for each of the reference configuration) || [tf.select:3.4 -id=piform '' Yes No NR] || [tf.textarea:3.4c -id=piform 'Add a comment?' 50 10] || 
     98|| Results of the required bit comparability tests been run: Are there no differences when activating the development? || [tf.select:3.5 -id=piform '' Yes No NR] || [tf.textarea:3.5c -id=piform 'Add a comment?' 50 10] || 
     99|| If some differences appear, is reason for the change valid/understood? || [tf.select:3.6 -id=piform '' Yes No NR] || [tf.textarea:3.6c -id=piform 'Add a comment?' 50 10] || 
     100|| If some differences appear, is the !ticket describing in detail the impact this change will have on model configurations? || [tf.select:3.7 -id=piform '' Yes No NR] || [tf.textarea:3.7c -id=piform 'Add a comment?' 50 10] || 
     101|| Is this change expected to preserve all diagnostics? || [tf.select:3.8 -id=piform '' Yes No NR] || [tf.textarea:3.8c -id=piform 'Add a comment?' 50 10] || 
     102|| If no, is reason for the change valid/understood? || [tf.select:3.9 -id=piform '' Yes No NR] || [tf.textarea:3.9c -id=piform 'Add a comment?' 50 10] || 
     103|| Are there significant changes in run time/memory? || [tf.select:3.10 -id=piform '' Yes No NR] || [tf.textarea:3.10c -id=piform 'Add a comment?' 50 10] || 
     104|| ... ... ... || [tf.select:3.XX -id=piform '' Yes No NR] || [tf.textarea:3.XXc -id=piform 'Add a comment?' 50 10] || 
     105 
     106'''''Updated on [tf.form_updated_on:] by [tf.form_updater:]''''' 
     107 
     108}}} 
     109 
     110}}} 
     111 
     112 
     113{{{#!Fold title=Review tag=h2 
     114 
     115{{{#!box critical 
     116A successful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November~December). 
     117}}} 
     118 
     119{{{#!TracForm 
     120#!subcontext review 
     121#!submit_label 'Save Review' 
     122 
     123 
     124=== Code changes and documentation 
     125 
     126||= Question =||= Answer =||= Comment =|| 
     127|| Is the proposed methodology now implemented? || [tf.select:3.11 -id=revform '' Yes No NR] || [tf.textarea:3.11c -id=revform 'Add a comment?' 50 10] || 
     128|| Are the code changes in agreement with the flowchart defined at Preview step? || [tf.select:3.12 -id=revform '' Yes No NR] || [tf.textarea:3.12c -id=revform 'Add a comment?' 50 10] || 
     129|| Are the code changes in agreement with list of routines and variables as proposed at Preview step? \\If not, are the discrepancies acceptable? || [tf.select:3.13 -id=revform '' Yes No NR] || [tf.textarea:3.13c -id=revform 'Add a comment?' 50 10] || 
     130|| Is the in-line documentation accurate and sufficient? || [tf.select:3.14 -id=revform '' Yes No NR] || [tf.textarea:3.14c -id=revform 'Add a comment?' 50 10] || 
     131|| Do the code changes comply with NEMO coding standards? || [tf.select:3.15 -id=revform '' Yes No NR] || [tf.textarea:3.15c -id=revform 'Add a comment?' 50 10] || 
     132|| Is the !ticket of development documented with sufficient details for others to understand the impact of the change? || [tf.select:3.16 -id=revform '' Yes No NR] || [tf.textarea:3.16c -id=revform 'Add a comment?' 50 10] || 
     133|| Are the reference manual tex files now updated following the proposed summary in preview section? || [tf.select:3.17 -id=revform '' Yes No NR] || [tf.textarea:3.17c -id=revform 'Add a comment?' 50 10] || 
     134|| Is there a need for some documentation on the web pages (in addition to in-line and reference manual)? \\If yes, please describe and ask PI. A yes answer must include all documentation available. || [tf.select:3.18 -id=revform '' Yes No NR] || [tf.textarea:3.18c -id=revform 'Add a comment?' 50 10] || 
     135|| ... ... ... || [tf.select:3.XX -id=revform '' Yes No NR] || [tf.textarea:3.XXc -id=revform 'Add a comment?' 50 10] || 
     136 
     137 
     138==== Review Summary 
     139 
     140Is the review fully successful? [tf.select:status -id=revform '' Yes No] 
     141 
     142[tf.textarea:comment -id=revform 'If not, please indicate what is still missing.' 50 10] 
     143 
     144'''''Updated on [tf.form_updated_on:] by [tf.form_updater:]''''' 
     145 
     146 
     147}}} 
     148 
     149Once review is successful, the development must be scheduled for merge during next Merge Party Meeting. 
     150 
     151}}}