Changes between Version 3 and Version 4 of 2019WP/ENHANCE-09_Jerome_freesurface


Ignore:
Timestamp:
2017-10-25T10:41:22+02:00 (3 years ago)
Author:
jchanut
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • 2019WP/ENHANCE-09_Jerome_freesurface

    v3 v4  
    1 = '''''ENHANCE-4_Jerome_freesurface''''' 
    2  
     1= '''''ENHANCE-4_Jerome_freesurface''''' = 
    32The PI is responsible to closely follow the progress of the action, and especially to contact NEMO project manager if the delay on preview (or review) are longer than the 2 weeks expected. 
    43 
    5 == Help 
     4== Help == 
     5The action has to be detailed briefly in the 'Summary' section for later inclusion in other pages.\\ Edit the 'Summary' section as with an ordinary wiki page. 
    66 
    7 The action has to be detailed briefly in the 'Summary' section for later inclusion in other pages.\\ 
    8 Edit the 'Summary' section as with an ordinary wiki page. 
    9 * ''Italic formatting'' shows the default values or help. 
    10 * Set specific TracLinks (development ticket and branch). 
     7 * ''Italic formatting'' shows the default values or help. 
     8 * Set specific TracLinks (development ticket and branch). 
    119 
    1210Out of this, the rest of the page can be edited on-line inside the form fields considering the following color code given hereafter. 
    1311 
    1412{{{#!th 
    15    Role / Color code 
     13 
     14  Role / Color code 
     15 
    1616}}} 
     17 
    1718||  [[span(PI(S), style=background-color:lightgrey)]]  ||  [[span(Previewer(s), style=background-color:lightblue)]]  ||  [[span(Reviewer(s), style=background-color:lightgreen)]]  || 
    1819 
    1920Record your modifications for the section you have edited by clicking on the corresponding button at the end of the section with 'Save ...' button. Just above, the log record will be updated. 
    2021 
    21 The informations inside the form fields and this wiki page itself are stored in 2 separate databases.\\ 
    22 As a consequence, there is absolutely no risk to make any modification in the page itself as long as you don't rename the page or modify the source code of `{{{#!TracForm ... }}}` processors. 
     22The informations inside the form fields and this wiki page itself are stored in 2 separate databases.\\ As a consequence, there is absolutely no risk to make any modification in the page itself as long as you don't rename the page or modify the source code of `{{{#!TracForm ... }}}` processors. 
    2323 
    24 == Summary #summary 
     24== Summary == #summary 
     25|| '''Action''' || ENHANCE-4_Jerome_freesurface || 
     26|| '''PI(S)''' || Jérôme Chanut || 
    2527 
    26 || '''Action'''       || ENHANCE-4_Jerome_freesurface                                               || 
    27 || '''PI(S)'''        || Jérôme Chanut                                                              || 
    28 {{{#!td 
    29 '''Digest''' 
    30 }}} 
    31 {{{#!td 
    32 Improve split-explicit free surface: 
    33 * Tracer conservation issues (all time splitting options do not ensure global and local tracer conservation) 
    34 * Missing correction terms in the barotropic equations relative to internal pressure gradients. This would reduce mode splitting error, hence improve stability 
    35 * Work on the stability of barotropic time stepping (based on INRIA's work) to possibly remove time filtering of barotropic variables.\\ 
    36   This would limit the temporal dissipation and greatly ease online coupling of nested domains at barotropic level (with AGRIF). 
    37 }}} 
    38 |- 
    39 || '''Dependencies''' || ''Depends on ...''                                                         || 
    40 || '''Target'''       || ''started; need to be scientifically reviewed ; can be ready for merge 2017.'' || 
    41 || '''Trac Ticket'''  || #XXXX                                                                      || 
    42 || '''SVN branch'''   || [source:/branches/$YEAR/dev_r{REV}_{WGorINSTITUTE}-{NUM}_{PIS}-{KEYWORDS}] || 
    43 || '''Previewer(s)''' || ''Names''                                                                  || 
    44 || '''Reviewer(s)'''  || ''Names''                                                                  || 
    45 || '''Status'''       || In progress: an implementation exist                                       || 
    46 || '''Link'''         || [[ExtractUrl(.)]]                                                          ||   
     28{{{#!td '''Digest''' }}} {{{#!td Improve split-explicit free surface: 
    4729 
    48 {{{#!comment 
    49 DON'T REMOVE THIS VOID HEADING OR IT WILL BREAK THE INCLUDE FEATURE BETWEEN WIKI PAGES 
    50 }}} 
     30 * Tracer conservation issues (all time splitting options do not ensure global and local tracer conservation) 
     31 * Missing correction terms in the barotropic equations relative to internal pressure gradients. This would reduce mode splitting error, hence improve stability 
     32 * Work on the stability of barotropic time stepping (based on INRIA's work) to possibly remove time filtering of barotropic variables.\\ This would limit the temporal dissipation and greatly ease online coupling of nested domains at barotropic level (with AGRIF). 
     33 
     34}}} |- 
     35 
     36|| '''Dependencies''' || ''Depends on ...'' || 
     37|| '''Target''' || ''started; need to be scientifically reviewed ; can be ready for merge 2017.'' || 
     38|| '''Trac Ticket''' || !#1959 || 
     39|| '''SVN branch''' || [source:/branches/$YEAR/dev_r{REV}_{WGorINSTITUTE}-{NUM}_{PIS}-{KEYWORDS} /branches/2017/dev_r8624]_ENHANCE4_FREESURFACE || 
     40|| '''Previewer(s)''' || ''Gurvan Madec'' || 
     41|| '''Reviewer(s)''' || ''-'' || 
     42|| '''Status''' || In progress: an implementation exist || 
     43|| '''Link''' || [[ExtractUrl(.)]] || 
     44 
     45{{{#!comment DON'T REMOVE THIS VOID HEADING OR IT WILL BREAK THE INCLUDE FEATURE BETWEEN WIKI PAGES }}} 
     46 
    5147==  == 
    52 {{{#!comment 
    53 DON'T REMOVE THIS VOID HEADING OR IT WILL BREAK THE INCLUDE FEATURE BETWEEN WIKI PAGES 
    54 }}} 
     48{{{#!comment DON'T REMOVE THIS VOID HEADING OR IT WILL BREAK THE INCLUDE FEATURE BETWEEN WIKI PAGES }}} 
    5549 
    56 {{{#!Fold title=Abstract tag=h2 
    57 [=#abstract] 
     50{{{#!Fold title=Abstract tag=h2 [=#abstract] 
    5851 
    5952This section should be completed before starting to develop the code, in order to find agreement on the method beforehand. 
    6053 
    61 {{{#!TracForm 
    62 #!subcontext abstract 
    63 #!submit_label 'Save Abstract' 
    64 #!keep_history yes 
     54{{{#!TracForm #!subcontext abstract #!submit_label 'Save Abstract' #!keep_history yes 
    6555 
    66 === Description 
     56=== Description === 
     57  [tf.textarea:description -id=piform -class=taform 'Describe the goal of development, and the methodology.\n\nAdd reference documents or publications if relevant.' 0 20] 
    6758 
    68  [tf.textarea:description -id=piform -class=taform 'Describe the goal of development, and the methodology.\n\nAdd reference documents or publications if relevant.' 0 20] 
     59=== Implementation === 
     60  [tf.textarea:implementation -id=piform -class=taform 'Describe flow chart of the changes in the code.\n\nList the .F90 files and modules to be changed.\n\nDetailed list of new variables (including namelists) to be defined.\nGive for each the chosen name (following coding rules) and definition.' 0 20] 
    6961 
    70 === Implementation 
    71  
    72  [tf.textarea:implementation -id=piform -class=taform 'Describe flow chart of the changes in the code.\n\nList the .F90 files and modules to be changed.\n\nDetailed list of new variables (including namelists) to be defined.\nGive for each the chosen name (following coding rules) and definition.' 0 20] 
    73  
    74 === Reference manual and web pages updates 
    75  
    76  [tf.textarea:manual -id=piform -class=taform 'Using part 1 and 2, define the summary of changes to be done in the NEMO reference manual (tex files), and in the content of web pages.' 0 20] 
     62=== Reference manual and web pages updates === 
     63  [tf.textarea:manual -id=piform -class=taform 'Using part 1 and 2, define the summary of changes to be done in the NEMO reference manual (tex files), and in the content of web pages.' 0 20] 
    7764 
    7865'''''Updated on [tf.form_updated_on:] by [tf.form_updater:]''''' 
     
    8471}}} 
    8572 
    86 {{{#!Fold title=Preview tag=h2 
    87 [=#preview] 
     73{{{#!Fold title=Preview tag=h2 [=#preview] 
    8874 
    8975Since the preview step must be completed before the PI starts the coding, the previewer(s) answers are expected to be completed within the two weeks after the PI has sent his request.[[BR]]For each question, an iterative process should take place between PI and previewer(s) in order to reach a "YES" answer for each of the following questions. 
    9076 
    91 {{{#!TracForm 
    92 #!subcontext preview_ 
    93 #!submit_label 'Save Preview' 
     77{{{#!TracForm #!subcontext preview_ #!submit_label 'Save Preview' 
    9478 
    9579|| Questions || Answer || Comment || 
     
    10892}}} 
    10993 
    110 {{{#!Fold title=Tests tag=h2 
    111 [=#tests] 
     94{{{#!Fold title=Tests tag=h2 [=#tests] 
    11295 
    11396Once the development is done, the PI should complete this section below and ask the reviewers to start their review in the lower section. 
    11497 
    115 {{{#!TracForm 
    116 #!subcontext tests 
    117 #!submit_label 'Save Tests' 
     98{{{#!TracForm #!subcontext tests #!submit_label 'Save Tests' 
    11899 
    119100|| Questions || Answer || Comment || 
     
    136117}}} 
    137118 
    138 {{{#!Fold title=Review tag=h2 
    139 [=#review] 
     119{{{#!Fold title=Review tag=h2 [=#review] 
    140120 
    141121A successful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November). 
    142122 
    143 {{{#!TracForm 
    144 #!subcontext review 
    145 #!submit_label 'Save Review' 
     123{{{#!TracForm #!subcontext review #!submit_label 'Save Review' 
    146124 
    147 === Code changes and documentation 
    148  
     125=== Code changes and documentation === 
    149126|| Question || Answer || Comment || 
    150127|| Is the proposed methodology now implemented? || [tf.select:3.11 -id=revform '' Yes No NR] || [tf.textarea:3.11c -id=revform 'Add a comment?' 50 10] || 
     
    158135|| ... ... ... || [tf.select:3.XX -id=revform '' Yes No NR] || [tf.textarea:3.XXc -id=revform 'Add a comment?' 50 10] || 
    159136 
    160 ==== Review Summary 
    161  
     137==== Review Summary ==== 
    162138Is the review fully successful? [tf.select:status -id=revform '' Yes No] 
    163139