Changes between Version 4 and Version 5 of 2019WP/HPC-04_MCastrillo_HPDAonline DiagGPU


Ignore:
Timestamp:
2018-11-08T16:11:53+01:00 (23 months ago)
Author:
mcastril
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • 2019WP/HPC-04_MCastrillo_HPDAonline DiagGPU

    v4 v5  
    7979}}} 
    8080 
    81 == Preview  
     81{{{#!Fold title=Preview tag=h2 
     82Since the preview step must be completed before the PI starts the coding, the previewer(s) answers are expected to be completed within the two weeks after the PI has sent his request. \\ 
     83For each question, an iterative process should take place between PI and previewer(s) in order to reach a "YES" answer for each of the following questions. 
    8284 
    83 {{{#!box help 
    84 [[Include(wiki:Developers/DevProcess#preview_)]] 
     85{{{#!TracForm 
     86#!subcontext preview_ 
     87#!submit_label 'Save Preview' 
     88 
     89||= Questions =||= Answer =||= Comment =|| 
     90|| Does the previewer agree with the proposed methodology? || [tf.select:2.1 -id=preform '' Yes No NR] || [tf.textarea:2.1c -id=preform 'Add a comment?' 50 10] || 
     91|| Does the previewer agree with the proposed flowchart and list of routines to be changed? || [tf.select:2.2 -id=preform '' Yes No NR] || [tf.textarea:2.2c -id=preform 'Add a comment?' 50 10] || 
     92|| Does the previewer agree with the proposed new list of variables, including agreement with coding rules? || [tf.select:2.3 -id=preform '' Yes No NR] || [tf.textarea:2.3c -id=preform 'Add a comment?' 50 10] || 
     93|| Does the previewer agree with the proposed summary of updates in reference manual? || [tf.select:2.4 -id=preform '' Yes No NR] || [tf.textarea:2.4c -id=preform 'Add a comment?' 50 10] || 
     94|| ... ... ... || [tf.select:2.X -id=preform '' Yes No NR] || [tf.textarea:2.Xc -id=preform 'Add a comment?' 50 10] || 
     95 
     96'''''Updated on [tf.form_updated_on:] by [tf.form_updater:]''''' 
     97 
    8598}}} 
    8699 
    87 == Tests 
     100Once all "YES" have been reached, the PI can start the development into his development branch. 
    88101 
    89 {{{#!box help 
    90 [[Include(wiki:Developers/DevProcess#tests)]] 
    91102}}} 
    92103 
    93 == Review 
    94104 
    95 {{{#!box help 
    96 [[Include(wiki:Developers/DevProcess#review)]] 
     105{{{#!Fold title=Tests tag=h2 
     106 
     107Once the development is done, the PI should complete this section below and ask the reviewers to start their review in the lower section. 
     108 
     109{{{#!TracForm 
     110#!subcontext tests 
     111#!submit_label 'Save Tests' 
     112 
     113||= Questions =||= Answer =||= Comment =|| 
     114|| Can this change be shown to produce expected impact? (if option activated)? || [tf.select:3.1 -id=piform '' Yes No NR] || [tf.textarea:3.1c -id=piform 'Add a comment?' 50 10] || 
     115|| Can this change be shown to have a null impact? (if option not activated) || [tf.select:3.2 -id=piform '' Yes No NR] || [tf.textarea:3.2c -id=piform 'Add a comment?' 50 10] || 
     116|| Detailed results of restartability and reproducibility when the option is activated. Please indicate the configuration used for this test || [tf.select:3.3 -id=piform '' Yes No NR] || [tf.textarea:3.3c -id=piform 'Add a comment?' 50 10] || 
     117|| Detailed results of SETTE tests (restartability and reproducibility for each of the reference configuration) || [tf.select:3.4 -id=piform '' Yes No NR] || [tf.textarea:3.4c -id=piform 'Add a comment?' 50 10] || 
     118|| Results of the required bit comparability tests been run: Are there no differences when activating the development? || [tf.select:3.5 -id=piform '' Yes No NR] || [tf.textarea:3.5c -id=piform 'Add a comment?' 50 10] || 
     119|| If some differences appear, is reason for the change valid/understood? || [tf.select:3.6 -id=piform '' Yes No NR] || [tf.textarea:3.6c -id=piform 'Add a comment?' 50 10] || 
     120|| If some differences appear, is the !ticket describing in detail the impact this change will have on model configurations? || [tf.select:3.7 -id=piform '' Yes No NR] || [tf.textarea:3.7c -id=piform 'Add a comment?' 50 10] || 
     121|| Is this change expected to preserve all diagnostics? || [tf.select:3.8 -id=piform '' Yes No NR] || [tf.textarea:3.8c -id=piform 'Add a comment?' 50 10] || 
     122|| If no, is reason for the change valid/understood? || [tf.select:3.9 -id=piform '' Yes No NR] || [tf.textarea:3.9c -id=piform 'Add a comment?' 50 10] || 
     123|| Are there significant changes in run time/memory? || [tf.select:3.10 -id=piform '' Yes No NR] || [tf.textarea:3.10c -id=piform 'Add a comment?' 50 10] || 
     124|| ... ... ... || [tf.select:3.XX -id=piform '' Yes No NR] || [tf.textarea:3.XXc -id=piform 'Add a comment?' 50 10] || 
     125 
     126'''''Updated on [tf.form_updated_on:] by [tf.form_updater:]''''' 
     127 
    97128}}} 
     129 
     130}}} 
     131 
     132 
     133{{{#!Fold title=Review tag=h2 
     134 
     135{{{#!box critical 
     136A successful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November~December). 
     137}}} 
     138 
     139{{{#!TracForm 
     140#!subcontext review 
     141#!submit_label 'Save Review' 
     142 
     143 
     144=== Code changes and documentation 
     145 
     146||= Question =||= Answer =||= Comment =|| 
     147|| Is the proposed methodology now implemented? || [tf.select:3.11 -id=revform '' Yes No NR] || [tf.textarea:3.11c -id=revform 'Add a comment?' 50 10] || 
     148|| Are the code changes in agreement with the flowchart defined at Preview step? || [tf.select:3.12 -id=revform '' Yes No NR] || [tf.textarea:3.12c -id=revform 'Add a comment?' 50 10] || 
     149|| Are the code changes in agreement with list of routines and variables as proposed at Preview step? \\If not, are the discrepancies acceptable? || [tf.select:3.13 -id=revform '' Yes No NR] || [tf.textarea:3.13c -id=revform 'Add a comment?' 50 10] || 
     150|| Is the in-line documentation accurate and sufficient? || [tf.select:3.14 -id=revform '' Yes No NR] || [tf.textarea:3.14c -id=revform 'Add a comment?' 50 10] || 
     151|| Do the code changes comply with NEMO coding standards? || [tf.select:3.15 -id=revform '' Yes No NR] || [tf.textarea:3.15c -id=revform 'Add a comment?' 50 10] || 
     152|| Is the !ticket of development documented with sufficient details for others to understand the impact of the change? || [tf.select:3.16 -id=revform '' Yes No NR] || [tf.textarea:3.16c -id=revform 'Add a comment?' 50 10] || 
     153|| Are the reference manual tex files now updated following the proposed summary in preview section? || [tf.select:3.17 -id=revform '' Yes No NR] || [tf.textarea:3.17c -id=revform 'Add a comment?' 50 10] || 
     154|| Is there a need for some documentation on the web pages (in addition to in-line and reference manual)? \\If yes, please describe and ask PI. A yes answer must include all documentation available. || [tf.select:3.18 -id=revform '' Yes No NR] || [tf.textarea:3.18c -id=revform 'Add a comment?' 50 10] || 
     155|| ... ... ... || [tf.select:3.XX -id=revform '' Yes No NR] || [tf.textarea:3.XXc -id=revform 'Add a comment?' 50 10] || 
     156 
     157 
     158==== Review Summary 
     159 
     160Is the review fully successful? [tf.select:status -id=revform '' Yes No] 
     161 
     162[tf.textarea:comment -id=revform 'If not, please indicate what is still missing.' 50 10] 
     163 
     164'''''Updated on [tf.form_updated_on:] by [tf.form_updater:]''''' 
     165 
     166 
     167}}} 
     168 
     169Once review is successful, the development must be scheduled for merge during next Merge Party Meeting. 
     170 
     171}}}