New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
2020WP/HPC-02_Daley_Tiling (diff) – NEMO

Changes between Version 14 and Version 15 of 2020WP/HPC-02_Daley_Tiling


Ignore:
Timestamp:
2020-11-30T20:05:57+01:00 (3 years ago)
Author:
epico
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • 2020WP/HPC-02_Daley_Tiling

    v14 v15  
    578578== Review 
    579579 
    580 {{{#!box width=50em info 
    581 [[Include(wiki:Developers/DevProcess#review)]] 
    582 }}} 
    583  
    584 ''...'' 
     580Reviewer: Italo Epicoco (CMCC) 
     581Date: 30/11/2020 
     582 
     583* Is the proposed methodology now implemented? 
     584YES 
     585 
     586* Are the code changes in agreement with the flowchart defined at preview step? 
     587YES 
     588 
     589* Are the code changes in agreement with list of routines and variables as proposed at preview step? 
     590YES, only the files included in TRA module have been changed 
     591 
     592* Is the in-line documentation accurate and sufficient? 
     593YES 
     594 
     595*  Do the code changes comply with NEMO coding standards? 
     596YES 
     597 
     598* Is the development documented with sufficient details for others to understand the impact of the change? 
     599YES 
     600 
     601* Is the project literature (manual, guide, web, …) now updated or completed following the proposed summary in preview section?  
     602NO. 
     603The documentation about tiling should refer to the usage of the ln_tile, nn_ltile_i and nn_ltile_j variabiles added in the namelist. Moreover some hints to the user should be given to drive an efficient choice of the values for nn_ltile_i and nn_ltile_j. 
     604 
     605* Is the review fully successful? 
     606YES 
     607