New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
2020WP/KERNEL-01_Amy_Mike_newHPGschemes (diff) – NEMO

Changes between Version 5 and Version 6 of 2020WP/KERNEL-01_Amy_Mike_newHPGschemes


Ignore:
Timestamp:
2020-12-01T17:05:49+01:00 (3 years ago)
Author:
davestorkey
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • 2020WP/KERNEL-01_Amy_Mike_newHPGschemes

    v5 v6  
    7474[[Include(wiki:Developers/DevProcess#review)]] 
    7575}}} 
     76This review is for the rewriting of the implementation of the Shchpetkin and McWilliams (2003) scheme (hpg_djc option in NEMO). I have checked the implementation and discussed with Amy. I'm happy that the implementation conforms to the Shchpetkin and McWilliams specification and that it has been thoroughly tested. The code conforms to NEMO coding standards and the inline documentation is sufficient. The documentation in the NEMO book will be updated by the end of January as agreed. I'm happy for the code to be included in the 2020 merge. 
    7677 
    7778''...''