Changes between Version 11 and Version 12 of 2020WP/KERNEL-06_techene_better_e3_management

Timestamp:

2020-07-20T13:14:14+02:00 (4 years ago)

Author:

techene

Comment:

--

2020WP/KERNEL-06_techene_better_e3_management

@@ -1 @@
-= Name and subject of the action
+= Star coordinate faster implementation
+
+Change the way to deal with the vertical scale factors in NEMO in order to save parallel processing time for z-star coordinate. This modification can be activated through a cpp key : key_qco.
 
 Last edition: '''[[Wikinfo(changed_ts)]]''' by '''[[Wikinfo(changed_by)]]'''
@@ -16 +18 @@
 ||=Dependencies || If any                                                ||
 ||=Branch       || source:/NEMO/branches/2020/dev_r12377_KERNEL-06_techene_e3 ||
+||=Branch       || source:/NEMO/branches/2020/dev_r13324_KERNEL-06_techene_e3_version2 ||
 ||=Previewer(s) || Madec, Chanut, Masson                                 ||
 ||=Reviewer(s)  || Madec                                                 ||
@@ -22 +25 @@
 === Description
 
+NEMO current version requires memory for scale factor storage e3[P] at P-point computation uses interpolation of the e3t 4D table at P = {u-, v-, w-, f-, uw-, vw-} points. This means 7 4D tables stored in memory. The idea consists in computing scale factors e3[P](ji,jj,jk,Ktl)on the fly with r3[P] = ssh[P] / h_0 and e3[P]_0 instead of using memory. This should help to improve run time when running parrallel. Indeed, processors have as least two memory level : fast memory and slow RAM memory. In parrallel runs the processing time is no longer limited by computation time but by memory access time. That is the reason why trying to minimise memory buffering. 
+Asselin filter management is done recomputing r3[P] directly with the filtered ssh.
+z-tilde management is done through e3[P]_0 that may varies with time in the z-tilde case.
 
-The current e3[P] at P-point computation uses interpolation of the r3t 4D table at P = {u-, v-, w-, f-, uw-, vw-} points. This means 7 4D tables stored in memory. 
-The proposed optimisation consists in computing e3[P](ji,jj,jk,Ktl) on the fly using the r3[P] = ssh[P] / h_0 and the e3[P]_0. r3[P] is a 2D table, then this means only 4 2D tables stored in memory.
-z-tilde management is done through e3[P]_0 that may varies with time in the z-tilde case.
-Asselin filter management is done recomputing r3[P] directly with the filtered ssh.
 
 
@@ -38 +40 @@
 }}}
 
-Eventually, all the dom_vvl_interpol call are removed, each time e3 is called we use a substitute to replace e3 by e3_0 (1 + ssh / h_0). For backward compatibility a cpp key manages the use of the new version vs. the old version. We will duplicate modules such as step and domvvl into stepLF and domQE (QE stands for Quasi Eulerian) and create a subtitute module. 
+'''KERNEL-06's version 1 implementation : /NEMO/branches/2020/dev_r12377_KERNEL-06_techene_e3''' 
 
-Integrated in mid merge trunk. 
 
-List the Fortran modules and subroutines to be created.
-substitute.F90
+NEMO's version 12377 implements computation of scale factor at T-point with a leap frog integration or a filter and then scale factors at U-V-W-UW-VW-F-points from T-point interpolation through domvvl.F90 module.
+- at initialization or restart at all points
+- at time N+1 after sea surface time splitting integration and before the momentum integration at  T-U-W-points
+- at time N after the sea surface asselin filtering at  T-U-W-points
+- at the end of the time step after index switch F- and W-UW-VW-points are updated accordingly
+Because NEMO needs to take into account continuity issues, these modification are implemented under a cpp key key_qco for "quasi eulerian coordinate". When this key_qco is not activated NEMO should be exactly the same as the trunk. 
+
+NEMO intermediate version 1 implements scales factors computed from sea surface interpolation (2d field) instead but the whole structure of the code remains. Note that to validate "NEMO intermediate version 1" we change the code line by line and compare results of GYRE configuration with TOP de-activated. Differences in the results appear when changing the W-point scale factor interpolation from T-point scale factor into the sea surface scaling since the bottom level is not considered in the same way. Indeed for GYRE configuration e3w_0 are not the half sum of e3u_0, so the way it is implemented in the reference version is not convinient... 
+[Etape 1]
+
+NEMO intermediate version 2 implements scales factors computed from sea surface interpolation (2d field) instead. The initialisation compute sea surface to h_0 called r3 coefficients (which are 2d). These r3 coefficients are updated after each sea surface modification (after time splitting and asselin filtering) and interpolated at U-V-F-points using new but similar routines as  domvvl routines. An extra substitute routine helps to substitute each e3 to its expression (e3P_0 ( 1 + r3P ) * maskP). Sea surface filtering is displaced before Asselin filtering of speed (u,v) and tracer. This version 2 should give exactly the same results as version 1 and it does !
+[Etapes 2 & 3]
+
+NEMO intermediate version 3 deals with cleanning the code by adding the substitution and removing e3 computation along the code of OCE. It also takes care of the lines lenghts that should be shorter than 136 caracters, some are missing... 
+[Etapes 4 & 5]
+
+In order to take into account the new index/loop management, NEMO intermediate version 4 consists in merging the results with trunk 12698 the resulting revision is 12724. Note that in this new trunk revision Jerome changed the way to deal with Asselin filter (traatf and dynatf), intermediate version 4 needs to adapt accordingly.
+[Etape 6]
+
+NEMO intermediate version 5 implements a clean way to deal with the key_qco and also deals with the removal of gde* and h* of memory. It removes e3 from the whole code, to deal with TOP there is to play with pointer of the sea surface height and change where it is computed in step. 
+[Etape 7]
+
+RUN SETTE and deliver version for mid-merge party ! Some silly allocating memory bugs found and a not that silly bug in the implicit mode for SPITZ12 configuration. 
+[Etape 8, 9 & 11]
+
+
+'''KERNEL-06's version 2 implementation : /NEMO/branches/2020/dev_r13328_KERNEL-06_techene_e3_version2''' 
+
+
 
 ''...''
@@ -62 +90 @@
 }}}
 
+
+
+
+Eventually, all the dom_vvl_interpol call are removed, each time e3 is called we use a substitute to replace e3 by e3_0 (1 + ssh / h_0). For backward compatibility a cpp key manages the use of the new version vs. the old version. We will duplicate modules such as step and domvvl into stepLF and domQE (QE stands for Quasi Eulerian) and create a subtitute module. 
+
+Integrated in mid merge trunk. 
+
+List the Fortran modules and subroutines to be created.
+substitute.F90
+
 Step 1 : Check the error for e3t, e3w between the current way to compute e3 at T-, W-point and the proposed way to compute e3 at T-, W-point.
 - prints added with no change in the results
@@ -73 +111 @@
 - use a SUBSTITUTE when there are e3 CALL
 - make some changes in step and domQE to have the whole thing consistent
-jpjm1
+
 ''...''