= Name and subject of the action Last edition: '''[[Wikinfo(changed_ts)]]''' by '''[[Wikinfo(changed_by)]]''' The PI is responsible to closely follow the progress of the action, and especially to contact NEMO project manager if the delay on preview (or review) are longer than the 2 weeks expected. [[PageOutline(2, , inline)]] == Summary ||=Action || AGRIF for TOP || ||=PI(S) || Ethe || ||=Digest || AGRIF for TOP || ||=Dependencies || If any || ||=Branch || source:/NEMO/branches/2020/dev_r13333_TOP-05_Ethe_Agrif || ||=Previewer(s) || Aumont || ||=Reviewer(s) || Aumont, Chanut || ||=Ticket || #2508 || === Description Make sure that TOP is working with AGRIF... ''...'' === Implementation improve the AGRIF_DEMO reference configuration by adding TOP component + PISCES ''...'' === Documentation updates {{{#!box width=55em help Using previous parts, define the main changes to be done in the NEMO literature (manuals, guide, web pages, …). }}} ''...'' == Preview The methodology is just to correct appropriate routines to make NEMO-TOP compiles and runs successfully when using ARIF All the modfied routines are listed here : https://forge.ipsl.jussieu.fr/nemo/changeset?sfp_email=&sfph_mail=&reponame=&new=13373%40NEMO%2Fbranches%2F2020%2Fdev_r13333_TOP-05_Ethe_Agrif%2Fsrc&old=13372%40NEMO%2Fbranches%2F2020%2Fdev_r13333_TOP-05_Ethe_Agrif%2Fsrc Most of them have minor changes. The real bottleneck came from to the fact that AGRIF doesn't like structure as an argument of a subroutine and so the compilation fails unless we add, as it is done now, a directive $AGRIF_DO_NOT_TREAT in trcdta.F90. But doing that implies we can't use this routine to initialize the tracers using on-the-fly interpolation. As suggested Tomas Lovato an alternative is to pass as an argument only the jl index to select data from the structure within trcdta. It works but not very optimal since with the "CALL fld_read( kt, 1, sf_trcdta )" we always read the whole structure ( all the initialized tracers ) even if we need only to get the tracer with jl index. Also change in trcdmp.F90 The dev branch has been successfully phased with trunk at revision r13787 == Tests The run done is described in ticket https://forge.ipsl.jussieu.fr/nemo/ticket/2508 Sette tests have been successfully run. Find here the report : {{{ Current code is : NEMO/branches/2020/dev_r13333_TOP-05_Ethe_Agrif @ r13920 ( last change @ r13798 ) SETTE validation report generated for : NEMO/branches/2020/dev_r13333_TOP-05_Ethe_Agrif @ r13798 (last changed revision) on X64_JEANZAY arch file !!---------------1st pass------------------!! !----restart----! WGYRE_PISCES_ST run.stat restartability passed : 13798 WGYRE_PISCES_ST tracer.stat restartability passed : 13798 WORCA2_ICE_PISCES_ST run.stat restartability passed : 13798 WORCA2_ICE_PISCES_ST tracer.stat restartability passed : 13798 WORCA2_OFF_PISCES_ST tracer.stat restartability passed : 13798 WAMM12_ST run.stat restartability passed : 13798 WORCA2_SAS_ICE_ST run.stat restartability passed : 13798 WAGRIF_DEMO_ST run.stat restartability passed : 13798 WWED025_ST run.stat restartability passed : 13798 WISOMIP+_ST run.stat restartability passed : 13798 WOVERFLOW_ST run.stat restartability passed : 13798 WLOCK_EXCHANGE_ST run.stat restartability passed : 13798 WVORTEX_ST run.stat restartability passed : 13798 WICE_AGRIF_ST run.stat restartability passed : 13798 !----repro----! WGYRE_PISCES_ST run.stat reproducibility passed : 13798 WGYRE_PISCES_ST tracer.stat reproducibility passed : 13798 WORCA2_ICE_PISCES_ST run.stat reproducibility passed : 13798 WORCA2_ICE_PISCES_ST tracer.stat reproducibility passed : 13798 WORCA2_OFF_PISCES_ST tracer.stat reproducibility passed : 13798 WAMM12_ST run.stat reproducibility passed : 13798 WORCA2_SAS_ICE_ST run.stat reproducibility passed : 13798 WORCA2_ICE_OBS_ST run.stat reproducibility passed : 13798 WAGRIF_DEMO_ST run.stat reproducibility passed : 13798 WWED025_ST run.stat reproducibility passed : 13798 WISOMIP+_ST run.stat reproducibility passed : 13798 WVORTEX_ST run.stat reproducibility passed : 13798 WICE_AGRIF_ST run.stat reproducibility passed : 13798 !----agrif check----! ORCA2 AGRIF vs ORCA2 NOAGRIF run.stat unchanged - passed : 13798 13798 !----result comparison check----! check result differences between : VALID directory : /gpfsscratch/rech/gzi/rgzi002/NEMO_MERGE_2020/dev_r13333_TOP-05_Ethe_Agrif/NEMO_VALIDATION at rev 13798 and REFERENCE directory : /gpfsscratch/rech/omr/romr014/Sette_Trunk/NEMO_VALIDATION at rev 13747 WGYRE_PISCES_ST run.stat files are identical WGYRE_PISCES_ST tracer.stat files are identical WORCA2_ICE_PISCES_ST run.stat files are identical WORCA2_ICE_PISCES_ST tracer.stat files are identical WORCA2_OFF_PISCES_ST tracer.stat files are identical WAMM12_ST run.stat files are identical WORCA2_SAS_ICE_ST run.stat files are identical WAGRIF_DEMO_ST run.stat files are identical WWED025_ST run.stat files are identical WISOMIP+_ST run.stat files are identical WVORTEX_ST run.stat files are identical WICE_AGRIF_ST run.stat files are identical WOVERFLOW_ST run.stat files are identical WLOCK_EXCHANGE_ST run.stat files are identical }}} ''...'' == Review I reviewed the code. The different aspects and processes have been properly coded according to my review. The choices make sense and one test has been proposed. I don't have any additional comments or changes to suggest. This branch is ready to be merged in the trunk.