| Version 8 (modified by aumont, 3 years ago) (diff) |
|---|
Name and subject of the action
Last edition: Wikinfo(changed_ts)? by Wikinfo(changed_by)?
The PI is responsible to closely follow the progress of the action, and especially to contact NEMO project manager if the delay on preview (or review) are longer than the 2 weeks expected.
Summary
| Action | AGRIF for TOP |
|---|---|
| PI(S) | Ethe |
| Digest | AGRIF for TOP |
| Dependencies | If any |
| Branch | source:/NEMO/branches/2020/dev_r13333_TOP-05_Ethe_Agrif |
| Previewer(s) | Aumont |
| Reviewer(s) | Aumont, Chanut |
| Ticket | #2508 |
Description
Make sure that TOP is working with AGRIF...
...
Implementation
improve the AGRIF_DEMO reference configuration by adding TOP component + PISCES
...
Documentation updates
...
Preview
The methodology is just to correct appropriate routines to make NEMO-TOP compiles and runs successfully when using ARIF
All the modfied routines are listed here : https://forge.ipsl.jussieu.fr/nemo/changeset?sfp_email=&sfph_mail=&reponame=&new=13373%40NEMO%2Fbranches%2F2020%2Fdev_r13333_TOP-05_Ethe_Agrif%2Fsrc&old=13372%40NEMO%2Fbranches%2F2020%2Fdev_r13333_TOP-05_Ethe_Agrif%2Fsrc
Most of them have minor changes.
The real bottleneck came from to the fact that AGRIF doesn't like structure as an argument of a subroutine and so the compilation fails unless we add, as it is done now, a directive $AGRIF_DO_NOT_TREAT in trcdta.F90. But doing that implies we can't use this routine to initialize the tracers using on-the-fly interpolation.
As suggested Tomas Lovato an alternative is to pass as an argument only the jl index to select data from the structure within trcdta. It works but not very optimal since with the "CALL fld_read( kt, 1, sf_trcdta )" we always read the whole structure ( all the initialized tracers ) even if we need only to get the tracer with jl index. Also change in trcdmp.F90
The dev branch has been successfully phased with trunk at revision r13787
Tests
The run done is described in ticket https://forge.ipsl.jussieu.fr/nemo/ticket/2508
...
Review
I reviewed the code. The different aspects and processes have been properly coded according to my review. The choices make sense and one test has been proposed. I don't have any additional comments or changes to suggest. This branch is ready to be merged in the trunk.
