Changes between Version 6 and Version 7 of Developers/DevProcess
- Timestamp:
- 2016-02-02T07:11:34+01:00 (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Developers/DevProcess
v6 v7 6 6 || '''Name and number of action as listed in workplan:''' || ''To be completed here'' || 7 7 || '''PI of the development:''' || ''To be completed here'' || 8 || '''Number and link to ticket opened for this development:''' || ''To be completed here'' ||8 || '''Number and link to !ticket opened for this development:''' || ''To be completed here'' || 9 9 || '''Previewer(s) name(s):''' || ''To be completed here'' || 10 10 || '''Reviewer(s) name(s):''' || ''To be completed here'' || … … 44 44 ---- 45 45 == Section 3: Review to be completed by the reviewer(s) == 46 Once the development is done, the PI should ask the reviewers to start their review, and add the date in the table above. A sucessful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November)/46 Once the development is done, the PI should complete the test section below and ask the reviewers to start their review, and add the date in the table above. A sucessful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November)/ 47 47 48 === Ticket Details, Documentation and Code changes===48 === Code changes and documentation === 49 49 || Question || Discussion || Answer || 50 50 || Is the proposed methodology now implemented? || || || … … 53 53 || Is the in-line documentation accurate and sufficient? || || YES/NO || 54 54 || Do the code changes comply with NEMO coding standards? || || YES/NO || 55 || Is the Ticket documented with sufficient detailfor others to understand the impact of the change? || || YES/NO ||55 || Is the !ticket of development documented with sufficient details for others to understand the impact of the change? || || YES/NO || 56 56 || Are the reference manual tex files now updated following the proposed summary in preview section? || || YES/NO || 57 || IS there a need for some documentation on the web pages? || || YES/NO || 58 || Are namelist changes required for this change? || || YES/NO || 59 || If yes, have they been done? || || YES/NO || 60 || Has a completed Ticket Summary template been appended to the ticket to aid code reviews || || YES/NO || 61 || Does this summary correspond with your understanding of the full ticket? || || YES/NO || 62 63 Ticket, Documentation and Code comments 64 65 Add specific Ticket, Documentation and code comments here 57 || Is there a need for some documentation on the web pages (in addition to in-line and reference manual)?[[BR]]If yes, please describe and ask PI. A yes answer must include all documentation available. || || YES/NO || 66 58 67 59 === Testing === 68 || Has the NVTK and other jobs been tested with this change? || YES/NO || 69 || Have the required bit comparability tests been run? || YES/NO || 70 || Can this change be shown to have a null impact? (if option not selected) || YES/NO || 71 || If no, is reason for the change valid/understood? || YES/NO/NA || 72 || If no, ensure that the ticket details the impact this change will have on model configurations . || YES/NO/NA || 73 || Is this change expected to preserve all diagnostics? || YES/NO || 74 || If no, is reason for the change valid/understood? || YES/NO/NA || 75 || Are there significant changes in run time/memory? || YES/NO || 60 || Question || Discussion || Answer || 61 || Has the NVTK and other jobs been tested with this change? || || YES/NO || 62 || Have the required bit comparability tests been run? || || YES/NO || 63 || Can this change be shown to have a null impact? (if option not selected) || || YES/NO || 64 || If no, is reason for the change valid/understood? || || YES/NO/NA || 65 || If no, ensure that the ticket details the impact this change will have on model configurations . || || YES/NO/NA || 66 || Is this change expected to preserve all diagnostics? || || YES/NO || 67 || If no, is reason for the change valid/understood? || || YES/NO/NA || 68 || Are there significant changes in run time/memory? || || YES/NO || 76 69 77 70 Testing Comments
