Version 76 (modified by nicolasmartin, 4 years ago) (diff)

Form page for development work

Help

A wiki page associated with a given action should be created in wiki/${YEAR}WP/${WORKING_GROUP|INSTITUTE}-${ACTION_NUMBER}_${PI} using this template. Each editor (PI/Previewer/Reviewer) complete its section inside the form fields and save its modifications by clicking on the 'Save' button at the end of the section (last modification record will be updated just above it).

This is the color code for the fulfilment of this form:

PI(S)

Previewer(s)

Reviewer(s)

There is absolutely no risk for all form content to make any modification in the wiki page as long as you edit out of {{{TracForm ... }}} processor. The data of a form field is stored in a different database from the wiki page, so you can delete a version or submit a new one without danger.

For the Trac links to associated !ticket & development branch, it is mandatory to edit the page in textarea view. The wysiwyg view will alter the interpretation of the Trac processors {{{#!th ... }}} or {{{#!td ... }}} in the table.
To keep a preview, you can tick the box edit side-by-side at top right of the editing frame). It will part your screen with the editing view on the left and the automatic preview on the right so you can control your changes. If you get by default the 'wysiwyg' view, this is due to your last editing work and can be changed in a simple manner.


The PI is responsible to closely follow the progress of the action, and especially to contact NEMO project manager if the delay on preview (or review) are longer than the 2 weeks expected.

Abstract

This section should be completed before starting to develop the code, in order to find agreement on the method beforehand.

Details

Action

PI(S)

Ticket

#XXXX

Branch

branches/$YEAR/dev_r${FORK_REVISION}_${WORKING_GROUP|INSTITUTE}${ACTION_NUMBER}_${PURPOSE}

Previewer(s)

Reviewer(s)

To enabling the !ticket and the source links related to your action, edit the form like a ordinary wiki page to hardcode them inside the table

Description

Implementation

Reference manual and web pages updates

Updated on 09/25/2020 17:57:29 by anonymous

Once the PI has completed this section, he should send a mail to the previewer(s) asking them to preview the work within two weeks.

Preview

Since the preview step must be completed before the PI starts the coding, the previewer(s) answers are expected to be completed within the two weeks after the PI has sent his request.
For each question, an iterative process should take place between PI and previewer(s) in order to reach a "YES" answer for each of the following questions.

Questions Answer Comment
Does the previewer agree with the proposed methodology?
Does the previewer agree with the proposed flowchart and list of routines to be changed?
Does the previewer agree with the proposed new list of variables, including agreement with coding rules?
Does the previewer agree with the proposed summary of updates in reference manual?
… … …

Updated on 09/25/2020 17:57:29 by anonymous

Once all "YES" have been reached, the PI can start the development into his development branch.

Tests

Once the development is done, the PI should complete this section below and ask the reviewers to start their review in the lower section.

Questions Answer Comment
Can this change be shown to produce expected impact? (if option activated)?
Can this change be shown to have a null impact? (if option not activated)
Detailed results of restartability and reproducibility when the option is activated. Please indicate the configuration used for this test
Detailed results of SETTE tests (restartability and reproducibility for each of the reference configuration)
Results of the required bit comparability tests been run: Are there no differences when activating the development?
If some differences appear, is reason for the change valid/understood?
If some differences appear, is the !ticket describing in detail the impact this change will have on model configurations?
Is this change expected to preserve all diagnostics?
If no, is reason for the change valid/understood?
Are there significant changes in run time/memory?
… … …

Updated on 09/25/2020 17:57:29 by anonymous

Review

A successful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November).

Code changes and documentation

Question Answer Comment
Is the proposed methodology now implemented?
Are the code changes in agreement with the flowchart defined at Preview step?
Are the code changes in agreement with list of routines and variables as proposed at Preview step?
If not, are the discrepancies acceptable?
Is the in-line documentation accurate and sufficient?
Do the code changes comply with NEMO coding standards?
Is the !ticket of development documented with sufficient details for others to understand the impact of the change?
Are the reference manual tex files now updated following the proposed summary in preview section?
Is there a need for some documentation on the web pages (in addition to in-line and reference manual)?
If yes, please describe and ask PI. A yes answer must include all documentation available.
… … …

Review Summary
Is the review fully successful?

Updated on 09/25/2020 17:57:29 by anonymous

Once review is successful, the development must be scheduled for merge during next Merge Party Meeting.