Changes between Version 10 and Version 11 of Developers/DevelopingCodeChanges
- Timestamp:
- 2012-06-27T16:50:10+02:00 (12 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Developers/DevelopingCodeChanges
v10 v11 56 56 * The convention for naming wiki pages associated with tickets is to replace "ticket/xxxx" with "wiki/ticket/xxxx" for ticket number "xxx". 57 57 * The wiki page can be created by including the markup !wiki:ticket/xxxx (where xxxx is your ticket number) in your ticket and then following the link. 58 * A sample wiki template ( NEMOTicketTemplate) is provided when creating the wikipage58 * A sample wiki template (!https://forge.ipsl.jussieu.fr/nemo/wiki/PageTemplates/NEMOTicketTemplate) is provided when creating the wikipage 59 59 60 60 == Science/Tech/Code Review == … … 69 69 * The code changes are understood and appropriately made. 70 70 * The documentation is sufficient to understand the code change and its impacts. 71 * Complete a wiki review template ( NEMOTicketTemplate) and append it to the ticket.71 * Complete a wiki review template (!https://forge.ipsl.jussieu.fr/nemo/wiki/PageTemplates/NEMOTicketTemplate) and append it to the ticket. 72 72 * Use the wiki filename convention !wiki:ticket/xxxx/Review where xxxx is the ticket number.It is likely that the review process will involve iterations between code author and reviewer until documentation and change are agreed to be of sufficient quality. The reviewer has the option to "reject & assign" back to the code author should the documentation/code not meet the required standards and major alterations/improvements are required. 73 73 74 74 Once the reviewer is satisfied, he/she should complete the approval section of the review template. 75 75 76 77 76 == Video tutorial == 78 77 see the Working Practices, [https://www.locean-ipsl.upmc.fr/~rblod/NW2N.avi the movie]