New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
ticket/0681/Review (diff) – NEMO

Changes between Version 2 and Version 3 of ticket/0681/Review


Ignore:
Timestamp:
2010-10-05T09:36:28+02:00 (13 years ago)
Author:
rblod
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • ticket/0681/Review

    v2 v3  
    3636 * same remark as above for some declarations on several lines with &[[BR]] 
    3737 * module mpp_map could be include in OPA_SRC/lib_mpp.F90 since it's not specific to OBS[[BR]] 
    38  * sentence module used, routine accessibility, arguments local declaration are obsolete (see attached routine as example) 
     38 * sentence "module used", "routine accessibility", "arguments local declaration" are obsolete (see attached routine as example)[[BR]] 
     39 * majority of variables follows the DOCTOR norme, some does not see (http://www.nemo-ocean.eu/Media/Files/coding_rules_OPA9), especially fortran structures which should be svar for module variables and sfvar fro dummy arguments 
    3940 
    4041'''2.2 Code itself ''' 
     
    4243 * calendar functionalities : routines julian.F90 and related include files 
    4344 
    44 IOIPSL library provides similar calendar functionalities in calendar module, we are using it in the rest of the code: 
     45IOIPSL library provides similar calendar functionalities in calendar module (I'm not sure for the optional kdate argument), we are using it in the rest of the code: 
    4546 
    46 USE IOIPSL[[BR]]  CALL  ymds2ju (year,month,day,sec,julian)[[BR]] CALL  ju2ymds (julian,year,month,day,sec)[[BR]] 
     47USE IOIPSL[[BR]]   
     48CALL  ymds2ju (year,month,day,sec,julian)[[BR]]  
     49CALL  ju2ymds (julian,year,month,day,sec)[[BR]] 
    4750 
    4851 * It may be logical to define kind of data fbsp and fbdp in par_kind.F90 rather than in obs_fbm[[BR]] 
    49  * Using nf90_open rather than iom_open may be a sources a problem when using nesting (maybe one day) with key agrif 
     52 * Using nf90_open rather than iom_open may be a sources a problem when using nesting (maybe one day) with key agrif (I should talk with Arthur and Eric)[[BR]] 
     53 * some routine in obs_mpp.F90 seems duplicated in lib_mpp.F90 (obs_mpp_max_integer,obs_mpp_sum_integers in OBS and mpp_max, mpp_sum in lib_mpp) and anyway those which are not specific to obs should be included in lib_mpp.F90[[BR]] 
     54 * module mpp_map could be include in OPA_SRC/lib_mpp.F90 since it's not specific to OBS[[BR]] 
    5055 
    5156'''3. MISC ''' 
    5257 
    53 It would be nice to have access to an observation file or at least a link to one in the routine 
     58It would be nice to have access to an observation file (enact) or at least a reference to a link to one in the routine 
    5459 
    5560'''Ticket Details, Documentation and Code changes'''