Changes between Initial Version and Version 1 of ticket/0844/Review

Timestamp:

2011-11-04T09:13:05+01:00 (12 years ago)

Author:

deazer

Comment:

--

ticket/0844/Review

@@ +1 @@
+Last edited [[Timestamp]]
+
+[[PageOutline]]
+
+== For completion by the Sci/Tech/Code reviewer ==
+'''Reviewer:''' [ Enda O'Dea ]
+
+=== Ticket Details, Documentation and Code changes ===
+||Do you understand the area of code being altered and the reasoning why it is being altered?||YES||
+||Do the proposed code changes correspond with the stated reason for the change?||YES||
+||Is the in-line documentation accurate and sufficient?||YES||
+||Do the code changes comply with NEMO coding standards?||YES||
+||Is the Ticket documented with sufficient detail for others to understand the impact of the change?||YES/NO||
+||Does any corresponding external documentation require updating?||YES/NO||
+||If yes, which docs and have the updates been drafted?||YES/NO||
+||Are namelist changes required for this change?||YES||
+||If yes, have they been done?||YES||
+||Has a completed Ticket Summary template been appended to the ticket to aid code reviews||YES||
+||Does this summary correspond with your understanding of the full ticket?||YES||
+
+Ticket, Documentation and Code comments
+
+Add specific Ticket, Documentation and code comments here
+
+=== Testing ===
+||Has the NVTK and other jobs been tested with this change?||YES||
+||Have the required bit comparability tests been run?||YES||
+||Can this change be shown to have a null impact? (if option not selected)||YES||
+||If no, is reason for the change valid/understood?||NA||
+||If no, ensure that the ticket details the impact this change will have on model configurations .||NA||
+||Is this change expected to preserve all diagnostics?||NO||
+||If no, is reason for the change valid/understood?||YES||
+||Are there significant changes in run time/memory?||NO||
+
+Testing Comments
+
+Add specific testing comments here
+
+Add specific testing comments here
+
+=== Code Review ===
+||Do the code changes comply with NEMO coding standards?||YES||
+||Are code changes consistent with the design of NEMO?||YES||
+||Is the code free of unwanted TABs?||YES||
+||Has the code been wholly (100%) produced by NEMO developers working on NEMO?||YES||
+||If no, ensure collaboration agreement has been added to the ticket keywords||||
+
+Add specific code comments or suggested alterations here.
+
+=== Review Summary ===
+Add summary here
+
+The coded has been tested for a simple case of analyzing the M2 tidal consituent in the AMM
+the resultant analysis gives a sensible result for M2, Had some difficutly with outputs of the
+analyzed variable.
+
+=== Approval for the trunk ===
+YES subject to documentation of change and inclusion of module dynspg_ts for Ubar,Vbar
+
+The code reviewer may approve the change for the NEMO trunk when:
+
+ 1. their requests/comments have been addressed satisfactorily.
+ 1. the above check-list has been completed.
+
+or the code reviewer may choose to reject & assign the change back to the code author.