Changes between Version 15 and Version 16 of ticket/0846

Timestamp:

2011-10-23T16:37:56+02:00 (12 years ago)

Author:

momme

Comment:

--

ticket/0846

@@ -372 +372 @@
 ========= Marcello's comments  ========= Christian's comment is remarking the importance of FCM as "the tool" to incorporate other models into the system with little modification of the source code. I definitely agree with this point. The way we handle the coupling with the BFM now is to have a directory called nemo within the BFM tree that contains all needed routines. In our case, This directory is exactly what should go into MY_SRC. Extending on this method, the solution would be to totally substitute the main calling routines (trcstp and trctrp) with modified copies that will be maintained by each group in the tree of the biological model. In that case, I think we should be able to fit into the MY_TRC layout easily. As far as I can understand, FCM should consider the content opf MY_SRC directory in place of the files with the same names in the WORK directory. My only concern is whether FCM can eventually put the content of an external directory into MY_SRC, without the need to do it manually.
 
-========= Momme's comments on FCM use and my_trc interface  =========
-'''How to compile external "trc" code with NEMO using FCM, modifying only the fcm file of the local configuration.''' (Leaving the repository code untouched.)
+========= Momme's comments on FCM use and my_trc interface  ========= '''How to compile external "trc" code with NEMO using FCM, modifying only the fcm file of the local configuration.''' (Leaving the repository code untouched.)
 
 Example of fcm configuration file:
@@ -406 +405 @@
 All this is based on the NEMO src of the last tag (3.3), I haven't checked back against the trunk.
 
-{{{
-lk_qsr_bio -> TRUE requires key_pisces, should be switchable in relation to user requirements for my_tracer:
+trc_oce.F90:
+
+''     lk_qsr_bio -> TRUE requires key_pisces, should be switchable in relation to user requirements for my_tracer:''
+
+{{{
 !=============================================== 
 ! Modification to NEMO trunk for ERSEM coupling 
@@ -418 +420 @@
 !=============================================== 
 }}}
-mapping of ERSEM states to trn:
-
-{{{
-!=============================================== ! Modification to NEMO trunk for ERSEM coupling ! M.Butenschoen, PML - March 2009 ! \/ ! \/ #if defined key_PMLersem
-
+trcstp.F90:
+
+''     mapping of ERSEM states to trn:''
+
+{{{
+!=============================================== 
+! Modification to NEMO trunk for ERSEM coupling 
+! M.Butenschoen, PML - March 2009 
+! \/ 
+! \/ 
+#if defined key_PMLersem
   CALL trc_trp_PMLersem( kt )
-
-#else ! /\ ! /\ !===============================================
-
+#else 
+! /\ 
+! /\ 
+!===============================================
   CALL trc_trp( kt )           ! transport of passive tracers
-
-!=============================================== ! Modification to NEMO trunk for ERSEM coupling ! M.Butenschoen, PML - March 2009 ! \/ ! \/ #endif ! /\ ! /\ !=============================================== }}} avoid NEMO output of trc: {{{!=============================================== ! Modification to NEMO trunk for ERSEM coupling ! M.Butenschoen, PML - March 2009 ! \/ ! \/ #if defined key_PMLersem
-
+!=============================================== 
+! Modification to NEMO trunk for ERSEM coupling 
+! M.Butenschoen, PML - March 2009 
+! \/ 
+! \/ 
+#endif 
+! /\ 
+! /\ 
+!=============================================== 
+}}}
+''     avoid NEMO output of trc: ''
+
+{{{
+!=============================================== 
+! Modification to NEMO trunk for ERSEM coupling 
+! M.Butenschoen, PML - March 2009 
+! \/ 
+! \/ 
+#if defined key_PMLersem
   CALL trc_dia_PMLErsem( kt )
-
 #else
-
-  IF( lk_iomput ) THEN  ;   CALL trc_wri( kt )           ! output of passive tracers ELSE                  ;   CALL trc_dia( kt ) ENDIF
-
-!=============================================== ! Modification to NEMO trunk for ERSEM coupling ! M.Butenschoen, PML - March 2009
-
-  \/
-
-! \/ #endif
-}}}
-
+! /\
+! /\
+!===============================================
+  IF( lk_iomput ) THEN  ;   CALL trc_wri( kt )           ! output of passive tracers
+  ELSE                  ;   CALL trc_dia( kt ) 
+  ENDIF
+!=============================================== 
+! Modification to NEMO trunk for ERSEM coupling 
+! M.Butenschoen, PML - March 2009
+! \/
+! \/ 
+#endif
+! /\
+! /\
+!===============================================
+}}}
 === Status ===
 Outcomes of the videoconference held on September 17th. Participants: Marcello Vichi, Christian Ethe', Karen Edwards, Momme Butenschoen. Christian's proposal of using FCM is seen as the way forward to minimize the impacts on the current NEMO code and allow all the developers of external ecosystem models to carry on their own development still maintaining the possibility to couple with NEMO in a seamless way. A powerpoint presentation is attached to this page, explaining the status and the possible solution.  The underlying idea is to explore the method used at MetOffice where different components are first extracted (using FCM extract.cfg configuration script) and then built. Currently, FCM is used within NEMO just to perform the build phase (build.cfg) as the extraction is not needed being the code part of the downloaded NEMO version. A possible strategy to explore is to include an additional flag for the makenemo script that should look for a user-provided build.cfg file with all the information on the external biogeochemical model. This model code will then be copied at the same level of the WORK directory. The proper versions of trcini.F90 and trcstp.F0 will instead be put in the MY_SRC directory. All files present in MY_SRC directory are compiled in place of the ones in the WORK directory. The current development branch will thus be used as a testing ground for the usage of FCM as interface to . It is not expected that this development will be part of the next release, but we believe this strategy will facilitate any future inclusion of other external models.