New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
ticket/0848/Review (diff) – NEMO

Changes between Version 1 and Version 2 of ticket/0848/Review


Ignore:
Timestamp:
2011-10-03T12:17:22+02:00 (13 years ago)
Author:
sga
Comment:

Review ticket created - not yet completed

Legend:

Unmodified
Added
Removed
Modified

  • ticket/0848/Review

    v1 v2  
    77 
    88=== Ticket Details, Documentation and Code changes === 
    9 ||Do you understand the area of code being altered and the reasoning why it is being altered?||YES/NO|| 
    10 ||Do the proposed code changes correspond with the stated reason for the change?||YES/NO|| 
    11 ||Is the in-line documentation accurate and sufficient?||YES/NO|| 
    12 ||Do the code changes comply with NEMO coding standards?||YES/NO|| 
     9||Do you understand the area of code being altered and the reasoning why it is being altered?||In part|| 
     10||Do the proposed code changes correspond with the stated reason for the change?||Yes|| 
     11||Is the in-line documentation accurate and sufficient?||It is consistent with existing code|| 
     12||Do the code changes comply with NEMO coding standards?||Almost|| 
    1313||Is the Ticket documented with sufficient detail for others to understand the impact of the change?||YES/NO|| 
    1414||Does any corresponding external documentation require updating?||YES/NO|| 
    … …  
    4040 
    4141=== Code Review === 
    42 ||Do the code changes comply with NEMO coding standards?||YES/NO|| 
    43 ||Are code changes consistent with the design of NEMO?||YES/NO|| 
     42||Do the code changes comply with NEMO coding standards?||Almost|| 
     43||Are code changes consistent with the design of NEMO?||Yes|| 
    4444||Is the code free of unwanted TABs?||YES/NO|| 
    4545||Has the code been wholly (100%) produced by NEMO developers working on NEMO?||YES/NO||