Changes between Version 4 and Version 5 of ticket/0848/Review

Timestamp:

2011-10-03T15:10:42+02:00 (13 years ago)

Author:

sga

Comment:

--

ticket/0848/Review

@@ -11 +11 @@
 ||Is the in-line documentation accurate and sufficient?||It is consistent with existing code||
 ||Do the code changes comply with NEMO coding standards?||Almost||
-||Is the Ticket documented with sufficient detail for others to understand the impact of the change?||YES/NO||
-||Does any corresponding external documentation require updating?||YES/NO||
+||Is the Ticket documented with sufficient detail for others to understand the impact of the change?||NO||
+||Does any corresponding external documentation require updating?||YES||
 ||If yes, which docs and have the updates been drafted?||YES/NO||
 ||Are namelist changes required for this change?||YES/NO||
@@ -34 +34 @@
 
 Testing Comments
-  I, the reviewer have not yet managed to get this code to compile.
+  I, the reviewer, have not yet managed to get this code to compile.
   Problems encountered so far:
     the name of the C compiler (cc) is hard-coded into NEMOGCM/EXTERNAL/AGRIF/LIB/Makefile;
     one cpp command I'm using doesn't like a space between '-I' and the include directory name;
   Obscure build errors occur on two different systems I've tried so far, so I will persevere.
-  However, it seems a bit delicateand may therefore present support issues.
+  However, it seems a bit delicate and may therefore present support issues.
 
 Add specific testing comments here
@@ -90 +90 @@
   NEMOGCM/NEMO/NST_SRC/agrif2model.F90
   NEMOGCM/NEMO/NST_SRC/agrif_lim2_interp.F90
+    code in here seems rather obscure and requires more comment.
+    For example the treatments of u_ice_oe,v_ice_oe and u_ice_sn,v_ice_sn are both asymmetrical in agrif_dyn_lim.
+    They are also declared with a 4 by 2 pattern. Why?
+
   NEMOGCM/NEMO/NST_SRC/agrif_lim2_update.F90
   NEMOGCM/NEMO/NST_SRC/agrif_oce.F90