Changes between Version 4 and Version 5 of ticket/0848/Review


Ignore:
Timestamp:
2011-10-03T15:10:42+02:00 (9 years ago)
Author:
sga
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • ticket/0848/Review

    v4 v5  
    1111||Is the in-line documentation accurate and sufficient?||It is consistent with existing code|| 
    1212||Do the code changes comply with NEMO coding standards?||Almost|| 
    13 ||Is the Ticket documented with sufficient detail for others to understand the impact of the change?||YES/NO|| 
    14 ||Does any corresponding external documentation require updating?||YES/NO|| 
     13||Is the Ticket documented with sufficient detail for others to understand the impact of the change?||NO|| 
     14||Does any corresponding external documentation require updating?||YES|| 
    1515||If yes, which docs and have the updates been drafted?||YES/NO|| 
    1616||Are namelist changes required for this change?||YES/NO|| 
     
    3434 
    3535Testing Comments 
    36   I, the reviewer have not yet managed to get this code to compile. 
     36  I, the reviewer, have not yet managed to get this code to compile. 
    3737  Problems encountered so far: 
    3838    the name of the C compiler (cc) is hard-coded into NEMOGCM/EXTERNAL/AGRIF/LIB/Makefile; 
    3939    one cpp command I'm using doesn't like a space between '-I' and the include directory name; 
    4040  Obscure build errors occur on two different systems I've tried so far, so I will persevere. 
    41   However, it seems a bit delicateand may therefore present support issues. 
     41  However, it seems a bit delicate and may therefore present support issues. 
    4242 
    4343Add specific testing comments here 
     
    9090  NEMOGCM/NEMO/NST_SRC/agrif2model.F90 
    9191  NEMOGCM/NEMO/NST_SRC/agrif_lim2_interp.F90 
     92    code in here seems rather obscure and requires more comment. 
     93    For example the treatments of u_ice_oe,v_ice_oe and u_ice_sn,v_ice_sn are both asymmetrical in agrif_dyn_lim. 
     94    They are also declared with a 4 by 2 pattern. Why? 
     95 
    9296  NEMOGCM/NEMO/NST_SRC/agrif_lim2_update.F90 
    9397  NEMOGCM/NEMO/NST_SRC/agrif_oce.F90