Changes between Version 8 and Version 9 of ticket/0848/Review


Ignore:
Timestamp:
2011-10-05T13:22:23+02:00 (9 years ago)
Author:
sga
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • ticket/0848/Review

    v8 v9  
    1313||Is the Ticket documented with sufficient detail for others to understand the impact of the change?||NO|| 
    1414||Does any corresponding external documentation require updating?||YES|| 
    15 ||If yes, which docs and have the updates been drafted?||YES/NO|| 
    16 ||Are namelist changes required for this change?||YES/NO|| 
    17 ||If yes, have they been done?||YES/NO|| 
    18 ||Has a completed Ticket Summary template been appended to the ticket to aid code reviews||YES/NO|| 
     15||If yes, which docs and have the updates been drafted?||Unknown|| 
     16||Are namelist changes required for this change?||NO|| 
     17||If yes, have they been done?||NA|| 
     18||Has a completed Ticket Summary template been appended to the ticket to aid code reviews||I don't know what this is|| 
    1919||Does this summary correspond with your understanding of the full ticket?||YES/NO|| 
    2020 
     
    2424 
    2525=== Testing === 
    26 ||Has the NVTK and other jobs been tested with this change?||YES/NO|| 
    27 ||Have the required bit comparability tests been run?||YES/NO|| 
    28 ||Can this change be shown to have a null impact? (if option not selected)||YES/NO|| 
    29 ||If no, is reason for the change valid/understood?||YES/NO/NA|| 
    30 ||If no, ensure that the ticket details the impact this change will have on model configurations .||YES/NO/NA|| 
    31 ||Is this change expected to preserve all diagnostics?||YES/NO|| 
    32 ||If no, is reason for the change valid/understood?||YES/NO/NA|| 
    33 ||Are there significant changes in run time/memory?||YES/NO|| 
     26||Has the NVTK and other jobs been tested with this change?||Unknown|| 
     27||Have the required bit comparability tests been run?||Unknown|| 
     28||Can this change be shown to have a null impact? (if option not selected)||Unknown|| 
     29||If no, is reason for the change valid/understood?||NA|| 
     30||If no, ensure that the ticket details the impact this change will have on model configurations .||NA|| 
     31||Is this change expected to preserve all diagnostics?||NO|| 
     32||If no, is reason for the change valid/understood?||Yes, if related to ice regions|| 
     33||Are there significant changes in run time/memory?||Unknown|| 
    3434 
    3535Testing Comments 
     
    4747Add specific testing comments here 
    4848 
    49 Add specific testing comments here 
    50  
    5149=== Code Review === 
    5250||Do the code changes comply with NEMO coding standards?||Almost|| 
    5351||Are code changes consistent with the design of NEMO?||Yes|| 
    5452||Is the code free of unwanted TABs?||unchecked|| 
    55 ||Has the code been wholly (100%) produced by NEMO developers working on NEMO?||YES/NO|| 
     53||Has the code been wholly (100%) produced by NEMO developers working on NEMO?||Unknown|| 
    5654||If no, ensure collaboration agreement has been added to the ticket keywords|||| 
    5755 
     
    117115=== Review Summary === 
    118116I believe that this code has already been used by several groups with NEMO v3.2. 
    119 There is an argument therefore for acceptance in v3.3.1 with these groups retesting as appropriate, assuming that the extra agrif code  
     117There is an argument therefore for acceptance in v3.4 with these groups retesting as appropriate, assuming that the extra agrif code  
    120118here is substantially unchanged from the extra code they were using. 
    121119