Changes between Version 30 and Version 31 of ticket/0927_Energy_diag

Timestamp:

2012-03-20T16:58:53+01:00 (12 years ago)

Author:

fabien.roquet

Comment:

--

ticket/0927_Energy_diag

@@ -11 +11 @@
 '''     Motivation: '''    output 3D trends of tracers, momentum, kinetic energy and potential energy.[[BR]] '''     Status :''' the extraction of trends terms exists, but not the 3D output of the trends   [[BR]] '''     Main tasks :'''         [[BR]]
 
-  (1) implement the 3D output of tracers and momentum trends using iom_put [[BR]]    (2) compute and output the 3D trends of PE and KE [[BR]]         (3) validatation + documentation  [[BR]]
+  (1) implement the 3D output of tracers and momentum trends using iom_put [[BR]]     (2) compute and output the 3D trends of PE and KE [[BR]]          (3) validatation + documentation  [[BR]]
 
 '''     Science Reviewer:''' NOCS guy?     [[BR]]     '''     System Reviewer:'''  NOCS guy?     [[BR]]    '''     Deadline:'''   spring 2012   [[BR]] '''     Priority:'''      high    [[BR]] '''     Depends on:'''    gurvan disponibilities   [[BR]] '''     Principal Investigator : '''      Gurvan Madec and Simona Flavoni (simona.flavoni@locean-ipsl.upmc.fr)  [[BR]] [[BR]]
@@ -21 +21 @@
 see [https://forge.ipsl.jussieu.fr/nemo/log/branches/2012/dev_r3309_LOCEAN12_Ediag/NEMOGCM/NEMO/OPA_SRC?rev=3316 revision 3316]
 
-  '''    trdmod_oce'''     module and '''    namtrd namelist'''     [[BR]]
+  '''     trdmod_oce'''      module and '''     namtrd namelist'''      [[BR]]
 
 logical flags added in namlist namtrd which now controls what is done with the trends. [[BR]] All the types of treatment of a given trend are available at the same time. The memory requirement will only increase due to the time averaged arrays defined in IOM.
@@ -37 +37 @@
 Add these new logical in the namelist. '''==>>> CAUTION only in the ORCA2_LIM directory''' [[BR]] NB: here is the new name set in revision number 3318[[BR]]
 
-  '''    trdtra'''     module[[BR]]
+  '''     trdtra'''      module[[BR]]
 
 Add a systematic mask of the trend.[[BR]] Change the comments to better describe the purpose of this module. Its purpose is: [[BR]]
 
-  'TRA' case:  to regroup T & S trends and send them to trd_mod, with, in case of advection, transform the incoming advective fluxes into advctive trend (U.grad[T])[[BR]]    'TRC' case:  send trend to ted_mod_trc, with,  in case of advection,  transform the incoming advective fluxes into advective trend [[BR]]    all cases  : mask the trend    ('''    ===>>>   PROBABLY add in the module a lbc_lnk so that the trend is defined everywhere'''    )
-
-  '''    dynadv_cen2 and _ubs'''     modules[[BR]]
+  'TRA' case:  to regroup T & S trends and send them to trd_mod, with, in case of advection, transform the incoming advective fluxes into advctive trend (U.grad[T])[[BR]]     'TRC' case:  send trend to ted_mod_trc, with,  in case of advection,  transform the incoming advective fluxes into advective trend [[BR]]     all cases  : mask the trend    ('''     ===>>>   PROBABLY add in the module a lbc_lnk so that the trend is defined everywhere'''     )
+
+  '''     dynadv_cen2 and _ubs'''      modules[[BR]]
 
 change jpdyn_trd_had  into jpdyn_trd_keg. Now in flux form _keg corresponds to the horizontal advection trends and _rvo to the metric terms[[BR]] [[BR]]
 
-  '''    dynnxt'''     module[[BR]]
+  '''     dynnxt'''      module[[BR]]
 
 add the output using mom of the total den trend (except asselin time filter) ("utrd_tot", "vtrd_tot") and of the asselin time filter trend ("utrd_atf", "vtrd_atf") but with a shift by one time step[[BR]] [[BR]]
 
-  '''    dynvor, trdvor and trdmod_oce'''     modules[[BR]]
+  '''     dynvor, trdvor and trdmod_oce'''      modules[[BR]]
 
 suppress the call to trd_mod in the jpdyn_trd_dat case (computation of beta.V) add add the calculation of beta.V term in 'trdvor' in jpvor_pvo case. And obviously suppress jpdyn_trd_dat from trdmod_oce [[BR]] Also suppress the jpdyn_trd_had case  horizontal advection for the dynamics is 'keg' + 'vor'  ; in case of flux form,  'had' is put in 'keg' and the metric terms is put in 'vor' [[BR]] there is now only 10 trends on the dynamics instead of 12[[BR]] [[BR]]
 
-  '''    trdmod'''     module[[BR]]
+  '''     trdmod'''      module[[BR]]
 
 1- introduce the new logical namelist parameters[[BR]] 2- introduce new subroutines : '''trd_budget''' : computation of the domain averaged T,T^2^, PE, KE trends formerly computes in trd_mod routine)[[BR]] ''' trd_3Diom''': output of the 3D trends using IOM [[BR]] [[BR]]
 
-  '''    trdicp'''     module[[BR]]
+  '''     trdicp'''      module[[BR]]
 
 add in trd_twr routine the computation of the vertical diffusive trend on T & S in case of iso-neutral diffusion (ln_traldf_iso=T). These trends ("ttrd_zdfp", "strd_zdfp")  name zdfp for "PURE" vertical diffusion trends are output so that by difference with "zdf" trends we can access to the vertical contribution of the iso-neutral operator [[BR]] [[BR]]
 
-  '''    iodef.xml'''     file[[BR]]
+  '''     iodef.xml'''      file[[BR]]
 
 add all the trends nick name : '''==>>> CAUTION only in the ORCA2_LIM directory''' [[BR]] [[BR]]
@@ -69 +69 @@
 ----
 === ''' Step II : simplification of the structure ''' ===
-  '''    trdicp and trdicp_oce'''     modules[[BR]]
+  '''     trdicp and trdicp_oce'''      modules[[BR]]
 
 see [https://forge.ipsl.jussieu.fr/nemo/log/branches/2012/dev_r3309_LOCEAN12_Ediag/NEMOGCM/NEMO/OPA_SRC?rev=3317 revision 3317]
@@ -75 +75 @@
 1- suppress trdicp_oce module (put required variables in trdmod_oce parameters)[[BR]] 2- use the jptra_trd_...  instead of jpicp_...  3- move trd_budget subroutine from trdmod to trdicp.F90. Suppress trd_icp routine (i.e. trd_2d, trd_3d) as the work is now simply done in trd_budget.[[BR]] 4- rescan all dyn/tra trend indices. add jptra_trd_zdfp for "PURE Kz dissusive trend when ln_traldf_iso=T (see also changes in tranxt where a call to trd_tra is done just before the swap, so that PURE Kz trends can be diagnosed in tra_trd. See also xml file).  5- jptra_trd_nsr and jptra_trd_cdt are 3D trends as their incorporate both surface forcing AND runoff, the later being possibly spread in depth ('''==>>> probably to be changed''')[[BR]] 6- suppress the key_trddyn key trdtra  from trdicp[[BR]]
 
-  '''    trdtra - trddyn - trdmod - trdvor'''     modules : impact on '''    TRA'''    , '''    DYN'''    , '''    TRD'''     and almost all '''    TOP_SRC'''     modules[[BR]]
+  '''     trdtra - trddyn - trdmod - trdvor'''      modules : impact on '''     TRA'''     , '''     DYN'''     , '''     TRD'''      and almost all '''     TOP_SRC'''      modules[[BR]]
 
 see [https://forge.ipsl.jussieu.fr/nemo/log/branches/2012/dev_r3309_LOCEAN12_Ediag/NEMOGCM/NEMO/OPA_SRC?rev=3318 revision 3318]
@@ -89 +89 @@
 ----
 === ''' Step III : addition of 3D KE diagnostics ''' ===
-  '''    trdken'''     module[[BR]]
+  '''     trdken'''      module[[BR]]
 
 see [https://forge.ipsl.jussieu.fr/nemo/log/branches/2012/dev_r3309_LOCEAN12_Ediag/NEMOGCM/NEMO/OPA_SRC?rev=3325 revision 3325]
@@ -103 +103 @@
 ----
 === ''' Step IV : addition of 3D PE diagnostics ''' ===
-  '''    trdpen'''     module[[BR]]
+  '''     trdpen'''      module[[BR]]
 
 see [https://forge.ipsl.jussieu.fr/nemo/log/branches/2012/dev_r3309_LOCEAN12_Ediag/NEMOGCM/NEMO/OPA_SRC?rev=3326 revision 3326] and [https://forge.ipsl.jussieu.fr/nemo/log/branches/2012/dev_r3309_LOCEAN12_Ediag/NEMOGCM/NEMO/OPA_SRC?rev=3327 revision 3327] 0- correct a bug in trdtra and trdken
@@ -119 +119 @@
 [[BR]] [[BR]] [[BR]] [[BR]] [[BR]] [[BR]] [[BR]] [[BR]] [[BR]] '''Pending issues''' :
 
-  atmospheric pressure gradient trend not taken into account (see dynspg.F90  '''    To be done !!!!'''    [[BR]]   '''
-
-  kpp non-local trend put in zdf trends !!!  this will not work ! a additional trend term should be add '''    To be done !!!!'''    [[BR]]   '''
+  atmospheric pressure gradient trend not taken into account (see dynspg.F90  '''     To be done !!!!'''     [[BR]]    '''
+
+  kpp non-local trend put in zdf trends !!!  this will not work ! a additional trend term should be add '''     To be done !!!!'''     [[BR]]    '''
 
   problems to be solved: vvl case for tracer sad trends ; flux form case for had (keg) and zad momentum trends[[BR]]
@@ -142 +142 @@
 
  * Added wrk_alloc, wrk_dealloc and lbc_lnk in trd_dyn_iom.[[BR]]Remove unused variables ztswu, ztswv.
+ * Following norm in the code, utrd_bfr and vtrd_bfr should be filled only when ln_bfrimp=.FALSE. (non implicit bottom friction). 
+ * Implicit bottom friction is calculated at the end of each timestep, in dynzdf_imp.[[BR]]The diagnostic of bottom friction in the implicit case should be proposed in separate variable names to avoid confusion.
+
+In step.F90:
+
+ * Added "IF( .NOT.ln_bfrimp)" before the "CALL dyn_bfr( kstp )" to clarify that dyn_bfr is called only if bottom friction is explicit, as proposed by gm.
 
 In trdglo.F90:
 
- * In trd_glo_init, corrected definition for tvolt:[[BR]]         tvolt = tvolt + SUM( e1t(:,:) * e2t(:,:) * fse3t(:,:,jk) * tmask(:,:,jk) * tmask_i(:,:) )[[BR]]
+ * In trd_glo_init, corrected definition for tvolt:[[BR]]         tvolt = tvolt + SUM( e1e2t(:,:) * fse3t(:,:,jk) * tmask(:,:,jk) * tmask_i(:,:) )[[BR]]
 
 ----