Last edited [[Timestamp]] [[PageOutline]] == For completion by the Sci/Tech/Code reviewer == '''Reviewer:''' Clement Bricaud === Ticket Details, Documentation and Code changes === ||Do you understand the area of code being altered and the reasoning why it is being altered?||YES|| ||Do the proposed code changes correspond with the stated reason for the change?||YES|| ||Is the in-line documentation accurate and sufficient?||YES|| ||Do the code changes comply with NEMO coding standards?||YES|| ||Is the Ticket documented with sufficient detail for others to understand the impact of the change?||YES|| ||Does any corresponding external documentation require updating?||NO|| ||If yes, which docs and have the updates been drafted?||YES/NO|| ||Are namelist changes required for this change?||NO|| ||If yes, have they been done?||YES/NO|| ||Has a completed Ticket Summary template been appended to the ticket to aid code reviews||YES|| ||Does this summary correspond with your understanding of the full ticket?||YES|| Ticket, Documentation and Code comments Add specific Ticket, Documentation and code comments here === Testing === ||Has the NVTK and other jobs been tested with this change?||NO|| ||Have the required bit comparability tests been run?||NO|| ||Can this change be shown to have a null impact? (if option not selected)||YES|| ||If no, is reason for the change valid/understood?||YES/NO/NA|| ||If no, ensure that the ticket details the impact this change will have on model configurations .||YES/NO/NA|| ||Is this change expected to preserve all diagnostics?||YES|| ||If no, is reason for the change valid/understood?||YES/NO/NA|| ||Are there significant changes in run time/memory?||NO|| Testing Comments Results are the same for ORCA2 configuration as before. === Code Review === ||Do the code changes comply with NEMO coding standards?||YES|| ||Are code changes consistent with the design of NEMO?||YES|| ||Is the code free of unwanted TABs?||YES|| ||Has the code been wholly (100%) produced by NEMO developers working on NEMO?||YES|| ||If no, ensure collaboration agreement has been added to the ticket keywords|||| Add specific code comments or suggested alterations here. Units has been changed, salt transport are now in (10^9)*Kg/m2/s. ( (10^9)*g/m2/s before ). === Review Summary === Add summary here === Approval for the trunk === YES The code reviewer may approve the change for the NEMO trunk when: 1. their requests/comments have been addressed satisfactorily. 1. the above check-list has been completed. or the code reviewer may choose to reject & assign the change back to the code author.