Version 1 (modified by rfurner, 8 years ago) (diff)

Last edited Timestamp?


Author : Rachel Furner

ticket : #993

Branch : https://forge.ipsl.jussieu.fr/nemo/browser/branches/2012/dev_r3452_UKMO2_DIADCT


Description

Currently the code used to calculate flow through transects sums all positive and negative components over each time step. For a tidal model this does not allow useful diagnostics for the separate flow components, and so instead it is suggested that the flow is summed over the relevant number of time steps at each grid box, and then the positive and negative components are separately summed over space.


Testing

Testing could consider (where appropriate) other configurations in addition to NVTK].

NVTK Tested'''NO'''
Other model configurations'''NO'''
Processor configurations tested4x8
If adding new functionality please confirm that the
New code doesn't change results when it is switched off
and ''works'' when switched on
'''NA'''

(Answering UNSURE is likely to generate further questions from reviewers.)

'Please add further summary details here'

The code has been tested to ensure the total transport results are the same as previously. The code changes are limited to diadct, and so is key controlled. General aspects of the diadct code where tested when this module was first implemented and as such have been skipped for this work.

  • Processor configurations tested
  • etc——

Bit Comparability

Does this change preserve answers in your tested standard configurations (to the last bit) ?'''YES '''
Does this change bit compare across various processor configurations. (1xM, Nx1 and MxN are recommended)''''''
Is this change expected to preserve answers in all possible model configurations?''''''
Is this change expected to preserve all diagnostics?
,,''Preserving answers in model runs does not necessarily imply preserved diagnostics. ''
'''NO'''

If you answered '''NO''' to any of the above, please provide further details:

  • Which routine(s) are causing the difference?
  • Why the changes are not protected by a logical switch or new section-version
  • What is needed to achieve regression with the previous model release (e.g. a regression branch, hand-edits etc). If this is not possible, explain why not.
  • What do you expect to see occur in the test harness jobs?
  • Which diagnostics have you altered and why have they changed?Please add details here……..

Total flow rates given by diadct are the same, however positive and negative components are now dramatically different, so as to provide a more useful diagnostic for tidal models. The change is not namelist or key protected as it not thought likely that anyone requires the previous method to be used.


System Changes

Does your change alter namelists?'''NO '''
Does your change require a change in compiler options?'''NO '''

If any of these apply, please document the changes required here…….


Resources

''Please ''summarize'' any changes in runtime or memory use caused by this change……''


IPR issues

Has the code been wholly (100%) produced by NEMO developers staff working exclusively on NEMO?'''YES

If No:

  • Identify the collaboration agreement details
  • Ensure the code routine header is in accordance with the agreement, (Copyright/Redistribution? etc).Add further details here if required……….