| 15 | | === Ticket Details, Documentation and Code changes === |
| 16 | | || Do you understand the area of code being altered and the reasoning why it is being altered? || YES/NO || |
| 17 | | || Do the proposed code changes correspond with the stated reason for the change? || YES/NO || |
| 18 | | || Is the in-line documentation accurate and sufficient? || YES/NO || |
| 19 | | || Do the code changes comply with NEMO coding standards? || YES/NO || |
| 20 | | || Is the Ticket documented with sufficient detail for others to understand the impact of the change? || YES/NO || |
| 21 | | || Does any corresponding external documentation require updating? || YES/NO || |
| 22 | | || If yes, which docs and have the updates been drafted? || YES/NO || |
| 23 | | || Are namelist changes required for this change? || YES/NO || |
| 24 | | || If yes, have they been done? || YES/NO || |
| 25 | | || Has a completed Ticket Summary template been appended to the ticket to aid code reviews || YES/NO || |
| 26 | | || Does this summary correspond with your understanding of the full ticket? || YES/NO || |
| | 14 | • coarsening of BGC and sea-ice outputs ===> to be done |
| 28 | | Ticket, Documentation and Code comments |
| 29 | | |
| 30 | | Add specific Ticket, Documentation and code comments here |
| 31 | | |
| 32 | | === Testing === |
| 33 | | || Has the NVTK and other jobs been tested with this change? || YES/NO || |
| 34 | | || Have the required bit comparability tests been run? || YES/NO || |
| 35 | | || Can this change be shown to have a null impact? (if option not selected) || YES/NO || |
| 36 | | || If no, is reason for the change valid/understood? || YES/NO/NA || |
| 37 | | || If no, ensure that the ticket details the impact this change will have on model configurations . || YES/NO/NA || |
| 38 | | || Is this change expected to preserve all diagnostics? || YES/NO || |
| 39 | | || If no, is reason for the change valid/understood? || YES/NO/NA || |
| 40 | | || Are there significant changes in run time/memory? || YES/NO || |
| 41 | | |
| 42 | | Testing Comments |
| 43 | | |
| 44 | | Add specific testing comments here |
| 45 | | |
| 46 | | Add specific testing comments here |
| 47 | | |
| 48 | | === Code Review === |
| 49 | | || Do the code changes comply with NEMO coding standards? || YES/NO || |
| 50 | | || Are code changes consistent with the design of NEMO? || YES/NO || |
| 51 | | || Is the code free of unwanted TABs? || YES/NO || |
| 52 | | || Has the code been wholly (100%) produced by NEMO developers working on NEMO? || YES/NO || |
| 53 | | || If no, ensure collaboration agreement has been added to the ticket keywords || || |
| 54 | | |
| 55 | | Add specific code comments or suggested alterations here. |
| 56 | | |
| 57 | | === Review Summary === |
| 58 | | Add summary here |
| 59 | | |
| 60 | | === Approval for the trunk === |
| 61 | | YES/NO |
| 62 | | |
| 63 | | The code reviewer may approve the change for the NEMO trunk when: |
| 64 | | |
| 65 | | 1. their requests/comments have been addressed satisfactorily. |
| 66 | | 1. the above check-list has been completed. |
| 67 | | |
| 68 | | or the code reviewer may choose to reject & assign the change back to the code author. |
| | 16 | ---- |
