Changes between Version 1 and Version 2 of ticket/1085/Review
- Timestamp:
- 2013-10-29T17:56:52+01:00 (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
ticket/1085/Review
v1 v2 14 14 ||Does any corresponding external documentation require updating?||YES/NO|| 15 15 ||If yes, which docs and have the updates been drafted?||YES/NO|| 16 ||Are namelist changes required for this change?|| YES||17 ||If yes, have they been done?|| YES||18 ||Has a completed Ticket Summary template been appended to the ticket to aid code reviews|| YES/NO||16 ||Are namelist changes required for this change?||'''YES'''|| 17 ||If yes, have they been done?||'''YES'''|| 18 ||Has a completed Ticket Summary template been appended to the ticket to aid code reviews||'''YES'''|| 19 19 ||Does this summary correspond with your understanding of the full ticket?||YES/NO|| 20 20 … … 29 29 ||If no, is reason for the change valid/understood?||YES/NO/NA|| 30 30 ||If no, ensure that the ticket details the impact this change will have on model configurations .||YES/NO/NA|| 31 ||Is this change expected to preserve all diagnostics?|| YES||32 ||If no, is reason for the change valid/understood?|| NA||33 ||Are there significant changes in run time/memory?|| NO||31 ||Is this change expected to preserve all diagnostics?||'''YES'''|| 32 ||If no, is reason for the change valid/understood?||'''N/A'''|| 33 ||Are there significant changes in run time/memory?||'''NO'''|| 34 34 35 35 Testing Comments 36 36 37 Add specific testing comments here 38 39 Add specific testing comments here 37 * More testing information can be found in the changeset documentation at wiki:ticket/1085 40 38 41 39 === Code Review === … … 43 41 ||Are code changes consistent with the design of NEMO?||YES/NO|| 44 42 ||Is the code free of unwanted TABs?||YES/NO|| 45 ||Has the code been wholly (100%) produced by NEMO developers working on NEMO?||YES/NO|| 46 ||If no, ensure collaboration agreement has been added to the ticket keywords|||| 43 ||Has the code been wholly (100%) produced by NEMO developers working on NEMO?||'''YES'''|| 47 44 48 45 Add specific code comments or suggested alterations here.
