Changes between Version 3 and Version 4 of ticket/1306


Ignore:
Timestamp:
2014-07-16T13:04:32+02:00 (6 years ago)
Author:
timgraham
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • ticket/1306

    v3 v4  
    1414 
    1515The changes will consist of adding one new module and a single call to it in step.F90. The output is written to an ascii file. 
     16In order to implement it as an option without using a cpp key a new namelist parameter (nn_diacfl) has been added to the namctl namelist. 
    1617 
    1718---- 
    1819=== Testing === 
    19 The code will be SETTE tested. 
    20 A short (few time step simulation) will be run with timestep level output. The CFL calculations can then be checked offline using python code. 
     20The code will be SETTE tested. This required a small bug fix to be implemented as described in ticket #1363 so that ORCA2OFFPIS runs successfully. AGRIF test currently fails to run but does not work in the trunk before this change has been implemented (i.e. trunk revision 4650). 
    2121 
    22 || NVTK Tested || !'''YES/NO!''' || 
    23 || Other model configurations || !'''YES/NO!''' || 
    24 || Processor configurations tested || [ Enter processor configs tested here ] || 
    25 || If adding new functionality please confirm that the [[BR]]New code doesn't change results when it is switched off [[BR]]and !''works!'' when switched on || !'''YES/NO/NA!''' || 
     22A 5 time step run of ORCA2LIMPIS has been run with time step level output. The CFL diagnostics were then calculated in Python and agree with the output from the model run.  
     23 
     24ORCA025 has also been run with this code included. 
     25 
     26|| SETTE Tested || !'''YES''' || 
     27|| Other model configurations || !'''YES''' || 
     28|| Processor configurations tested || Standard SETTE configs and ORCA025 32x12 || 
     29|| If adding new functionality please confirm that the [[BR]]New code doesn't change results when it is switched off [[BR]]and !''works!'' when switched on || !'''YES''' || 
    2630 
    2731(Answering UNSURE is likely to generate further questions from reviewers.) 
    2832 
    29 'Please add further summary details here' 
    30  
    31  * Processor configurations tested 
    32  * etc---- 
    3333 
    3434=== Bit Comparability === 
    35 || Does this change preserve answers in your tested standard configurations (to the last bit) ? || !'''YES/NO !''' || 
    36 || Does this change bit compare across various processor configurations. (1xM, Nx1 and MxN are recommended) || !'''YES/NO!''' || 
     35|| Does this change preserve answers in your tested standard configurations (to the last bit) ? || !'''YES''' || 
     36|| Does this change bit compare across various processor configurations. (1xM, Nx1 and MxN are recommended) || !'''YES''' || 
    3737|| Is this change expected to preserve answers in all possible model configurations? || !'''YES''' || 
    3838|| Is this change expected to preserve all diagnostics? [[BR]]!,,!''Preserving answers in model runs does not necessarily imply preserved diagnostics. !'' || !'''YES''' || 
     
    4848---- 
    4949=== System Changes === 
    50 || Does your change alter namelists? || !'''YES/NO !''' || 
    51 || Does your change require a change in compiler options? || !'''YES/NO !''' || 
     50|| Does your change alter namelists? || !'''YES''' || 
     51|| Does your change require a change in compiler options? || !'''NO''' || 
    5252 
    53 If any of these apply, please document the changes required here....... 
     53A new namelist option (nn_diacfl) has been added to the namctl namelist. This is set to 0 if CFL diagnostic output is not required or 1 if it is.  
    5454 
    5555---- 
    5656=== Resources === 
    57 !''Please !''summarize!'' any changes in runtime or memory use caused by this change......!'' 
     57A very small increase in runtime in ORCA025 test (2 seconds extra to run 5 days) and total memory use increased from 173223 Mb to 175494 Mb (as extra 3D arrays are required). 
    5858 
    5959---- 
     
    6262 
    6363If No: 
    64  
    6564 * Identify the collaboration agreement details 
    6665 * Ensure the code routine header is in accordance with the agreement, (Copyright/Redistribution etc).Add further details here if required..........