Last edited Timestamp?

For completion by the Sci/Tech/Code? reviewer

Reviewer: [ A. Vidard ]

Ticket Details, Documentation and Code changes

Do you understand the area of code being altered and the reasoning why it is being altered? YES
Do the proposed code changes correspond with the stated reason for the change? YES
Is the in-line documentation accurate and sufficient? YES
Do the code changes comply with NEMO coding standards? NO
Is the Ticket documented with sufficient detail for others to understand the impact of the change? YES
Does any corresponding external documentation require updating? YES
If yes, which docs and have the updates been drafted? OBS/?
Are namelist changes required for this change? YES
If yes, have they been done? YES
Has a completed Ticket Summary template been appended to the ticket to aid code reviews YES
Does this summary correspond with your understanding of the full ticket? YES

Ticket, Documentation and Code comments

Add specific Ticket, Documentation and code comments here

Testing

see https://forge.ipsl.jussieu.fr/nemo/wiki/ticket/1328

Code Review

Do the code changes comply with NEMO coding standards? NO
Are code changes consistent with the design of NEMO? YES
Is the code free of unwanted TABs? YES
Has the code been wholly (100%) produced by NEMO developers working on NEMO? NO
If no, ensure collaboration agreement has been added to the ticket keywords

Add specific code comments or suggested alterations here.

Review Summary

There are some breaches to the NEMO coding norm, in the variable names. Actually they are quite common in the pre-existing OBS code.

It is a bit of a shame that OBS is not able to use NEMO's standard IO library and has to use netcdf statements. Maybe some internal discussions about updating the IO library for coping with OBS needs would be beneficial.

Approval for the trunk

YES

The code reviewer may approve the change for the NEMO trunk when:

  1. their requests/comments have been addressed satisfactorily.
  2. the above check-list has been completed.

or the code reviewer may choose to reject & assign the change back to the code author.

Last modified 6 years ago Last modified on 2014-10-13T12:41:52+02:00