Changes between Version 1 and Version 2 of ticket/1328/review

Timestamp:

2014-10-13T12:41:52+02:00 (10 years ago)

Author:

avidard

Comment:

--

ticket/1328/review

@@ -4 +4 @@
 
 == For completion by the Sci/Tech/Code reviewer ==
-'''Reviewer:''' [ Enter your name here ]
+'''Reviewer:''' [ A. Vidard ]
 
 === Ticket Details, Documentation and Code changes ===
-||Do you understand the area of code being altered and the reasoning why it is being altered?||YES/NO||
-||Do the proposed code changes correspond with the stated reason for the change?||YES/NO||
-||Is the in-line documentation accurate and sufficient?||YES/NO||
-||Do the code changes comply with NEMO coding standards?||YES/NO||
-||Is the Ticket documented with sufficient detail for others to understand the impact of the change?||YES/NO||
-||Does any corresponding external documentation require updating?||YES/NO||
-||If yes, which docs and have the updates been drafted?||YES/NO||
-||Are namelist changes required for this change?||YES/NO||
-||If yes, have they been done?||YES/NO||
-||Has a completed Ticket Summary template been appended to the ticket to aid code reviews||YES/NO||
-||Does this summary correspond with your understanding of the full ticket?||YES/NO||
+|| Do you understand the area of code being altered and the reasoning why it is being altered? || YES ||
+|| Do the proposed code changes correspond with the stated reason for the change? || YES ||
+|| Is the in-line documentation accurate and sufficient? || YES ||
+|| Do the code changes comply with NEMO coding standards? || NO ||
+|| Is the Ticket documented with sufficient detail for others to understand the impact of the change? || YES ||
+|| Does any corresponding external documentation require updating? || YES ||
+|| If yes, which docs and have the updates been drafted? || OBS/? ||
+|| Are namelist changes required for this change? || YES ||
+|| If yes, have they been done? || YES ||
+|| Has a completed Ticket Summary template been appended to the ticket to aid code reviews || YES ||
+|| Does this summary correspond with your understanding of the full ticket? || YES ||
 
 Ticket, Documentation and Code comments
@@ -24 +24 @@
 
 === Testing ===
-||Has the NVTK and other jobs been tested with this change?||YES/NO||
-||Have the required bit comparability tests been run?||YES/NO||
-||Can this change be shown to have a null impact? (if option not selected)||YES/NO||
-||If no, is reason for the change valid/understood?||YES/NO/NA||
-||If no, ensure that the ticket details the impact this change will have on model configurations .||YES/NO/NA||
-||Is this change expected to preserve all diagnostics?||YES/NO||
-||If no, is reason for the change valid/understood?||YES/NO/NA||
-||Are there significant changes in run time/memory?||YES/NO||
-
-Testing Comments
-
-Add specific testing comments here
-
-Add specific testing comments here
+see !https://forge.ipsl.jussieu.fr/nemo/wiki/ticket/1328
 
 === Code Review ===
-||Do the code changes comply with NEMO coding standards?||YES/NO||
-||Are code changes consistent with the design of NEMO?||YES/NO||
-||Is the code free of unwanted TABs?||YES/NO||
-||Has the code been wholly (100%) produced by NEMO developers working on NEMO?||YES/NO||
-||If no, ensure collaboration agreement has been added to the ticket keywords||||
+|| Do the code changes comply with NEMO coding standards? || NO ||
+|| Are code changes consistent with the design of NEMO? || YES ||
+|| Is the code free of unwanted TABs? || YES ||
+|| Has the code been wholly (100%) produced by NEMO developers working on NEMO? || NO ||
+|| If no, ensure collaboration agreement has been added to the ticket keywords ||
 
 Add specific code comments or suggested alterations here.
 
 === Review Summary ===
-Add summary here
+There are some breaches to the NEMO coding norm, in the variable names. Actually they are quite common in the pre-existing OBS code.
+
+It is a bit of a shame that OBS is not able to use NEMO's standard IO library and has to use netcdf statements. Maybe some internal discussions about updating the IO library for coping with OBS needs would be beneficial.
 
 === Approval for the trunk ===
-YES/NO
+YES
 
 The code reviewer may approve the change for the NEMO trunk when: