Changes between Version 1 and Version 2 of ticket/1358/review
- Timestamp:
- 2015-12-14T09:33:40+01:00 (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
ticket/1358/review
v1 v2 4 4 5 5 == For completion by the Sci/Tech/Code reviewer == 6 '''Reviewer:''' [ Enter your name here ]6 '''Reviewer:''' Clement Bricaud 7 7 8 8 === Ticket Details, Documentation and Code changes === 9 ||Do you understand the area of code being altered and the reasoning why it is being altered?||YES /NO||10 ||Do the proposed code changes correspond with the stated reason for the change?||YES /NO||11 ||Is the in-line documentation accurate and sufficient?||YES /NO||12 ||Do the code changes comply with NEMO coding standards?||YES /NO||13 ||Is the Ticket documented with sufficient detail for others to understand the impact of the change?||YES /NO||14 ||Does any corresponding external documentation require updating?||YES /NO||15 ||If yes, which docs and have the updates been drafted?|| YES/NO||16 ||Are namelist changes required for this change?|| YES/NO||9 ||Do you understand the area of code being altered and the reasoning why it is being altered?||YES|| 10 ||Do the proposed code changes correspond with the stated reason for the change?||YES|| 11 ||Is the in-line documentation accurate and sufficient?||YES|| 12 ||Do the code changes comply with NEMO coding standards?||YES|| 13 ||Is the Ticket documented with sufficient detail for others to understand the impact of the change?||YES|| 14 ||Does any corresponding external documentation require updating?||YES|| 15 ||If yes, which docs and have the updates been drafted?||NO|| 16 ||Are namelist changes required for this change?||NO|| 17 17 ||If yes, have they been done?||YES/NO|| 18 ||Has a completed Ticket Summary template been appended to the ticket to aid code reviews||YES /NO||19 ||Does this summary correspond with your understanding of the full ticket?||YES /NO||18 ||Has a completed Ticket Summary template been appended to the ticket to aid code reviews||YES|| 19 ||Does this summary correspond with your understanding of the full ticket?||YES|| 20 20 21 21 Ticket, Documentation and Code comments … … 24 24 25 25 === Testing === 26 ||Has the NVTK and other jobs been tested with this change?|| YES/NO||26 ||Has the NVTK and other jobs been tested with this change?||no specific configuration for SAO || 27 27 ||Have the required bit comparability tests been run?||YES/NO|| 28 28 ||Can this change be shown to have a null impact? (if option not selected)||YES/NO|| 29 29 ||If no, is reason for the change valid/understood?||YES/NO/NA|| 30 30 ||If no, ensure that the ticket details the impact this change will have on model configurations .||YES/NO/NA|| 31 ||Is this change expected to preserve all diagnostics?||YES /NO||31 ||Is this change expected to preserve all diagnostics?||YES|| 32 32 ||If no, is reason for the change valid/understood?||YES/NO/NA|| 33 ||Are there significant changes in run time/memory?|| YES/NO||33 ||Are there significant changes in run time/memory?|| ??? || 34 34 35 35 Testing Comments … … 37 37 Add specific testing comments here 38 38 39 Is there a reason to keep a link to dtadyn is SAO_SRC ? 40 Does thes changes lead to rutime/memory changes ? 41 42 39 43 Add specific testing comments here 40 44 41 45 === Code Review === 42 ||Do the code changes comply with NEMO coding standards?||YES /NO||43 ||Are code changes consistent with the design of NEMO?||YES /NO||44 ||Is the code free of unwanted TABs?||YES /NO||45 ||Has the code been wholly (100%) produced by NEMO developers working on NEMO?||YES /NO||46 ||Do the code changes comply with NEMO coding standards?||YES|| 47 ||Are code changes consistent with the design of NEMO?||YES|| 48 ||Is the code free of unwanted TABs?||YES|| 49 ||Has the code been wholly (100%) produced by NEMO developers working on NEMO?||YES|| 46 50 ||If no, ensure collaboration agreement has been added to the ticket keywords|||| 47 51
