Changes between Initial Version and Version 1 of ticket/1447

2015-10-13T11:28:53+02:00 (5 years ago)


  • ticket/1447

    v1 v1  
     2Last edited [[Timestamp]] 
     6'''Author''' : Tim Graham 
     8'''ticket''' : #1447 
     10'''Branch''' : [    dev_r5187_UKMO13_simplification ]  
     13=== Description === 
     14Creation of an offline tool (SCOORD_GEN) to generate a vertical coordinates input file for use with S coordinates. This has been carried out by copying the model code to an offline tool and then modifying it to suppress the use of 3D arrays (to reduce memory usage). 
     17=== Testing === 
     18Testing could consider (where appropriate) other configurations in addition to NVTK]. 
     20||SETTE Tested||!'''N/A'''|| 
     21||Other model configurations||!'''YES'''|| 
     22||Processor configurations tested||[ N/A ]|| 
     23||If adding new functionality please confirm that the [[BR]]New code doesn't change results when it is switched off [[BR]]and !''works!'' when switched on||!'''NA!'''|| 
     25(Answering UNSURE is likely to generate further questions from reviewers.) 
     27'Please add further summary details here' 
     29The tool has been tested by comparing vertical coordinate output in the mesh_mask file from the AMM12 configuration to the output from the tool. The following variables were compared and were equal to the last bit: 
     30mbathy, hbatt, hbatu, hbatv, hbatf, e3t_0, e3u_0, e3v_0, e3w_0, gdept_0 
     32Coordinates were generated using Song/Haidvogel 1994, Siddorn/Furner 2012, and tanh functions. 
     34Functionality is also included to apply tapering to the coordinates in the vicinity of the equator and has been tested. Note that there is a bug in the online code for this as the test to see if the domain crosses the equator is applied at a processor level instead of the global domain. If this bug is fixed then results are unchanged. This bug should be fixed in vn3.6 stable (and the trunk until that section of code is removed). 
     36=== Bit Comparability === 
     37||Does this change preserve answers in your tested standard configurations (to the last bit) ?||!'''N/A !'''|| 
     38||Does this change bit compare across various processor configurations. (1xM, Nx1 and MxN are recommended)||!'''N/A'''|| 
     39||Is this change expected to preserve answers in all possible model configurations?||!'''YES'''|| 
     40||Is this change expected to preserve all diagnostics? [[BR]]!,,!''Preserving answers in model runs does not necessarily imply preserved diagnostics. !''||!'''YES'''|| 
     42If you answered !'''NO!''' to any of the above, please provide further details: 
     44 * Which routine(s) are causing the difference? 
     45 * Why the changes are not protected by a logical switch or new section-version 
     46 * What is needed to achieve regression with the previous model release (e.g. a regression branch, hand-edits etc). If this is not possible, explain why not. 
     47 * What do you expect to see occur in the test harness jobs? 
     48 * Which diagnostics have you altered and why have they changed?Please add details here........ 
     51=== System Changes === 
     52||Does your change alter namelists?||!'''NO !'''|| 
     53||Does your change require a change in compiler options?||!'''NO !'''|| 
     55Requires its own namelist in the TOOL directory 
     58=== Resources === 
     62=== IPR issues === 
     63||Has the code been wholly (100%) produced by NEMO developers staff working exclusively on NEMO?||!'''YES !'''|| 
     65If No: 
     67 * Identify the collaboration agreement details 
     68 * Ensure the code routine header is in accordance with the agreement, (Copyright/Redistribution etc).Add further details here if required..........