Last edited Timestamp?
For completion by the Sci/Tech/Code? reviewer
Reviewer: [ Nicolas Jourdain ]
Ticket Details, Documentation and Code changes
Do you understand the area of code being altered and the reasoning why it is being altered? | YES |
Do the proposed code changes correspond with the stated reason for the change? | YES |
Is the in-line documentation accurate and sufficient? | YES |
Do the code changes comply with NEMO coding standards? | YES |
Is the Ticket documented with sufficient detail for others to understand the impact of the change? | YES |
Does any corresponding external documentation require updating? | YES |
The NEMO Book needs to be updated
If yes, which docs and have the updates been drafted? | NA |
Are namelist changes required for this change? | YES |
If yes, have they been done? | YES |
Has a completed Ticket Summary template been appended to the ticket to aid code reviews | YES |
Does this summary correspond with your understanding of the full ticket? | YES |
Ticket, Documentation and Code comments
Add specific Ticket, Documentation and code comments here
Testing
Has the NVTK and other jobs been tested with this change? | NA |
Have the required bit comparability tests been run? | NA |
Can this change be shown to have a null impact? (if option not selected) | NA |
If no, is reason for the change valid/understood? | NA |
If no, ensure that the ticket details the impact this change will have on model configurations . | NA |
Is this change expected to preserve all diagnostics? | NO |
If no, is reason for the change valid/understood? | YES |
Are there significant changes in run time/memory? | YES |
Testing Comments
Tested with interactive ice-shelves (nn_isf=1) in AMU12 (regional configuration of the Amundsen Sea, 2-year simulations) with the following sets of keys :
key_bdy key_trabbl key_traldf_c2d key_dynspg_flt key_dynldf_c2d key_ldfslp key_zdftke key_iomput key_mpp_mpi key_lim3
and
key_bdy key_trabbl key_traldf_c2d key_dynspg_flt key_dynldf_c2d key_ldfslp key_zdftke key_iomput key_mpp_mpi key_lim3 key_tide key_diaharm
and
key_bdy key_trabbl key_traldf_c2d key_dynspg_ts key_dynldf_c2d key_ldfslp key_zdftke key_iomput key_mpp_mpi key_lim3
Results : increased sub-glacial mean melt-rates compared to NEMO3.6_STABLE (r5672) by a factor of 2-3. No significant melt-rate difference between filtered free surface and time-splitting.
Code Review
Do the code changes comply with NEMO coding standards? | YES |
Are code changes consistent with the design of NEMO? | YES |
Is the code free of unwanted TABs? | YES |
Has the code been wholly (100%) produced by NEMO developers working on NEMO? | YES |
If no, ensure collaboration agreement has been added to the ticket keywords |
Add specific code comments or suggested alterations here.
Review Summary
Good job by Pierre
Approval for the trunk
YES
The code reviewer may approve the change for the NEMO trunk when:
- their requests/comments have been addressed satisfactorily.
- the above check-list has been completed.
or the code reviewer may choose to reject & assign the change back to the code author.