Changes between Version 1 and Version 2 of ticket/1586

Timestamp:

2015-08-10T17:38:01+02:00 (9 years ago)

Author:

jwhile

Comment:

--

ticket/1586

@@ -8 +8 @@
 '''ticket''' : #665
 
-'''Branch''' : [https://forge.ipsl.jussieu.fr/nemo/browser/branches/BRANCH_NAME      BRANCH_NAME ] 
+'''Branch''' : [https://forge.ipsl.jussieu.fr/nemo/browser/branches/2015/dev_r5656_Met_Office_3_diurnalSST dev_r5656_Met_Office_3_diurnalSST ] 
 ----
 
 === Description ===
 
+Add the Takaya et al(2010) warm layer model and Artale et al(2002) cool skin model to NEMO.
 
 ----
@@ -18 +19 @@
 Testing could consider (where appropriate) other configurations in addition to NVTK].
 
-||NVTK Tested||!'''YES/NO!'''||
-||Other model configurations||!'''YES/NO!'''||
-||Processor configurations tested||[ Enter processor configs tested here ]||
-||If adding new functionality please confirm that the [[BR]]New code doesn't change results when it is switched off [[BR]]and !''works!'' when switched on||!'''YES/NO/NA!'''||
+||NVTK Tested||!'''YES!'''||
+||Other model configurations||!'''YES!'''||
+||Processor configurations tested||[ Standard configurations as tested by SETTE ]||
+||If adding new functionality please confirm that the [[BR]]New code doesn't change results when it is switched off [[BR]]and !''works!'' when switched on||!'''YES'''||
 
 (Answering UNSURE is likely to generate further questions from reviewers.)
@@ -27 +28 @@
 'Please add further summary details here'
 
- * Processor configurations tested
- * etc----
-
 === Bit Comparability ===
-||Does this change preserve answers in your tested standard configurations (to the last bit) ?||!'''YES/NO !'''||
-||Does this change bit compare across various processor configurations. (1xM, Nx1 and MxN are recommended)||!'''YES/NO!'''||
-||Is this change expected to preserve answers in all possible model configurations?||!'''YES/NO!'''||
-||Is this change expected to preserve all diagnostics? [[BR]]!,,!''Preserving answers in model runs does not necessarily imply preserved diagnostics. !''||!'''YES/NO!'''||
+||Does this change preserve answers in your tested standard configurations (to the last bit) ?||!'''YES'''||
+||Does this change bit compare across various processor configurations. (1xM, Nx1 and MxN are recommended)||!'''YES'''||
+||Is this change expected to preserve answers in all possible model configurations?||!'''YES'''||
+||Is this change expected to preserve all diagnostics? [[BR]]!,,!''Preserving answers in model runs does not necessarily imply preserved diagnostics. !''||!'''YES'''||
 
 If you answered !'''NO!''' to any of the above, please provide further details:
@@ -46 +44 @@
 ----
 === System Changes ===
-||Does your change alter namelists?||!'''YES/NO !'''||
-||Does your change require a change in compiler options?||!'''YES/NO !'''||
+||Does your change alter namelists?||!'''YES !'''||
+||Does your change require a change in compiler options?||!'''NO !'''||
 
 If any of these apply, please document the changes required here.......
 
+A new namelist called namdiu has been added that controls the diurnal models.  I have added this namelist to namelist_ref in the shared directory.  By default, and to preserve the standard behaviour, the namelist has the cool skin and warm layer models switched off (i.e logical ln_diurnal=.FALSE.).
+ 
 ----
 === Resources ===
 !''Please !''summarize!'' any changes in runtime or memory use caused by this change......!''
 
+There should be no changes if running with ln_diurnal=.FALSE. If ln_diurnal=.TRUE. then memory is required for two extra 2-D fields.  The warm layer and cool skin models (if ln_diurnal=.TRUE.) will also add additional computation, but the models are cheap and this should not be significant.
+
 ----
 === IPR issues ===
-||Has the code been wholly (100%) produced by NEMO developers staff working exclusively on NEMO?||!'''YES/ NO !'''||
+||Has the code been wholly (100%) produced by NEMO developers staff working exclusively on NEMO?||!'''YES !'''||
 
 If No: