Changes between Version 1 and Version 2 of ticket/1586


Ignore:
Timestamp:
2015-08-10T17:38:01+02:00 (5 years ago)
Author:
jwhile
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • ticket/1586

    v1 v2  
    88'''ticket''' : #665 
    99 
    10 '''Branch''' : [https://forge.ipsl.jussieu.fr/nemo/browser/branches/BRANCH_NAME      BRANCH_NAME ]  
     10'''Branch''' : [https://forge.ipsl.jussieu.fr/nemo/browser/branches/2015/dev_r5656_Met_Office_3_diurnalSST dev_r5656_Met_Office_3_diurnalSST ]  
    1111---- 
    1212 
    1313=== Description === 
    1414 
     15Add the Takaya et al(2010) warm layer model and Artale et al(2002) cool skin model to NEMO. 
    1516 
    1617---- 
     
    1819Testing could consider (where appropriate) other configurations in addition to NVTK]. 
    1920 
    20 ||NVTK Tested||!'''YES/NO!'''|| 
    21 ||Other model configurations||!'''YES/NO!'''|| 
    22 ||Processor configurations tested||[ Enter processor configs tested here ]|| 
    23 ||If adding new functionality please confirm that the [[BR]]New code doesn't change results when it is switched off [[BR]]and !''works!'' when switched on||!'''YES/NO/NA!'''|| 
     21||NVTK Tested||!'''YES!'''|| 
     22||Other model configurations||!'''YES!'''|| 
     23||Processor configurations tested||[ Standard configurations as tested by SETTE ]|| 
     24||If adding new functionality please confirm that the [[BR]]New code doesn't change results when it is switched off [[BR]]and !''works!'' when switched on||!'''YES'''|| 
    2425 
    2526(Answering UNSURE is likely to generate further questions from reviewers.) 
     
    2728'Please add further summary details here' 
    2829 
    29  * Processor configurations tested 
    30  * etc---- 
    31  
    3230=== Bit Comparability === 
    33 ||Does this change preserve answers in your tested standard configurations (to the last bit) ?||!'''YES/NO !'''|| 
    34 ||Does this change bit compare across various processor configurations. (1xM, Nx1 and MxN are recommended)||!'''YES/NO!'''|| 
    35 ||Is this change expected to preserve answers in all possible model configurations?||!'''YES/NO!'''|| 
    36 ||Is this change expected to preserve all diagnostics? [[BR]]!,,!''Preserving answers in model runs does not necessarily imply preserved diagnostics. !''||!'''YES/NO!'''|| 
     31||Does this change preserve answers in your tested standard configurations (to the last bit) ?||!'''YES'''|| 
     32||Does this change bit compare across various processor configurations. (1xM, Nx1 and MxN are recommended)||!'''YES'''|| 
     33||Is this change expected to preserve answers in all possible model configurations?||!'''YES'''|| 
     34||Is this change expected to preserve all diagnostics? [[BR]]!,,!''Preserving answers in model runs does not necessarily imply preserved diagnostics. !''||!'''YES'''|| 
    3735 
    3836If you answered !'''NO!''' to any of the above, please provide further details: 
     
    4644---- 
    4745=== System Changes === 
    48 ||Does your change alter namelists?||!'''YES/NO !'''|| 
    49 ||Does your change require a change in compiler options?||!'''YES/NO !'''|| 
     46||Does your change alter namelists?||!'''YES !'''|| 
     47||Does your change require a change in compiler options?||!'''NO !'''|| 
    5048 
    5149If any of these apply, please document the changes required here....... 
    5250 
     51A new namelist called namdiu has been added that controls the diurnal models.  I have added this namelist to namelist_ref in the shared directory.  By default, and to preserve the standard behaviour, the namelist has the cool skin and warm layer models switched off (i.e logical ln_diurnal=.FALSE.). 
     52  
    5353---- 
    5454=== Resources === 
    5555!''Please !''summarize!'' any changes in runtime or memory use caused by this change......!'' 
    5656 
     57There should be no changes if running with ln_diurnal=.FALSE. If ln_diurnal=.TRUE. then memory is required for two extra 2-D fields.  The warm layer and cool skin models (if ln_diurnal=.TRUE.) will also add additional computation, but the models are cheap and this should not be significant. 
     58 
    5759---- 
    5860=== IPR issues === 
    59 ||Has the code been wholly (100%) produced by NEMO developers staff working exclusively on NEMO?||!'''YES/ NO !'''|| 
     61||Has the code been wholly (100%) produced by NEMO developers staff working exclusively on NEMO?||!'''YES !'''|| 
    6062 
    6163If No: