Version 2 (modified by jwhile, 5 years ago) (diff)

Last edited Timestamp?


Author : AUTHOR_NAME

ticket : #665

Branch : dev_r5656_Met_Office_3_diurnalSST


Description

Add the Takaya et al(2010) warm layer model and Artale et al(2002) cool skin model to NEMO.


Testing

Testing could consider (where appropriate) other configurations in addition to NVTK].

NVTK Tested'''YES'''
Other model configurations'''YES'''
Processor configurations tested[ Standard configurations as tested by SETTE ]
If adding new functionality please confirm that the
New code doesn't change results when it is switched off
and ''works'' when switched on
'''YES

(Answering UNSURE is likely to generate further questions from reviewers.)

'Please add further summary details here'

Bit Comparability

Does this change preserve answers in your tested standard configurations (to the last bit) ?'''YES
Does this change bit compare across various processor configurations. (1xM, Nx1 and MxN are recommended)'''YES
Is this change expected to preserve answers in all possible model configurations?'''YES
Is this change expected to preserve all diagnostics?
,,''Preserving answers in model runs does not necessarily imply preserved diagnostics. ''
'''YES

If you answered '''NO''' to any of the above, please provide further details:

  • Which routine(s) are causing the difference?
  • Why the changes are not protected by a logical switch or new section-version
  • What is needed to achieve regression with the previous model release (e.g. a regression branch, hand-edits etc). If this is not possible, explain why not.
  • What do you expect to see occur in the test harness jobs?
  • Which diagnostics have you altered and why have they changed?Please add details here……..

System Changes

Does your change alter namelists?'''YES '''
Does your change require a change in compiler options?'''NO '''

If any of these apply, please document the changes required here…….

A new namelist called namdiu has been added that controls the diurnal models. I have added this namelist to namelist_ref in the shared directory. By default, and to preserve the standard behaviour, the namelist has the cool skin and warm layer models switched off (i.e logical ln_diurnal=.FALSE.).


Resources

''Please ''summarize'' any changes in runtime or memory use caused by this change……''

There should be no changes if running with ln_diurnal=.FALSE. If ln_diurnal=.TRUE. then memory is required for two extra 2-D fields. The warm layer and cool skin models (if ln_diurnal=.TRUE.) will also add additional computation, but the models are cheap and this should not be significant.


IPR issues

Has the code been wholly (100%) produced by NEMO developers staff working exclusively on NEMO?'''YES '''

If No:

  • Identify the collaboration agreement details
  • Ensure the code routine header is in accordance with the agreement, (Copyright/Redistribution? etc).Add further details here if required……….