Changes between Version 19 and Version 20 of ticket/1593_CNRS9_NOC3_LDF


Ignore:
Timestamp:
2015-09-29T11:35:28+02:00 (5 years ago)
Author:
gm
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • ticket/1593_CNRS9_NOC3_LDF

    v19 v20  
    2525Three steps: 
    2626 
    27   '''                                   I. Phasing of horizontal scale factors                         '''         ===>>> OK see '''                      revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]         '''        + minor correction'''         revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]    (SETTE OK)''' 
     27  '''                                    I. Phasing of horizontal scale factors                         '''          ===>>> OK see '''                       revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]          '''         + minor correction'''          revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]     (SETTE OK)''' 
    2828 
    2929'''   (I.1)''' standardisation of the name of quantities derived from horizontal scale factors (many modules of NEMO)[[BR]]The chosen names of quantities derived from horizontal scale factors are:[[BR]]- inverse of scale factors : r1_e1t, r1_e2t, r1_e1u, r1_e2u, r1_e1v, r1_e2v, r1_e1f, r1_e2f ;[[BR]]- surfaces and their inverse:    e1e2t, e1e2u , e1e2v, e1e2f  and, r1_e1e2t , r1_e1e2u , r1_e1e2v, r1_e1e2f ;[[BR]]- ratio (used in traldf...) : e2_e1u , e1_e2v(I.1) generalize of the use of surface scale factors ;[[BR]]These quantities are defined in memory in dom_oce.F90, and set to their proper value in domhgr.F90 
     
    3131'''   (I.2)''' add a optional read of surface scale factors at velocity points in coordinate file (domhgr.F90)[[BR]]        The input coordinate file have to include e1e2u and e1e2v in case of reduction of the scale factors in some straits.[[BR]]        When e1u or e2v are reduced in some straits, the surface at u- and v-points remains unchanged.[[BR]]        This allows to suppress the dom_vvl_orca_fix routine from dlmvvl.F90 module.[[BR]]''Note that this change modifies the model results'', as it contains a better handling of reduced strait width (i.e. reduced surface between 2 adjacent U or V points, but unchanged U and V points volume).[[BR]]The implementation performed here is a first step to the full simplification of domhgr.F90. We kept here the hard coded reduction of scale factor in some straits for some given ORCA configuration. [[BR]]A last step (see IV) will be to suppress the hard coded reduction of some scale factor as it will be always given in the coordinates.nc file together with the e1e2u & e1e2v surfaces.  ===>>> OK see '''revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5755]''' 
    3232 
    33   '''                                   II. Phasing of the advective/diffusive trends on tracers''' 
    34  
    35 '''II.1 —''' '''LDF on tracers''' (both TRA & TRC) - Diffusive trends :    ''' '''===>>> OK see '''revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5758] &  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5759] and  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5760] with SETTE OK''' 
     33  '''                                    II. Phasing of the advective/diffusive trends on tracers''' 
     34 
     35'''II.1 —''' '''LDF on tracers''' (both TRA & TRC) - Diffusive trends :    ''' '''===>>> OK see '''revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5758] &  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5759] and  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5760] with SETTE OK''' 
    3636 
    3737''operator'': [[BR]]- laplacian operator: re-entrant laplacian for iso-level, standard iso-neutral, and triad iso-neutral operators ;[[BR]]- bilaplacian operator: traldf_blp.F90 module: use of the re-entrant laplacian [[BR]]- both standard and triad iso-neutral operators includes  the Method of Stabilizing Correction (Lemarié et al. (2012) which allows bilaplacian along iso-neutral surfaces ;[[BR]]- triad operator: introduce Beckers et al. (2000) compact stencil in the cross-isoneutral direction ; make the triad operator available in TOP[[BR]]- change name:  traldf_iso_grif.F90 becomes traldf_iso_triad.F90[[BR]]- suppression of traadv_eiv.F90 ; traldf_bilap.F90 ; traldf_bilapg.F90 ;[[BR]]- remove the possibility to compute the lateral diffusion from T-S anomalies (key_traldf_ano) 
     
    9090''passive tracers''[[BR]]- all changes in the management of diffusive coefficients and operator has been taken into account in TOP 
    9191 
    92  * '''Pending issues''' : [[BR]]- verify diaptr.F90  : not sure it is OK[[BR]]- add the max grid size in the coordinate file and use it to compute grid dependent diffusivity. This will solve an issue with regional and AGRIF configurations[[BR]]- test all 6 operators.[[BR]]- change default option in the namelist ! 
    93  
    94 '''II.1 —''' '''Advective trends''' :TRA/traadv....[[BR]][[BR]]- traadv_muscl2.F90  removed[[BR]]- traadv_cen2.F90  replaced by traadv_cen which provides 2nd and 4th order centered scheme on both horizontal and vertical directions.[[BR]]- name TVD has been changed to the more commonly used FCT (Flux Correction Transport)[[BR]]- FCT provides now 2nd and 4th order centered scheme on both horizontal and vertical directions.[[BR]]- NB in case of 4th order in the vertical, both CEN and FCT use a compact 4th order scheme[[BR]]- key_esopa removed from traadv.F90 
     92 * '''Pending issues''' : [[BR]]- verify diaptr.F90  : not sure it is OK[[BR]]- add the max grid size in the coordinate file and use it to compute grid dependent diffusivity. This will solve an issue with regional and AGRIF configurations[[BR]]- test all 6 operators.[[BR]]- change default option in the namelist ! [[BR]]- In field_def.xml  add a comment to say where is the routine calling the corresponding iom_put[[BR]]- in the documentation, add a change in the DOCTOR norm: np_ is now a prefix used for PARAMETER 
     93 
     94'''II.1 —''' '''Advective trends''' :TRA/traadv....[[BR]][[BR]]- traadv_muscl2.F90  removed[[BR]]- traadv_muscl.F90 renamed traadv_mus.F90[[BR]]- traadv_cen2.F90  replaced by traadv_cen which provides 2nd and 4th order centered scheme on both horizontal and vertical directions.[[BR]]- name TVD has been changed to the more commonly used FCT (Flux Correction Transport)[[BR]]- FCT provides now 2nd and 4th order centered scheme on both horizontal and vertical directions.[[BR]]- NB in case of 4th order in the vertical, both CEN and FCT use a compact 4th order scheme[[BR]]- key_esopa removed from traadv.F90 
    9595 
    9696{{{ 
     
    9898&namtra_adv    !   advection scheme for tracer 
    9999!----------------------------------------------------------------------- 
    100    ln_traadv_cen    =  .false.  !  2nd order centered scheme 
    101       nn_cen_h      =  4               !  =2/4, horizontal 2nd order CEN / 4th order CEN 
    102       nn_cen_v      =  4               !  =2/4, vertical   2nd order CEN / 4th order COMPACT 
    103    ln_traadv_fct    =  .false.  !  FCT scheme 
    104       nn_fct_h      =  2               !  =2/4, horizontal 2nd / 4th order  
    105       nn_fct_v      =  2               !  =2/4, vertical   2nd / COMPACT 4th order  
    106       nn_fct_zts    =  0               !  >=1, 2nd order FCT scheme with vertical sub-timestepping 
    107       !                                !        (number of sub-timestep = nn_fct_zts) 
    108    ln_traadv_muscl =  .false.  !  MUSCL scheme 
    109       ln_muscl_ups =  .false.         !  use upstream scheme near river mouths 
    110    ln_traadv_ubs    =  .false.  !  UBS scheme 
    111       nn_ubs_v      =  2               !  =2  , vertical 2nd order FCT 
    112    ln_traadv_qck    =  .false.  !  QUICKEST scheme 
     100   ln_traadv_cen =  .false.  !  2nd order centered scheme 
     101      nn_cen_h   =  4               !  =2/4, horizontal 2nd order CEN / 4th order CEN 
     102      nn_cen_v   =  4               !  =2/4, vertical   2nd order CEN / 4th order COMPACT 
     103   ln_traadv_fct =  .false.  !  FCT scheme 
     104      nn_fct_h   =  2               !  =2/4, horizontal 2nd / 4th order  
     105      nn_fct_v   =  2               !  =2/4, vertical   2nd / COMPACT 4th order  
     106      nn_fct_zts =  0               !  > 1 , 2nd order FCT scheme with vertical sub-timestepping 
     107      !                             !        (number of sub-timestep = nn_fct_zts) 
     108   ln_traadv_mus =  .false.  !  MUSCL scheme 
     109      ln_mus_ups =  .false.         !  use upstream scheme near river mouths 
     110   ln_traadv_ubs =  .false.  !  UBS scheme 
     111      nn_ubs_v   =  2               !  =2  , vertical 2nd order FCT 
     112   ln_traadv_qck =  .false.  !  QUICKEST scheme 
    113113/ 
    114114}}} 
    115 '''Pending issues''' on TRAADV: [[BR]]- QCK: cross terms are missing. alternate direction should be added....[[BR]]- Bug in FCT with sub-time-stepping and key_vvl. The change in e3 should be taken into account in the sub-timesteps. 
     115'''Pending issues''' on TRAADV: [[BR]]- QCK: cross terms are missing. alternate direction should be added....[[BR]]- Bug in FCT with sub-time-stepping and key_vvl. The change in e3 should be taken into account in the sub-timesteps.[[BR]]- In all traadv_... modules: check the surface boundary condition in ISF case 
    116116 
    117117'''(II.X)''' ..Miscellaneous : [[BR]]- Atmospheric pressure forcing: change to a systematic call of sbc_apr in step.F90 (with or without BDY) and remove its call from sbcmod[[BR]]- remove key_ldftra_smag and associated module (ldftra_smag.F90)[[BR]]- remove key_vectopt_loop from all the code except in domzgr_substitute.h90 (it is an obsolescent feature only adapted to vector computers)[[BR]]- remove all "!CDIR " lines = NEC vector compiler instructions 
     
    121121  : 
    122122 
    123   '''                                   III. Phasing of viscous trends''' 
     123  '''                                    III. Phasing of viscous trends''' 
    124124 
    125125'''   (III.1) LDF on dynamics''' 
     
    129129... 
    130130 
    131   '''                                  IV. Solve the pending issues''' 
    132  
    133   '''                                  (IV.1) '''                 specification of eddy viscosity/diffusivity coefficients in case of grid-size dependency.[[BR]]                 Issue:  define the grid-size dependency in such a way that does not require the Equator being inside the domain.[[BR]]                 Solution: add a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain[[BR]]                 and use this scalar to compute the grid-size dependency of the coefficients. '''                 (IV.2) '''                 specification of lateral friction at the coast.[[BR]]                 Issue:  the different values of fmask at the coast have been removed so that this lateral boundary condition doesn't affect the advective term ('''                 double check that'''                  !). fmask is still used for laplacian and bilaplacian viscosities. Nevertheless, the magnitude of lateral friction depends on the magnitude of ahm (bhm, reap.). It seems better to define this magnitude [[BR]]                 Solution: add a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain[[BR]]                 and use this scalar to compute the grid-size dependency of the coefficients. 
     131  '''                                   IV. Solve the pending issues''' 
     132 
     133  '''                                   (IV.1) '''                  specification of eddy viscosity/diffusivity coefficients in case of grid-size dependency.[[BR]]                  Issue:  define the grid-size dependency in such a way that does not require the Equator being inside the domain.[[BR]]                  Solution: add a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain[[BR]]                  and use this scalar to compute the grid-size dependency of the coefficients. '''                  (IV.2) '''                  specification of lateral friction at the coast.[[BR]]                  Issue:  the different values of fmask at the coast have been removed so that this lateral boundary condition doesn't affect the advective term ('''                  double check that'''                   !). fmask is still used for laplacian and bilaplacian viscosities. Nevertheless, the magnitude of lateral friction depends on the magnitude of ahm (bhm, reap.). It seems better to define this magnitude [[BR]]                  Solution: add a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain[[BR]]                  and use this scalar to compute the grid-size dependency of the coefficients. 
    134134 
    135135... 
     
    143143 * test with SETTE (especially restartability and reproducibility ) 
    144144 
    145   '''                 V. Finalize the simplification''' 
    146  
    147   '''                 (V.1) add'''                  in NEMOGCM/TOOLS a directory a program that read a coordinates.nc file apply a reduction of scale factors in some straits, and create the associated extended coordinates file (coordinates_e1e2u_v.nc).[[BR]]                 create the extended coordinates files form ORCA 2°, 1°, and 0.5°. ===>>> Done for ORCA 2° and 1°,  ''' 1/2° and 1/4° missing''' ... 
     145  '''                  V. Finalize the simplification''' 
     146 
     147  '''                  (V.1) add'''                   in NEMOGCM/TOOLS a directory a program that read a coordinates.nc file apply a reduction of scale factors in some straits, and create the associated extended coordinates file (coordinates_e1e2u_v.nc).[[BR]]                  create the extended coordinates files form ORCA 2°, 1°, and 0.5°. ===>>> Done for ORCA 2° and 1°,  '''  1/2° and 1/4° missing''' ... 
    148148 
    149149...