Changes between Version 21 and Version 22 of ticket/1593_CNRS9_NOC3_LDF
- Timestamp:
- 2015-10-01T13:21:20+02:00 (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
ticket/1593_CNRS9_NOC3_LDF
v21 v22 25 25 Three steps: 26 26 27 ''' I. Phasing of horizontal scale factors ''' ===>>> OK see ''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737] ''' + minor correction''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737](SETTE OK)'''27 ''' I. Phasing of horizontal scale factors ''' ===>>> OK see ''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737] ''' + minor correction''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737] (SETTE OK)''' 28 28 29 29 ''' (I.1)''' standardisation of the name of quantities derived from horizontal scale factors (many modules of NEMO)[[BR]]The chosen names of quantities derived from horizontal scale factors are:[[BR]]- inverse of scale factors : r1_e1t, r1_e2t, r1_e1u, r1_e2u, r1_e1v, r1_e2v, r1_e1f, r1_e2f ;[[BR]]- surfaces and their inverse: e1e2t, e1e2u , e1e2v, e1e2f and, r1_e1e2t , r1_e1e2u , r1_e1e2v, r1_e1e2f ;[[BR]]- ratio (used in traldf...) : e2_e1u , e1_e2v(I.1) generalize of the use of surface scale factors ;[[BR]]These quantities are defined in memory in dom_oce.F90, and set to their proper value in domhgr.F90 … … 31 31 ''' (I.2)''' add a optional read of surface scale factors at velocity points in coordinate file (domhgr.F90)[[BR]] The input coordinate file have to include e1e2u and e1e2v in case of reduction of the scale factors in some straits.[[BR]] When e1u or e2v are reduced in some straits, the surface at u- and v-points remains unchanged.[[BR]] This allows to suppress the dom_vvl_orca_fix routine from dlmvvl.F90 module.[[BR]]''Note that this change modifies the model results'', as it contains a better handling of reduced strait width (i.e. reduced surface between 2 adjacent U or V points, but unchanged U and V points volume).[[BR]]The implementation performed here is a first step to the full simplification of domhgr.F90. We kept here the hard coded reduction of scale factor in some straits for some given ORCA configuration. [[BR]]A last step (see IV) will be to suppress the hard coded reduction of some scale factor as it will be always given in the coordinates.nc file together with the e1e2u & e1e2v surfaces. ===>>> OK see '''revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5755]''' 32 32 33 ''' II. Phasing of the advective/diffusive trends on tracers'''33 ''' II. Phasing of the advective/diffusive trends on tracers''' 34 34 35 35 '''II.1 —''' '''LDF on tracers''' (both TRA & TRC) - Diffusive trends : ''' '''===>>> OK see '''revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5758] & [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5759] and [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5760] with SETTE OK''' 36 36 37 ''' ====>>>> Bug in triad operator TO BE CHECKED'''[[BR]]triad operator is neither restartable not repro in the branche (it was the case in v3.6 stable)37 ''' ====>>>> Bug in triad operator TO BE CHECKED'''[[BR]] triad operator is neither restartable not repro in the branche (it was the case in v3.6 stable) 38 38 39 39 ''operator'': [[BR]]- laplacian operator: re-entrant laplacian for iso-level, standard iso-neutral, and triad iso-neutral operators ;[[BR]]- bilaplacian operator: traldf_blp.F90 module: use of the re-entrant laplacian [[BR]]- both standard and triad iso-neutral operators includes the Method of Stabilizing Correction (Lemarié et al. (2012) which allows bilaplacian along iso-neutral surfaces ;[[BR]]- triad operator: introduce Beckers et al. (2000) compact stencil in the cross-isoneutral direction ; make the triad operator available in TOP[[BR]]- change name: traldf_iso_grif.F90 becomes traldf_iso_triad.F90[[BR]]- suppression of traadv_eiv.F90 ; traldf_bilap.F90 ; traldf_bilapg.F90 ;[[BR]]- remove the possibility to compute the lateral diffusion from T-S anomalies (key_traldf_ano) … … 96 96 '''II.1 —''' '''Advective trends''' :TRA/traadv....[[BR]][[BR]]- traadv_muscl2.F90 removed[[BR]]- traadv_muscl.F90 renamed traadv_mus.F90[[BR]]- traadv_cen2.F90 replaced by traadv_cen which provides 2nd and 4th order centered scheme on both horizontal and vertical directions.[[BR]]- name TVD has been changed to the more commonly used FCT (Flux Correction Transport)[[BR]]- FCT provides now 2nd and 4th order centered scheme on both horizontal and vertical directions.[[BR]]- NB in case of 4th order in the vertical, both CEN and FCT use a compact 4th order scheme[[BR]]- key_esopa removed from traadv.F90 97 97 98 - Surface boundary condition in ISF case: Add it in: traadv_cen.F90 ; traadv_fct.F90 ; traadv_mus.F90 ; 99 98 100 {{{ 99 101 !----------------------------------------------------------------------- … … 115 117 / 116 118 }}} 117 '''Pending issues''' on TRAADV: [[BR]]- QCK: cross terms are missing. alternate direction should be added....[[BR]]- Bug in FCT with sub-time-stepping and key_vvl. The change in e3 should be taken into account in the sub-timesteps.[[BR]]- In all traadv_... modules: check the surface boundary condition in ISF case 118 119 '''(II.X)''' ..Miscellaneous : [[BR]]- Atmospheric pressure forcing: change to a systematic call of sbc_apr in step.F90 (with or without BDY) and remove its call from sbcmod[[BR]]- remove key_ldftra_smag and associated module (ldftra_smag.F90)[[BR]]- remove key_vectopt_loop from all the code except in domzgr_substitute.h90 (it is an obsolescent feature only adapted to vector computers)[[BR]]- remove all "!CDIR " lines = NEC vector compiler instructions 119 '''Pending issues''' on TRAADV: [[BR]]- QCK: cross terms are missing. alternate direction should be added....[[BR]]- Bug in FCT with sub-time-stepping and key_vvl. The change in e3 should be taken into account in the sub-timesteps.[[BR]]- traadv_mus.F90 some rather simple optimization can be added...[[BR]]- traadv_qck.F90 : possibility to add a 4th order COMPACT scheme on the vertical. [[BR]]- 4th order COMPACT doesn't work with ISF the routine have to be modified 120 121 '''(II.X)''' ..Miscellaneous : 122 123 - Atmospheric pressure forcing: change to a systematic call of sbc_apr in step.F90 (with or without BDY) and remove its call from sbcmod[[BR]]- remove key_ldftra_smag and associated module (ldftra_smag.F90)[[BR]]- remove key_vectopt_loop from all the code except in domzgr_substitute.h90 (it is an obsolescent feature only adapted to vector computers)[[BR]]- remove all "!CDIR " lines = NEC vector compiler instructions 120 124 121 125 * … … 123 127 : 124 128 125 ''' III. Phasing of viscous trends'''129 ''' III. Phasing of viscous trends''' 126 130 127 131 ''' (III.1) LDF on dynamics''' … … 131 135 ... 132 136 133 ''' IV. Solve the pending issues'''134 135 ''' (IV.1) ''' specification of eddy viscosity/diffusivity coefficients in case of grid-size dependency.[[BR]] Issue: define the grid-size dependency in such a way that does not require the Equator being inside the domain.[[BR]] Solution: add a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain[[BR]] and use this scalar to compute the grid-size dependency of the coefficients. ''' (IV.2) ''' specification of lateral friction at the coast.[[BR]] Issue: the different values of fmask at the coast have been removed so that this lateral boundary condition doesn't affect the advective term (''' double check that''' !). fmask is still used for laplacian and bilaplacian viscosities. Nevertheless, the magnitude of lateral friction depends on the magnitude of ahm (bhm, reap.). It seems better to define this magnitude [[BR]] Solution: add a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain[[BR]]and use this scalar to compute the grid-size dependency of the coefficients.137 ''' IV. Solve the pending issues''' 138 139 ''' (IV.1) ''' specification of eddy viscosity/diffusivity coefficients in case of grid-size dependency.[[BR]] Issue: define the grid-size dependency in such a way that does not require the Equator being inside the domain.[[BR]] Solution: add a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain[[BR]] and use this scalar to compute the grid-size dependency of the coefficients. ''' (IV.2) ''' specification of lateral friction at the coast.[[BR]] Issue: the different values of fmask at the coast have been removed so that this lateral boundary condition doesn't affect the advective term (''' double check that''' !). fmask is still used for laplacian and bilaplacian viscosities. Nevertheless, the magnitude of lateral friction depends on the magnitude of ahm (bhm, reap.). It seems better to define this magnitude [[BR]] Solution: add a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain[[BR]] and use this scalar to compute the grid-size dependency of the coefficients. 136 140 137 141 ... … … 145 149 * test with SETTE (especially restartability and reproducibility ) 146 150 147 ''' V. Finalize the simplification'''148 149 ''' (V.1) add''' in NEMOGCM/TOOLS a directory a program that read a coordinates.nc file apply a reduction of scale factors in some straits, and create the associated extended coordinates file (coordinates_e1e2u_v.nc).[[BR]] create the extended coordinates files form ORCA 2°, 1°, and 0.5°. ===>>> Done for ORCA 2° and 1°, ''' 1/2° and 1/4° missing'''...151 ''' V. Finalize the simplification''' 152 153 ''' (V.1) add''' in NEMOGCM/TOOLS a directory a program that read a coordinates.nc file apply a reduction of scale factors in some straits, and create the associated extended coordinates file (coordinates_e1e2u_v.nc).[[BR]] create the extended coordinates files form ORCA 2°, 1°, and 0.5°. ===>>> Done for ORCA 2° and 1°, ''' 1/2° and 1/4° missing''' ... 150 154 151 155 ...