Changes between Version 22 and Version 23 of ticket/1593_CNRS9_NOC3_LDF


Ignore:
Timestamp:
2015-10-01T14:11:09+02:00 (5 years ago)
Author:
gm
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • ticket/1593_CNRS9_NOC3_LDF

    v22 v23  
    2525Three steps: 
    2626 
    27   '''                                       I. Phasing of horizontal scale factors                         '''             ===>>> OK see '''                          revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]             '''            + minor correction'''             revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]        (SETTE OK)''' 
     27  '''                                        I. Phasing of horizontal scale factors                         '''              ===>>> OK see '''                           revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]              '''             + minor correction'''              revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]         (SETTE OK)''' 
    2828 
    2929'''   (I.1)''' standardisation of the name of quantities derived from horizontal scale factors (many modules of NEMO)[[BR]]The chosen names of quantities derived from horizontal scale factors are:[[BR]]- inverse of scale factors : r1_e1t, r1_e2t, r1_e1u, r1_e2u, r1_e1v, r1_e2v, r1_e1f, r1_e2f ;[[BR]]- surfaces and their inverse:    e1e2t, e1e2u , e1e2v, e1e2f  and, r1_e1e2t , r1_e1e2u , r1_e1e2v, r1_e1e2f ;[[BR]]- ratio (used in traldf...) : e2_e1u , e1_e2v(I.1) generalize of the use of surface scale factors ;[[BR]]These quantities are defined in memory in dom_oce.F90, and set to their proper value in domhgr.F90 
     
    3131'''   (I.2)''' add a optional read of surface scale factors at velocity points in coordinate file (domhgr.F90)[[BR]]        The input coordinate file have to include e1e2u and e1e2v in case of reduction of the scale factors in some straits.[[BR]]        When e1u or e2v are reduced in some straits, the surface at u- and v-points remains unchanged.[[BR]]        This allows to suppress the dom_vvl_orca_fix routine from dlmvvl.F90 module.[[BR]]''Note that this change modifies the model results'', as it contains a better handling of reduced strait width (i.e. reduced surface between 2 adjacent U or V points, but unchanged U and V points volume).[[BR]]The implementation performed here is a first step to the full simplification of domhgr.F90. We kept here the hard coded reduction of scale factor in some straits for some given ORCA configuration. [[BR]]A last step (see IV) will be to suppress the hard coded reduction of some scale factor as it will be always given in the coordinates.nc file together with the e1e2u & e1e2v surfaces.  ===>>> OK see '''revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5755]''' 
    3232 
    33   '''                                       II. Phasing of the advective/diffusive trends on tracers''' 
     33  '''                                        II. Phasing of the advective/diffusive trends on tracers''' 
    3434 
    3535'''II.1 —''' '''LDF on tracers''' (both TRA & TRC) - Diffusive trends :    ''' '''===>>> OK see '''revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5758] &  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5759] and  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5760] with SETTE OK''' 
     
    9494 * '''Pending issues''' : [[BR]]- verify diaptr.F90  : not sure it is OK[[BR]]- add the max grid size in the coordinate file and use it to compute grid dependent diffusivity. This will solve an issue with regional and AGRIF configurations[[BR]]- test all 6 operators.[[BR]]- change default option in the namelist ! [[BR]]- In field_def.xml  add a comment to say where is the routine calling the corresponding iom_put[[BR]]- in the documentation, add a change in the DOCTOR norm: np_ is now a prefix used for PARAMETER 
    9595 
    96 '''II.1 —''' '''Advective trends''' :TRA/traadv....[[BR]][[BR]]- traadv_muscl2.F90  removed[[BR]]- traadv_muscl.F90 renamed traadv_mus.F90[[BR]]- traadv_cen2.F90  replaced by traadv_cen which provides 2nd and 4th order centered scheme on both horizontal and vertical directions.[[BR]]- name TVD has been changed to the more commonly used FCT (Flux Correction Transport)[[BR]]- FCT provides now 2nd and 4th order centered scheme on both horizontal and vertical directions.[[BR]]- NB in case of 4th order in the vertical, both CEN and FCT use a compact 4th order scheme[[BR]]- key_esopa removed from traadv.F90 
    97  
    98 - Surface boundary condition in ISF case: Add it in: traadv_cen.F90  ;  traadv_fct.F90 ;  traadv_mus.F90 ;  
     96'''II.2 —''' '''Advective trends''' :TRA/traadv....[[BR]][[BR]]- traadv_muscl2.F90  removed[[BR]]- traadv_muscl.F90 renamed traadv_mus.F90[[BR]]- traadv_cen2.F90  replaced by traadv_cen which provides 2nd and 4th order centered scheme on both horizontal and vertical directions.[[BR]]- name TVD has been changed to the more commonly used FCT (Flux Correction Transport)[[BR]]- FCT offers now 2nd and 4th order centered scheme on both horizontal and vertical directions.[[BR]]- UBS offers now in option either a 2nd order FCT or a 4th order COMPACT scheme in the vertical direction[[BR]]- NB in case of 4th order in the vertical, CEN, UBS and FCT use a compact 4th order scheme[[BR]]- key_esopa removed from traadv.F90 
     97 
     98 * Surface boundary condition in ISF case has been added in all cases (except 4th order COMPACT scheme which currently don't work with ISF) 
    9999 
    100100{{{ 
     
    117117/ 
    118118}}} 
    119 '''Pending issues''' on TRAADV: [[BR]]- QCK: cross terms are missing. alternate direction should be added....[[BR]]- Bug in FCT with sub-time-stepping and key_vvl. The change in e3 should be taken into account in the sub-timesteps.[[BR]]- traadv_mus.F90   some rather simple optimization can be added...[[BR]]- traadv_qck.F90 : possibility to add a 4th order COMPACT scheme on the vertical. [[BR]]- 4th order COMPACT doesn't work with ISF   the routine have to be modified 
    120  
    121 '''(II.X)''' ..Miscellaneous :  
    122  
    123 - Atmospheric pressure forcing: change to a systematic call of sbc_apr in step.F90 (with or without BDY) and remove its call from sbcmod[[BR]]- remove key_ldftra_smag and associated module (ldftra_smag.F90)[[BR]]- remove key_vectopt_loop from all the code except in domzgr_substitute.h90 (it is an obsolescent feature only adapted to vector computers)[[BR]]- remove all "!CDIR " lines = NEC vector compiler instructions 
     119'''Unresolved issues/improvement''' on TRAADV: [[BR]]- QCK: cross terms are missing. alternate direction should be added....[[BR]]- Bug in FCT with sub-time-stepping and key_vvl. The change in e3 should be taken into account in the sub-timesteps.[[BR]]- traadv_mus.F90   some rather simple optimization can be added...[[BR]]- traadv_qck.F90 : possibility to add a 4th order COMPACT scheme on the vertical. [[BR]]- 4th order COMPACT doesn't work with ISF  the routine have to be modified 
     120 
     121'''(II.X)''' ..Miscellaneous : 
     122 
     123 * Atmospheric pressure forcing: change to a systematic call of sbc_apr in step.F90 (with or without BDY) and remove its call from sbcmod[[BR]]- remove key_ldftra_smag and associated module (ldftra_smag.F90)[[BR]]- remove key_vectopt_loop from all the code except in domzgr_substitute.h90 (it is an obsolescent feature only adapted to vector computers)[[BR]]- remove all "!CDIR " lines = NEC vector compiler instructions 
    124124 
    125125 *  
     
    127127  : 
    128128 
    129   '''                                       III. Phasing of viscous trends''' 
     129  '''                                        III. Phasing of viscous trends''' 
    130130 
    131131'''   (III.1) LDF on dynamics''' 
     
    135135... 
    136136 
    137   '''                                      IV. Solve the pending issues''' 
    138  
    139   '''                                      (IV.1) '''                     specification of eddy viscosity/diffusivity coefficients in case of grid-size dependency.[[BR]]                     Issue:  define the grid-size dependency in such a way that does not require the Equator being inside the domain.[[BR]]                     Solution: add a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain[[BR]]                     and use this scalar to compute the grid-size dependency of the coefficients. '''                     (IV.2) '''                     specification of lateral friction at the coast.[[BR]]                     Issue:  the different values of fmask at the coast have been removed so that this lateral boundary condition doesn't affect the advective term ('''                     double check that'''                      !). fmask is still used for laplacian and bilaplacian viscosities. Nevertheless, the magnitude of lateral friction depends on the magnitude of ahm (bhm, reap.). It seems better to define this magnitude [[BR]]                     Solution: add a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain[[BR]]                     and use this scalar to compute the grid-size dependency of the coefficients. 
     137  '''                                       IV. Solve the pending issues''' 
     138 
     139  '''                                       (IV.1) '''                      specification of eddy viscosity/diffusivity coefficients in case of grid-size dependency.[[BR]]                      Issue:  define the grid-size dependency in such a way that does not require the Equator being inside the domain.[[BR]]                      Solution: add a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain[[BR]]                      and use this scalar to compute the grid-size dependency of the coefficients. '''                      (IV.2) '''                      specification of lateral friction at the coast.[[BR]]                      Issue:  the different values of fmask at the coast have been removed so that this lateral boundary condition doesn't affect the advective term ('''                      double check that'''                       !). fmask is still used for laplacian and bilaplacian viscosities. Nevertheless, the magnitude of lateral friction depends on the magnitude of ahm (bhm, reap.). It seems better to define this magnitude [[BR]]                      Solution: add a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain[[BR]]                      and use this scalar to compute the grid-size dependency of the coefficients. 
    140140 
    141141... 
     
    149149 * test with SETTE (especially restartability and reproducibility ) 
    150150 
    151   '''                     V. Finalize the simplification''' 
    152  
    153   '''                     (V.1) add'''                      in NEMOGCM/TOOLS a directory a program that read a coordinates.nc file apply a reduction of scale factors in some straits, and create the associated extended coordinates file (coordinates_e1e2u_v.nc).[[BR]]                     create the extended coordinates files form ORCA 2°, 1°, and 0.5°. ===>>> Done for ORCA 2° and 1°,  '''     1/2° and 1/4° missing'''     ... 
     151  '''                      V. Finalize the simplification''' 
     152 
     153  '''                      (V.1) add'''                       in NEMOGCM/TOOLS a directory a program that read a coordinates.nc file apply a reduction of scale factors in some straits, and create the associated extended coordinates file (coordinates_e1e2u_v.nc).[[BR]]                      create the extended coordinates files form ORCA 2°, 1°, and 0.5°. ===>>> Done for ORCA 2° and 1°,  '''      1/2° and 1/4° missing'''      ... 
    154154 
    155155...