Changes between Version 30 and Version 31 of ticket/1593_CNRS9_NOC3_LDF


Ignore:
Timestamp:
2015-10-10T07:55:31+02:00 (5 years ago)
Author:
gm
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • ticket/1593_CNRS9_NOC3_LDF

    v30 v31  
    2323Three steps: [[BR]] 
    2424 
    25   '''                                                            I. Phasing of horizontal scale factors                         '''                                  ===>>> OK see '''                                               revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                                  '''                                 + minor correction'''                                  revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                             (SETTE OK)''' 
     25  '''                                                             I. Phasing of horizontal scale factors                         '''                                   ===>>> OK see '''                                                revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                                   '''                                  + minor correction'''                                   revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                              (SETTE OK)''' 
    2626 
    2727'''   (I.1)''' standardisation of the name of quantities derived from horizontal scale factors (many modules of NEMO)[[BR]]The chosen names of quantities derived from horizontal scale factors are:[[BR]]- inverse of scale factors : r1_e1t, r1_e2t, r1_e1u, r1_e2u, r1_e1v, r1_e2v, r1_e1f, r1_e2f ;[[BR]]- surfaces and their inverse:    e1e2t, e1e2u , e1e2v, e1e2f  and, r1_e1e2t , r1_e1e2u , r1_e1e2v, r1_e1e2f ;[[BR]]- ratio (used in traldf...) : e2_e1u , e1_e2v(I.1) generalize of the use of surface scale factors ;[[BR]]These quantities are defined in memory in dom_oce.F90, and set to their proper value in domhgr.F90 
     
    2929'''   (I.2)''' add a optional read of surface scale factors at velocity points in coordinate file (domhgr.F90)[[BR]]   The input coordinate file have to include e1e2u and e1e2v in case of reduction of the scale factors in some straits.[[BR]]        When e1u or e2v are reduced in some straits, the surface at u- and v-points remains unchanged.[[BR]]   This allows to suppress the dom_vvl_orca_fix routine from dlmvvl.F90 module.[[BR]]''Note that this change modifies the model results'', as it contains a better handling of reduced strait width (i.e. reduced surface between 2 adjacent U or V points, but unchanged U and V points volume).[[BR]]   The implementation performed here is a first step to the full simplification of domhgr.F90. We kept here the hard coded reduction of scale factor in some straits for some given ORCA configuration. [[BR]]   A last step (see IV) will be to suppress the hard coded reduction of some scale factor as it will be always given in the coordinates.nc file together with the e1e2u & e1e2v surfaces.  ===>>> OK see '''revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5755]''' 
    3030 
    31   '''        [[BR]]        [[BR]]        II. Phasing of the advective/diffusive trends on tracers''' 
     31  '''         [[BR]]         [[BR]]         II. Phasing of the advective/diffusive trends on tracers''' 
    3232 
    3333'''II.1 —''' '''LDF on tracers''' (both TRA & TRC) - Diffusive trends :    ''' '''===>>> OK see '''revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5758] &  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5759] and  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5760] with SETTE OK''' 
     
    123123 * Atmospheric pressure forcing: change to a systematic call of sbc_apr in step.F90 (with or without BDY) and remove its call from sbcmod[[BR]]- remove key_vectopt_loop from all the code except in domzgr_substitute.h90 (it is an obsolescent feature only adapted to vector computers)[[BR]]- remove all "!CDIR " lines = NEC vector compiler instructions 
    124124 
    125   '''         [[BR]]         [[BR]]         III. Phasing of momentum trends    '''===>>> OK see '''revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5777] & [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5778] and ..... with SETTE O''' 
     125  '''          [[BR]]          [[BR]]          III. Phasing of momentum trends    ''' ===>>> OK see ''' revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5777]  & [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5778]  and   [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5782]  with SETTE OK''' 
    126126 
    127127'''III.1 —''' '''LDF on dynamics'''  - viscous trends 
     
    163163'''[[BR]]III.2 —''' '''ADV on dynamics''' - advective trends : ===>>> OK see '''revision .... and ..... with SETTE OK''' 
    164164 
    165 ''dynvor.F90 (impact also dynspg_ts.F90)''[[BR]]                   - remove key_esopa[[BR]]                   - remove dyn_vor_mix : now successive call of den_vor_ene (Coriolis) and din_vor_ens (relative voricity)[[BR]]                   - replace rotn by its calculation everywhere in dynvor.F90[[BR]]                   - remove the use of fmask everywhere in dynvor.F90         '''=====>>>> TO BE DONE: verify this with Florian '''[[BR]]                    - add an namelist option to mask or not the vorticity (including Coriolis) [[BR]]- change ln_dynvor_een_old into nn_een_e3f = 0/1 
     165''dynvor.F90 (impact also dynspg_ts.F90)''[[BR]]                   - remove key_esopa[[BR]]                   - remove dyn_vor_mix : now successive call of den_vor_ene (Coriolis) and din_vor_ens (relative voricity)[[BR]]                   - replace rotn by its calculation everywhere in dynvor.F90[[BR]]                   - remove the use of fmask from standard vorticity calculation in dynvor.F90 but add a namelist parameter (ln_dynvor_msk) to multiply by fmask the vorticity term[[BR]]- add an namelist option to mask or not the vorticity (including Coriolis) [[BR]]- change ln_dynvor_een_old into nn_een_e3f = 0/1 
    166166 
    167167namdyn_vor becomes: 
     
    187187'''[[BR]]II.3''' '''Miscellaneous :''' 
    188188 
    189  * ... 
    190  
    191 [[BR]]'''IV. Solve the pending issues''' 
    192  
    193   '''                                                           (IV.1) '''                                          specification of eddy viscosity/diffusivity coefficients in case of grid-size dependency.[[BR]]                                          Issue:  define the grid-size dependency in such a way that does not require the Equator being inside the domain.[[BR]]                                          Solution: add a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain[[BR]]                                          and use this scalar to compute the grid-size dependency of the coefficients.  [[BR]]          '''          (IV.2) '''                                          specification of lateral friction at the coast.[[BR]]                                          Issue:  the different values of fmask at the coast have been removed so that this lateral boundary condition doesn't affect the advective term ('''                                          double check that'''                                           !). fmask is still used for laplacian and bilaplacian viscosities. Nevertheless, the magnitude of lateral friction depends on the magnitude of ahm (bhm, reap.). It seems better to define this magnitude [[BR]]                                          Solution: add a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain[[BR]]                                          and use this scalar to compute the grid-size dependency of the coefficients. [[BR]]          '''          (IV.3)'''              Add a proper coding of Smagorinsky eddy viscosity and diffusivity[[BR]]   (IV.4) It should be possible to remove hdivn ...  think about that 
    194  
    195 ... 
    196  
    197 '''remaining to do :''' 
    198  
    199  * '''IV.1 '''In case of variation of the 2D coeff. as a function of the grid size, use a reference to a 1 degree grid size for ah on both tracers and momentum 
    200  * '''IV.2''' management of no-slip boundary condition as fmask no more used in dynvor.F90 .... 
    201  * '''IV.3'''  re-introduce Smagorinsky coefficient  in a consistent way with the re-design LDF if decided... 
    202  *  
    203  * test with SETTE (especially restartability and reproducibility ) 
    204  
    205   [[BR]]           '''            V. Finalize the simplification''' 
    206  
    207   '''                                          (V.1) add'''              in NEMOGCM/TOOLS directory a program that read a coordinates.nc file apply a reduction of scale factors in some straits, and create the associated extended coordinates file (coordinates_e1e2u_v.nc).[[BR]]          '''          (V.2) create'''           the extended coordinates files form ORCA 2°, 1°, and 0.5°. ===>>> Done for ORCA 2° and 1°,  '''                          1/2° and 1/4° missing'''                          ...[[BR]]          '''          (V.3) create'''           in NEMOGCM/TOOLS directory a program that create the ORCA2 and ORCA1 eddy viscosity'''           ????''' 
    208  
    209 ... 
    210  
    211 ---- 
    212 ---- 
    213 '''To be CHECKED''' (not necessary associated with this branch 
     189 * key_esopa has been remove from the whole NEMO code 
     190 
     191[[BR]]'''         IV. Pending issues : need to be solved before v3.7 release''' 
     192 
     193'''(IV.1) '''                                           specification of eddy viscosity/diffusivity coefficients in case of grid-size dependency.[[BR]]Issue:  define the grid-size dependency in such a way that does not require the Equator being inside the domain.[[BR]]Solution: [[BR]]'''- add''' a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain and use this scalar to compute the grid-size dependency of the coefficients. [[BR]]In addition:[[BR]]- '''add''' in NEMOGCM/TOOLS directory a program that read a coordinates.nc file apply a reduction of scale factors in some straits, and create the associated extended coordinates file (coordinates_e1e2u_v.nc)[[BR]]- '''create''' the extended coordinates files form ORCA 2°, 1°, and 0.5°. ===>>> Done for ORCA 2° and 1°,  '''1/2° and 1/4° missing...[[BR]]''' 
     194 
     195'''(IV.2) '''                                           specification of lateral friction at the coast.[[BR]]Issue:  the different values of fmask at the coast have been removed so that this lateral boundary condition doesn't affect the advective term ('''                                           double check that'''                                            !). fmask is still used for laplacian and bilaplacian viscosities. Nevertheless, the magnitude of lateral friction depends on the magnitude of ahm (bhm, reap.). It seems better to define this magnitude [[BR]]Solution: [[BR]]- '''add''' a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain and use this scalar to compute the grid-size dependency of the coefficients.  
     196 
     197   
     198  '''V. Pending issues : to be solved in 2016 ?''' 
     199 
     200'''(V.1)''' Add a proper coding of Smagorinsky eddy viscosity and diffusivity... 
     201 
     202'''(V.2)''' It should be possible to remove hdivn ... think about that 
     203 
     204  [[BR]]  '''Next Step :''' 
     205 
     206 
     207Starting from this branch, another branch is created ('''given the name here''') which will contain the following item (random order): 
     208 
     209• remove most of the remaining CPP keys (key_trabbl, key_zdf...) 
     210 
     211• vertical scale factors defined systematically in vvl case (no more substitute) 
     212 
     213• create trptra.F90 which compute the effective velocity for both TRC and TRA 
     214 
     215• create zdfmng.F90 (vertical physics manager) that allows to save MPP communications 
     216 
     217.... 
     218 
     219 
     220---- 
     221'''To be CHECKED''' (not necessary associated with this branch) 
    214222 
    215223 * check that task_i use ssmask, i.e. that it takes into account the under ice shelf seas.