Changes between Version 31 and Version 32 of ticket/1593_CNRS9_NOC3_LDF

Timestamp:

2015-10-10T12:45:05+02:00 (9 years ago)

Author:

gm

Comment:

--

ticket/1593_CNRS9_NOC3_LDF

@@ -23 +23 @@
 Three steps: [[BR]]
 
-  '''                                                             I. Phasing of horizontal scale factors                         '''                                   ===>>> OK see '''                                                revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                                   '''                                  + minor correction'''                                   revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                              (SETTE OK)'''
+  '''                                                               I. Phasing of horizontal scale factors                         '''                                     ===>>> OK see '''                                                  revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                                     '''                                    + minor correction'''                                     revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                                (SETTE OK)'''
 
 '''   (I.1)''' standardisation of the name of quantities derived from horizontal scale factors (many modules of NEMO)[[BR]]The chosen names of quantities derived from horizontal scale factors are:[[BR]]- inverse of scale factors : r1_e1t, r1_e2t, r1_e1u, r1_e2u, r1_e1v, r1_e2v, r1_e1f, r1_e2f ;[[BR]]- surfaces and their inverse:    e1e2t, e1e2u , e1e2v, e1e2f  and, r1_e1e2t , r1_e1e2u , r1_e1e2v, r1_e1e2f ;[[BR]]- ratio (used in traldf...) : e2_e1u , e1_e2v(I.1) generalize of the use of surface scale factors ;[[BR]]These quantities are defined in memory in dom_oce.F90, and set to their proper value in domhgr.F90
@@ -29 +29 @@
 '''   (I.2)''' add a optional read of surface scale factors at velocity points in coordinate file (domhgr.F90)[[BR]]   The input coordinate file have to include e1e2u and e1e2v in case of reduction of the scale factors in some straits.[[BR]]        When e1u or e2v are reduced in some straits, the surface at u- and v-points remains unchanged.[[BR]]   This allows to suppress the dom_vvl_orca_fix routine from dlmvvl.F90 module.[[BR]]''Note that this change modifies the model results'', as it contains a better handling of reduced strait width (i.e. reduced surface between 2 adjacent U or V points, but unchanged U and V points volume).[[BR]]   The implementation performed here is a first step to the full simplification of domhgr.F90. We kept here the hard coded reduction of scale factor in some straits for some given ORCA configuration. [[BR]]   A last step (see IV) will be to suppress the hard coded reduction of some scale factor as it will be always given in the coordinates.nc file together with the e1e2u & e1e2v surfaces.  ===>>> OK see '''revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5755]'''
 
-  '''         [[BR]]         [[BR]]         II. Phasing of the advective/diffusive trends on tracers'''
+  '''           [[BR]]           [[BR]]           II. Phasing of the advective/diffusive trends on tracers'''
 
 '''II.1 —''' '''LDF on tracers''' (both TRA & TRC) - Diffusive trends :    ''' '''===>>> OK see '''revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5758] &  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5759] and  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5760] with SETTE OK'''
@@ -123 +123 @@
  * Atmospheric pressure forcing: change to a systematic call of sbc_apr in step.F90 (with or without BDY) and remove its call from sbcmod[[BR]]- remove key_vectopt_loop from all the code except in domzgr_substitute.h90 (it is an obsolescent feature only adapted to vector computers)[[BR]]- remove all "!CDIR " lines = NEC vector compiler instructions
 
-  '''          [[BR]]          [[BR]]          III. Phasing of momentum trends    ''' ===>>> OK see ''' revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5777]  & [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5778]  and   [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5782]  with SETTE OK'''
+  '''            [[BR]]            [[BR]]            III. Phasing of momentum trends    '''   ===>>> OK see '''   revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5777]    & [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5778]    and   [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5782]    with SETTE OK'''
 
 '''III.1 —''' '''LDF on dynamics'''  - viscous trends
@@ -159 +159 @@
 /
 }}}
-[[BR]]- default value of the namelist: ''no operator chosen'': ln_dynldf_lap=dyndf_blp=0   ==>>>   No lateral diffusion applied on momentum[[BR]]- create the 2D and 3D ahmt and ahmf file for ORCA_R2      '''===>>>  TO BE DONE for ORCA_R1''' . nn_ahm_ijk_t must be set to -20 or -30 for ORCA2 and ORCA1 (read in a file) [[BR]]- both laplacian and bi-laplacian coef. are always 3D arrays defined at T- and F- points. Bi-laplacian eddy coefficient defined as SQRT(bhm)    [[BR]]'''                  ====>>> TO BE DONE: explore the possibility of u- and v-points'''[[BR]]- redesign of space variation of the eddy viscosity: suppression of: ldfdyn_substitute.h90 ; ldfdyn_c1d.h90 , ldfdyn_c2d.h90 and ldfdyn_c3d.h90 (replaced by ldfc1d_c2d.F90, a module share with ldftra.F90) ; ldfdyn_oce.F90 (now included in ldfdyn.F90)[[BR]]- remove ldfdyn_smag.F90 (suppression of smagorinsky option)  '''==>>> TO BE re-add in the new framework by  someone...'''[[BR]]- suppression of key_esopa in dynldf.F90[[BR]]- suppression of key_dynldf_c1d, key_dynldf_c2d, key_dynldf_c3d[[BR]]- change in all standard namelist_cfg and 1_namelist_cfg  ''' ===>>> TO BE DONE'''[[BR]]- Namelist default values : NO operator ; NO direction  ===>>> No lateral mixing applied on momentum   ===>>> must be specified in all CONFIG  '''===>>> TO BE DONE'''
+[[BR]]- default value of the namelist: ''no operator chosen'': ln_dynldf_lap=dyndf_blp=0   ==>>>   No lateral diffusion applied on momentum[[BR]]- create the 2D and 3D ahmt and ahmf file for ORCA_R2      '''===>>>  TO BE DONE for ORCA_R1''' . nn_ahm_ijk_t must be set to -20 or -30 for ORCA2 and ORCA1 (read in a file) [[BR]]- both laplacian and bi-laplacian coef. are always 3D arrays defined at T- and F- points. Bi-laplacian eddy coefficient defined as SQRT(bhm)    [[BR]]'''                  ====>>> TO BE DONE: explore the possibility of u- and v-points'''[[BR]]- redesign of space variation of the eddy viscosity: suppression of: ldfdyn_substitute.h90 ; ldfdyn_c1d.h90 , ldfdyn_c2d.h90 and ldfdyn_c3d.h90 (replaced by ldfc1d_c2d.F90, a module share with ldftra.F90) ; ldfdyn_oce.F90 (now included in ldfdyn.F90)[[BR]]- remove ldfdyn_smag.F90 (suppression of smagorinsky option)  '''==>>> TO BE re-add in the new framework by  someone...'''[[BR]]- suppression of key_esopa in dynldf.F90[[BR]]- suppression of key_dynldf_c1d, key_dynldf_c2d, key_dynldf_c3d[[BR]]- change in all standard namelist_cfg and 1_namelist_cfg [[BR]]- Namelist default values : NO operator ; NO direction  ===>>> No lateral mixing applied on momentum   ===>>> must be specified in all CONFIG
 
 '''[[BR]]III.2 —''' '''ADV on dynamics''' - advective trends : ===>>> OK see '''revision .... and ..... with SETTE OK'''
@@ -189 +189 @@
  * key_esopa has been remove from the whole NEMO code
 
-[[BR]]'''         IV. Pending issues : need to be solved before v3.7 release'''
-
-'''(IV.1) '''                                           specification of eddy viscosity/diffusivity coefficients in case of grid-size dependency.[[BR]]Issue:  define the grid-size dependency in such a way that does not require the Equator being inside the domain.[[BR]]Solution: [[BR]]'''- add''' a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain and use this scalar to compute the grid-size dependency of the coefficients. [[BR]]In addition:[[BR]]- '''add''' in NEMOGCM/TOOLS directory a program that read a coordinates.nc file apply a reduction of scale factors in some straits, and create the associated extended coordinates file (coordinates_e1e2u_v.nc)[[BR]]- '''create''' the extended coordinates files form ORCA 2°, 1°, and 0.5°. ===>>> Done for ORCA 2° and 1°,  '''1/2° and 1/4° missing...[[BR]]'''
-
-'''(IV.2) '''                                           specification of lateral friction at the coast.[[BR]]Issue:  the different values of fmask at the coast have been removed so that this lateral boundary condition doesn't affect the advective term ('''                                           double check that'''                                            !). fmask is still used for laplacian and bilaplacian viscosities. Nevertheless, the magnitude of lateral friction depends on the magnitude of ahm (bhm, reap.). It seems better to define this magnitude [[BR]]Solution: [[BR]]- '''add''' a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain and use this scalar to compute the grid-size dependency of the coefficients. 
-
-  
-  '''V. Pending issues : to be solved in 2016 ?'''
-
-'''(V.1)''' Add a proper coding of Smagorinsky eddy viscosity and diffusivity...
-
-'''(V.2)''' It should be possible to remove hdivn ... think about that
-
-  [[BR]]  '''Next Step :'''
-
+[[BR]]'''         IV. Pending issues : need to be solved before v3.7 release'''
+
+'''(IV.1) '''                                           specification of eddy viscosity/diffusivity coefficients in case of grid-size dependency.[[BR]]Issue:  define the grid-size dependency in such a way that does not require the Equator being inside the domain.[[BR]]Solution: [[BR]]'''- add''' a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain and use this scalar to compute the grid-size dependency of the coefficients. [[BR]]In addition:[[BR]]- '''add''' in NEMOGCM/TOOLS directory a program that read a coordinates.nc file apply a reduction of scale factors in some straits, and create the associated extended coordinates file (coordinates_e1e2u_v.nc)[[BR]]- '''create''' the extended coordinates files form ORCA 2°, 1°, and 0.5°. ===>>> Done for ORCA 2° and 1°,  '''1/2° and 1/4° missing...[[BR]]'''- '''explore''' the possibility of defining ahm coef. at u- and v-points.  This will improve the velocity dependent case.
+
+'''(IV.2) '''                                           specification of lateral friction at the coast.[[BR]]Issue:  the different values of fmask at the coast have been removed so that this lateral boundary condition doesn't affect the advective term ('''                                           double check that'''                                            !). fmask is still used for laplacian and bilaplacian viscosities. Nevertheless, the magnitude of lateral friction depends on the magnitude of ahm (bhm, reap.). It seems better to define this magnitude [[BR]]Solution: [[BR]]- '''add''' a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain and use this scalar to compute the grid-size dependency of the coefficients.
+
+  '''  V. Pending issues : to be solved in 2016 ?'''
+
+'''(V.1)''' Add a proper coding of Smagorinsky eddy viscosity and diffusivity...
+
+'''(V.2)''' It should be possible to remove hdivn ... think about that
+
+  [[BR]]    '''  Next Step :'''
 
 Starting from this branch, another branch is created ('''given the name here''') which will contain the following item (random order):
 
+• remove all remaining hard coded parts specific to a configuration (especially ORCA2)
+
+• ZDF simplification: introduce a vertical physics manager that allows to save MPP communications. remove avmu, avmv. remove all key_zdfxxx
+
+• create trptra.F90 which compute the effective velocity for both TRC and TRA
+
+• vertical scale factors defined systematically in vvl case (no more domzgr_substitute.h90)
+
 • remove most of the remaining CPP keys (key_trabbl, key_zdf...)
 
-• vertical scale factors defined systematically in vvl case (no more substitute)
-
-• create trptra.F90 which compute the effective velocity for both TRC and TRA
-
-• create zdfmng.F90 (vertical physics manager) that allows to save MPP communications
-
 ....
-
 
 ----