Changes between Version 34 and Version 35 of ticket/1593_CNRS9_NOC3_LDF
- Timestamp:
- 2015-10-24T10:38:24+02:00 (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
ticket/1593_CNRS9_NOC3_LDF
v34 v35 23 23 Three steps: [[BR]] 24 24 25 ''' I. Phasing of horizontal scale factors ''' ===>>> OK see ''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737] ''' + minor correction''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737](SETTE OK)'''25 ''' I. Phasing of horizontal scale factors ''' ===>>> OK see ''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737] ''' + minor correction''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737] (SETTE OK)''' 26 26 27 27 ''' (I.1)''' standardisation of the name of quantities derived from horizontal scale factors (many modules of NEMO)[[BR]]The chosen names of quantities derived from horizontal scale factors are:[[BR]]- inverse of scale factors : r1_e1t, r1_e2t, r1_e1u, r1_e2u, r1_e1v, r1_e2v, r1_e1f, r1_e2f ;[[BR]]- surfaces and their inverse: e1e2t, e1e2u , e1e2v, e1e2f and, r1_e1e2t , r1_e1e2u , r1_e1e2v, r1_e1e2f ;[[BR]]- ratio (used in traldf...) : e2_e1u , e1_e2v(I.1) generalize of the use of surface scale factors ;[[BR]]These quantities are defined in memory in dom_oce.F90, and set to their proper value in domhgr.F90 … … 29 29 ''' (I.2)''' add a optional read of surface scale factors at velocity points in coordinate file (domhgr.F90)[[BR]] The input coordinate file have to include e1e2u and e1e2v in case of reduction of the scale factors in some straits.[[BR]] When e1u or e2v are reduced in some straits, the surface at u- and v-points remains unchanged.[[BR]] This allows to suppress the dom_vvl_orca_fix routine from dlmvvl.F90 module.[[BR]]''Note that this change modifies the model results'', as it contains a better handling of reduced strait width (i.e. reduced surface between 2 adjacent U or V points, but unchanged U and V points volume).[[BR]] The implementation performed here is a first step to the full simplification of domhgr.F90. We kept here the hard coded reduction of scale factor in some straits for some given ORCA configuration. [[BR]] A last step (see IV) will be to suppress the hard coded reduction of some scale factor as it will be always given in the coordinates.nc file together with the e1e2u & e1e2v surfaces. ===>>> OK see '''revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5755]''' 30 30 31 ''' [[BR]] [[BR]]II. Phasing of the advective/diffusive trends on tracers'''31 ''' [[BR]] [[BR]] II. Phasing of the advective/diffusive trends on tracers''' 32 32 33 33 '''II.1 —''' '''LDF on tracers''' (both TRA & TRC) - Diffusive trends : ''' '''===>>> OK see '''revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5758] & [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5759] and [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5760] with SETTE OK''' … … 123 123 * Atmospheric pressure forcing: change to a systematic call of sbc_apr in step.F90 (with or without BDY) and remove its call from sbcmod[[BR]]- remove key_vectopt_loop from all the code except in domzgr_substitute.h90 (it is an obsolescent feature only adapted to vector computers)[[BR]]- remove all "!CDIR " lines = NEC vector compiler instructions 124 124 125 ''' [[BR]] [[BR]] III. Phasing of momentum trends ''' ===>>> OK see ''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5777] & [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5778] and [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5782]with SETTE OK'''125 ''' [[BR]] [[BR]] III. Phasing of momentum trends ''' ===>>> OK see ''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5777] & [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5778] and [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5782] with SETTE OK''' 126 126 127 127 '''III.1 —''' '''LDF on dynamics''' - viscous trends … … 193 193 '''•''' remove key_noslip_accurate from dom_oce.F90 and domsk.F90. 194 194 195 '''•''' 196 197 '''•''' 195 '''•''' Update the documentation. 196 197 '''•''' ensure the restartability & reproducibility for triad operator. 198 198 199 199 '''• ''' specification of eddy viscosity/diffusivity coefficients in case of grid-size dependency. … … 201 201 Issue: define the grid-size dependency in such a way that does not require the Equator being inside the domain.[[BR]]Solution: [[BR]]'''- add''' a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain and use this scalar to compute the grid-size dependency of the coefficients. [[BR]]In addition:[[BR]]- '''add''' in NEMOGCM/TOOLS directory a program that read a coordinates.nc file apply a reduction of scale factors in some straits, and create the associated extended coordinates file (coordinates_e1e2u_v.nc)[[BR]]- '''create''' the extended coordinates files form ORCA 2°, 1°, and 0.5°. ===>>> Done for ORCA 2° and 1°, '''1/2° and 1/4° missing...[[BR]]'''- '''explore''' the possibility of defining ahm coef. at u- and v-points. This will improve the velocity dependent case. 202 202 203 '''• 204 205 ''' [[BR]] [[BR]]V. Pending issues : to be solved in 2016 ?'''203 '''• '''specification of lateral friction at the coast.[[BR]]Issue: the different values of fmask at the coast have been removed so that this lateral boundary condition doesn't affect the advective term (''' double check that''' !). fmask is still used for laplacian and bilaplacian viscosities. Nevertheless, the magnitude of lateral friction depends on the magnitude of ahm (bhm, reap.). It seems better to define this magnitude [[BR]]Solution: [[BR]]- '''add''' a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain and use this scalar to compute the grid-size dependency of the coefficients. 204 205 ''' [[BR]] [[BR]] V. Pending issues : to be solved in 2016 ?''' 206 206 207 207 '''(V.1)''' Add a proper coding of Smagorinsky eddy viscosity and diffusivity... … … 209 209 '''(V.2)''' It should be possible to remove hdivn ... think about that 210 210 211 [[BR]] '''Next Step :'''211 [[BR]] ''' Next Step :''' 212 212 213 213 Starting from this branch, another branch is created ('''given the name here''') which will contain the following item (random order): … … 243 243 '''Testing''' 244 244 245 Testing could consider (where appropriate) other configurations in addition to NVTK].246 247 || NVTK Tested || !'''YES/NO!'''||248 || Other model configurations || !'''YES/NO!'''||245 Testing could consider (where appropriate) other configurations in addition to SETTE]. 246 247 || SETTE Tested || YES || 248 || Other model configurations || NO || 249 249 || Processor configurations tested || [ Enter processor configs tested here ] || 250 || If adding new functionality please confirm that the [[BR]]New code doesn't change results when it is switched off [[BR]]and !''works!'' when switched on || !'''YES/NO/NA!''' || 251 252 (Answering UNSURE is likely to generate further questions from reviewers.) 250 || If adding new functionality please confirm that the [[BR]]New code doesn't change results when it is switched off [[BR]]and !''works!'' when switched on || NO || 253 251 254 252 'Please add further summary details here' … … 258 256 259 257 === Bit Comparability === 260 || Does this change preserve answers in your tested standard configurations (to the last bit) ? || !'''YES/NO !'''||261 || Does this change bit compare across various processor configurations. (1xM, Nx1 and MxN are recommended) || !'''YES/NO!'''||262 || Is this change expected to preserve answers in all possible model configurations? || !'''YES/NO!'''||263 || Is this change expected to preserve all diagnostics? [[BR]]!,,!''Preserving answers in model runs does not necessarily imply preserved diagnostics. !'' || !'''YES/NO!'''||258 || Does this change preserve answers in your tested standard configurations (to the last bit) ? || NO || 259 || Does this change bit compare across various processor configurations. (1xM, Nx1 and MxN are recommended) || YES || 260 || Is this change expected to preserve answers in all possible model configurations? || YES || 261 || Is this change expected to preserve all diagnostics? [[BR]]!,,!''Preserving answers in model runs does not necessarily imply preserved diagnostics. !'' || YES || 264 262 265 263 If you answered !'''NO!''' to any of the above, please provide further details: 266 264 267 * Which routine(s) are causing the difference? 268 * Why the changes are not protected by a logical switch or new section-version 265 * Which routine(s) are causing the difference? all LDF and DYN/TRA advection/diffusion modules 266 * Why the changes are not protected by a logical switch or new section-version : changes affect the deep kernel of the code 269 267 * What is needed to achieve regression with the previous model release (e.g. a regression branch, hand-edits etc). If this is not possible, explain why not. 270 268 * What do you expect to see occur in the test harness jobs? … … 273 271 ---- 274 272 === System Changes === 275 || Does your change alter namelists? || !'''YES/NO !'''||276 || Does your change require a change in compiler options? || !'''YES/NO !'''||277 278 If any of these apply, please document the changes required here .......273 || Does your change alter namelists? || YES || 274 || Does your change require a change in compiler options? || NO || 275 276 If any of these apply, please document the changes required here : see above in '''Description''' 279 277 280 278 ---- 281 279 === Resources === 282 !''Please !''summarize!'' any changes in runtime or memory use caused by this change......!'' 280 !''Please !''summarize!'' any changes in runtime or memory use caused by this change......!'' :-) 283 281 284 282 ----
