New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
ticket/1593_CNRS9_NOC3_LDF (diff) – NEMO

Changes between Version 40 and Version 41 of ticket/1593_CNRS9_NOC3_LDF


Ignore:
Timestamp:
2015-10-25T12:00:04+01:00 (8 years ago)
Author:
gm
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • ticket/1593_CNRS9_NOC3_LDF

    v40 v41  
    2323Three steps: [[BR]] 
    2424 
    25   '''                                                                           I. Phasing of horizontal scale factors                         '''                                                 ===>>> OK see '''                                                              revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                                                 '''                                                + minor correction'''                                                 revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                                            (SETTE OK)''' 
     25  '''                                                                            I. Phasing of horizontal scale factors                         '''                                                  ===>>> OK see '''                                                               revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                                                  '''                                                 + minor correction'''                                                  revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                                             (SETTE OK)''' 
    2626 
    2727'''   (I.1)''' standardisation of the name of quantities derived from horizontal scale factors (many modules of NEMO)[[BR]]The chosen names of quantities derived from horizontal scale factors are:[[BR]]- inverse of scale factors : r1_e1t, r1_e2t, r1_e1u, r1_e2u, r1_e1v, r1_e2v, r1_e1f, r1_e2f ;[[BR]]- surfaces and their inverse:    e1e2t, e1e2u , e1e2v, e1e2f  and, r1_e1e2t , r1_e1e2u , r1_e1e2v, r1_e1e2f ;[[BR]]- ratio (used in traldf...) : e2_e1u , e1_e2v(I.1) generalize of the use of surface scale factors ;[[BR]]These quantities are defined in memory in dom_oce.F90, and set to their proper value in domhgr.F90 
     
    2929'''   (I.2)''' add a optional read of surface scale factors at velocity points in coordinate file (domhgr.F90)[[BR]]   The input coordinate file have to include e1e2u and e1e2v in case of reduction of the scale factors in some straits.[[BR]]        When e1u or e2v are reduced in some straits, the surface at u- and v-points remains unchanged.[[BR]]   This allows to suppress the dom_vvl_orca_fix routine from dlmvvl.F90 module.[[BR]]''Note that this change modifies the model results'', as it contains a better handling of reduced strait width (i.e. reduced surface between 2 adjacent U or V points, but unchanged U and V points volume).[[BR]]   The implementation performed here is a first step to the full simplification of domhgr.F90. We kept here the hard coded reduction of scale factor in some straits for some given ORCA configuration. [[BR]]   A last step (see IV) will be to suppress the hard coded reduction of some scale factor as it will be always given in the coordinates.nc file together with the e1e2u & e1e2v surfaces.  ===>>> OK see '''revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5755]''' 
    3030 
    31   '''                       [[BR]]                       [[BR]]                       II. Phasing of the advective/diffusive trends on tracers''' 
     31  '''                        [[BR]]                        [[BR]]                        II. Phasing of the advective/diffusive trends on tracers''' 
    3232 
    3333'''II.1 —''' '''LDF on tracers''' (both TRA & TRC) - Diffusive trends :    ''' '''===>>> OK see '''revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5758] &  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5759] and  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5760] with SETTE OK''' 
     
    121121'''[[BR]]II.3''' '''Miscellaneous :''' 
    122122 
    123  * Atmospheric pressure forcing: change to a systematic call of sbc_apr in step.F90 (with or without BDY) and remove its call from sbcmod[[BR]]- remove key_vectopt_loop from all the code except in domzgr_substitute.h90 (it is an obsolescent feature only adapted to vector computers)[[BR]]- remove all "!CDIR " lines = NEC vector compiler instructions 
    124  
    125   '''                        [[BR]]                        [[BR]]                        III. Phasing of momentum trends    '''               ===>>> OK see '''               revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5777 5777]                & [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5778 5778]                and   [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5782 5782]                with SETTE OK''' 
     123 * Atmospheric pressure forcing: change to a systematic call of sbc_apr in step.F90 (with or without BDY) and remove its call from sbcmod 
     124 * remove key_vectopt_loop from all the code except in vectopt_loop_substitute.h90 (it is an obsolescent feature only adapted to vector computers) 
     125 * remove all "!CDIR " lines = NEC vector compiler instructions 
     126 
     127  '''                         [[BR]]                         [[BR]]                         III. Phasing of momentum trends    '''                ===>>> OK see '''                revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5777 5777]                 & [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5778 5778]                 and   [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5782 5782]                 with SETTE OK''' 
    126128 
    127129'''III.1 —''' '''LDF on dynamics'''  - viscous trends 
     
    190192 * remove ll_is_orca and its associated use in domvvl.F90 (no used anymore)  '''DONE see rev'''.''' [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5829 5829]''' 
    191193 * remove ttrdmp & strdmp arrays (not used anymore)     '''DONE see rev'''.''' [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5830 5830]''' 
    192  * remove the remaining use of ua,va as workspace (changes in trazdf_imp.F90, zdfevd.F90, zdftmx.F90 and oce_trc.F90)   '''DONE see rev'''.''' [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5831 5831]''' 
     194 * remove the remaining use of ua,va as workspace (changes in trazdf_imp.F90, zdfevd.F90, zdftmx.F90 and oce_trc.F90)   '''DONE see rev'''.''' [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5831 5831]''' 
    193195 
    194196[[BR]]'''         IV. Pending issues : need to be solved before v3.7 release''' 
     
    204206'''• '''specification of lateral friction at the coast.[[BR]]Issue:  the different values of fmask at the coast have been removed so that this lateral boundary condition doesn't affect the advective term ('''                                           double check that'''                                            !). fmask is still used for laplacian and bilaplacian viscosities. Nevertheless, the magnitude of lateral friction depends on the magnitude of ahm (bhm, reap.). It seems better to define this magnitude [[BR]]Solution: [[BR]]- '''add''' a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain and use this scalar to compute the grid-size dependency of the coefficients. 
    205207 
    206   '''          [[BR]]              [[BR]]          V. Pending issues : to be solved in 2016 ?''' 
     208  '''           [[BR]]               [[BR]]           V. Pending issues : to be solved in 2016 ?''' 
    207209 
    208210'''(V.1)''' Add a proper coding of Smagorinsky eddy viscosity and diffusivity... 
     
    210212'''(V.2)''' It should be possible to remove hdivn ... think about that 
    211213 
    212   [[BR]]                '''              Next Step :''' 
     214  [[BR]]                 '''               Next Step :''' 
    213215 
    214216Starting from this branch, another branch is created ('''given the name here''') which will contain the following item (random order):