Changes between Version 43 and Version 44 of ticket/1593_CNRS9_NOC3_LDF


Ignore:
Timestamp:
2015-10-31T06:42:54+01:00 (5 years ago)
Author:
gm
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • ticket/1593_CNRS9_NOC3_LDF

    v43 v44  
    1010 
    1111---- 
    12 === Description === 
     12= Description = 
    1313Development branch related to CNRS-9 and NOC-3 actions of 2015 work plan :[[BR]]        • simplify and improve the tracer advection and the lateral diffusion and dissipation in NEMO/OPA[[BR]]        • generalization of the use of surface scale factors (e1e2 at T, U, V, F points) 
    1414 
     
    2020 
    2121---- 
    22 === Strategy === 
     22= Strategy = 
    2323Three steps: [[BR]] 
    2424 
    25   '''                                                                                I. Phasing of horizontal scale factors                         '''                                                      ===>>> OK see '''                                                                   revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                                                      '''                                                     + minor correction'''                                                      revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                                                 (SETTE OK)''' 
    26  
    27 '''   (I.1)''' standardisation of the name of quantities derived from horizontal scale factors (many modules of NEMO)[[BR]]The chosen names of quantities derived from horizontal scale factors are:[[BR]]- inverse of scale factors : r1_e1t, r1_e2t, r1_e1u, r1_e2u, r1_e1v, r1_e2v, r1_e1f, r1_e2f ;[[BR]]- surfaces and their inverse:    e1e2t, e1e2u , e1e2v, e1e2f  and, r1_e1e2t , r1_e1e2u , r1_e1e2v, r1_e1e2f ;[[BR]]- ratio (used in traldf...) : e2_e1u , e1_e2v(I.1) generalize of the use of surface scale factors ;[[BR]]These quantities are defined in memory in dom_oce.F90, and set to their proper value in domhgr.F90 
    28  
    29 '''   (I.2)''' add a optional read of surface scale factors at velocity points in coordinate file (domhgr.F90)[[BR]]   The input coordinate file have to include e1e2u and e1e2v in case of reduction of the scale factors in some straits.[[BR]]        When e1u or e2v are reduced in some straits, the surface at u- and v-points remains unchanged.[[BR]]   This allows to suppress the dom_vvl_orca_fix routine from dlmvvl.F90 module.[[BR]]''Note that this change modifies the model results'', as it contains a better handling of reduced strait width (i.e. reduced surface between 2 adjacent U or V points, but unchanged U and V points volume).[[BR]]   The implementation performed here is a first step to the full simplification of domhgr.F90. We kept here the hard coded reduction of scale factor in some straits for some given ORCA configuration. [[BR]]   A last step (see IV) will be to suppress the hard coded reduction of some scale factor as it will be always given in the coordinates.nc file together with the e1e2u & e1e2v surfaces.  ===>>> OK see '''revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5755]''' 
    30  
    31   '''                            [[BR]]                            [[BR]]                            II. Phasing of the advective/diffusive trends on tracers''' 
    32  
    33 '''II.1 —''' '''LDF on tracers''' (both TRA & TRC) - Diffusive trends :    ''' '''===>>> OK see '''revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5758] &  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5759] and  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5760] with SETTE OK''' 
    34  
    35 '''       ====>>>> Bug in triad operator TO BE CHECKED'''[[BR]]                            triad operator is neither restartable not repro  in the branche (it was the case in v3.6 stable) 
     25== I. Phasing of horizontal scale factors == 
     26  ===>>> '''     OK'''      see revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                                                            '''                                                           + minor correction'''                                                            revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                                                       (SETTE OK) 
     27 
     28=== (I.1)  standardisation of the name === 
     29The chosen names of quantities derived from horizontal scale factors are:[[BR]] - inverse of scale factors : r1_e1t, r1_e2t, r1_e1u, r1_e2u, r1_e1v, r1_e2v, r1_e1f, r1_e2f ;[[BR]] - surfaces and their inverse:    e1e2t, e1e2u , e1e2v, e1e2f  and, r1_e1e2t , r1_e1e2u , r1_e1e2v, r1_e1e2f ;[[BR]] - ratio (used in traldf...) : e2_e1u , e1_e2v(I.1) generalize of the use of surface scale factors ;[[BR]] These quantities are defined in memory in dom_oce.F90, and set to their proper value in domhgr.F90 
     30 
     31=== (I.2) domhgr: add a optional read of surface scale factors === 
     32  An optional read of surface scale factors at velocity points ( e1e2u and e1e2v) is needed in coordinate file. Indeed, in case of reduction of a scale factor (e1u or e2v) in a strait, the surface at u- and v-points must remain unchanged.[[BR]]       This allows to suppress the dom_vvl_orca_fix routine from dlmvvl.F90 module.[[BR]]    ''    Note that this change modifies the model results''    , as it contains a better handling of reduced strait width (i.e. reduced face between 2 adjacent T-points, but unchanged U and V points volume).[[BR]]       The implementation performed here is a first step to the full simplification of domhgr.F90. We kept here the hard coded reduction of scale factor in some straits for some given ORCA configuration. [[BR]]       A last step (see IV) will be to suppress the hard coded reduction of some scale factor as it will be always given in the coordinates.nc file together with the e1e2u & e1e2v surfaces.  ===>>> OK see '''    revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5755]    ''' 
     33 
     34== [[BR]][[BR]]II. Phasing of the advective/diffusive trends on tracers == 
     35=== II.1 —''' '''LDF on tracers''' (both TRA & TRC) - Diffusive trends''' === 
     36  ===>>> '''  OK'''   see revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5758]    &  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5759]    and  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5760]    with SETTE OK 
     37 
     38  '''  ====>>>> Bug in triad operator TO BE CHECKED'''  [[BR]]    triad operator is neither restartable not repro  in the branche (it was the case in v3.6 stable) 
    3639 
    3740''operator'': [[BR]]- laplacian operator: re-entrant laplacian for iso-level, standard iso-neutral, and triad iso-neutral operators ;[[BR]]- bilaplacian operator: traldf_blp.F90 module: use of the re-entrant laplacian [[BR]]- both standard and triad iso-neutral operators includes  the Method of Stabilizing Correction (Lemarié et al. (2012) which allows bilaplacian along iso-neutral surfaces ;[[BR]]- triad operator: introduce Beckers et al. (2000) compact stencil in the cross-isoneutral direction ; make the triad operator available in TOP[[BR]]- change name:  traldf_iso_grif.F90 becomes traldf_iso_triad.F90[[BR]]- suppression of traadv_eiv.F90 ; traldf_bilap.F90 ; traldf_bilapg.F90 ;[[BR]]- remove the possibility to compute the lateral diffusion from T-S anomalies (key_traldf_ano) 
     
    8689/ 
    8790}}} 
    88 [[BR]]- default value of the namelist: ''no operator chosen'': lln_traldf_lap=traldf_blp=0 No lateral diffusion applied on tracers '''  ===>>> CHECK THAT'''[[BR]]-  bi-laplacian eddy coefficient defined as SQRT(bhm)[[BR]]- ah and bh coefficients defined only at u- and v-points.[[BR]]- redesign the management of eddy induced velocity and its associated diagnostics. In particular ldfeiv.F90 and ldfeiv_substitute.h90 has been suppressed (ldf_eiv routine is now included in ldftra.F90) [[BR]]- redesign of space variation of the eddy diffusivity: suppression of: ldftra_substitute.h90  ; ldftra_c1d.h90 , ldftra_c2d.h90 and  ldftra_c3d.h90 (replaced by ldfc1d_c2d.F90, a module share with ldftra.F90) ; ldftra_oce.F90 (now included in ldftra.F90) [[BR]]- remove ldftra_smag.F90 (suppression of smagorinski option)  '''==>>> TO BE re-add in the new framework by someone...[[BR]]'''- suppression of cpp keys : key_ldfslp ; ''key_traldf_c1d ; key_traldf_c2d ; key_traldf_c3d ; ''key_diaeiv ; key_traldf_eiv ; key_traldf_eiv ; key_traldf_ano[[BR]]- suppression of key_esopa in traldf.F90[[BR]]- zpshde.F90 correct an issue with position of optional argument in zps_hde_isf routine[[BR]]- change in all standard namelist_cfg and 1_namelist_cfg 
     91[[BR]]- default value of the namelist: ''no operator chosen'': lln_traldf_lap=traldf_blp=0 No lateral diffusion applied on tracers.[[BR]]-  bi-laplacian eddy coefficient defined as SQRT(bhm)[[BR]]- ah and bh coefficients defined only at u- and v-points.[[BR]]- redesign the management of eddy induced velocity and its associated diagnostics. In particular ldfeiv.F90 and ldfeiv_substitute.h90 has been suppressed (ldf_eiv routine is now included in ldftra.F90) [[BR]]- redesign of space variation of the eddy diffusivity: suppression of: ldftra_substitute.h90  ; ldftra_c1d.h90 , ldftra_c2d.h90 and  ldftra_c3d.h90 (replaced by ldfc1d_c2d.F90, a module share with ldftra.F90) ; ldftra_oce.F90 (now included in ldftra.F90) [[BR]]- remove ldftra_smag.F90 (suppression of smagorinski option)  '''==>>> TO BE re-add in the new framework by someone...[[BR]]'''- suppression of cpp keys : key_ldfslp ; ''key_traldf_c1d ; key_traldf_c2d ; key_traldf_c3d ; ''key_diaeiv ; key_traldf_eiv ; key_traldf_eiv ; key_traldf_ano[[BR]]- suppression of key_esopa in traldf.F90[[BR]]- zpshde.F90 correct an issue with position of optional argument in zps_hde_isf routine[[BR]]- change in all standard namelist_cfg and 1_namelist_cfg 
    8992 
    9093''passive tracers''[[BR]]- all changes in the management of diffusive coefficients and operator has been taken into account in TOP[[BR]]- change in all standard namelist_top_cfg 
    9194 
    92 '''Pending issues''' : [[BR]]- verify diaptr.F90  : not sure it is OK[[BR]]- add the max grid size in the coordinate file and use it to compute grid dependent diffusivity. This will solve an issue with regional and AGRIF configurations[[BR]]- test all 6 operators.[[BR]]- change default option in the namelist ! [[BR]]- In field_def.xml  add a comment to say where is the routine calling the corresponding iom_put[[BR]]- in the documentation, add a change in the DOCTOR norm: np_ is now a prefix used for PARAMETER 
    93  
    94 '''[[BR]]II.2 —''' '''Advective trends''' :TRA/traadv....     ===>>> OK see '''revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5770] &  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5771]   ===>> SETTE OK with revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5774] &  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5775]''' 
     95'''Pending issues''' : [[BR]]- verify diaptr.F90  : not sure it is OK[[BR]]- add the max grid size in the coordinate file and use it to compute grid dependent diffusivity. This will solve an issue with regional and AGRIF configurations[[BR]]- test all 6 operators.[[BR]]- In field_def.xml  add a comment to say where is the routine calling the corresponding iom_put[[BR]]- in the documentation, add a change in the DOCTOR norm: np_ is now a prefix used for PARAMETER 
     96 
     97=== [[BR]]II.2 — Advective trends (TRA/traadv....) === 
     98  ===>>> ''' OK'''  see revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5770]  &  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5771]    ===>> SETTE OK with revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5774]  &  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5775] 
    9599 
    96100 * traadv_muscl2.F90  removed[[BR]]- traadv_muscl.F90 renamed traadv_mus.F90[[BR]]- traadv_cen2.F90  replaced by traadv_cen which provides 2nd and 4th order centered scheme on both horizontal and vertical directions.[[BR]]- name TVD has been changed to the more commonly used FCT (Flux Correction Transport)[[BR]]- FCT offers now 2nd and 4th order centered scheme on both horizontal and vertical directions.[[BR]]- UBS offers now in option either a 2nd order FCT or a 4th order COMPACT scheme in the vertical direction[[BR]]- NB in case of 4th order in the vertical, CEN, UBS and FCT use a compact 4th order scheme[[BR]]- key_esopa removed from traadv.F90 
     
    119123'''Unresolved issues/improvement''' on TRAADV: [[BR]]- QCK: cross terms are missing. alternate direction should be added....[[BR]]- Bug in FCT with sub-time-stepping and key_vvl. The change in e3 should be taken into account in the sub-timesteps.[[BR]]- traadv_mus.F90   some rather simple optimization can be added...[[BR]]- traadv_qck.F90 : possibility to add a 4th order COMPACT scheme on the vertical. [[BR]]- 4th order COMPACT doesn't work with ISF   the routine have to be modified 
    120124 
    121 '''[[BR]]II.3''' '''Miscellaneous :''' 
    122  
     125=== [[BR]]II.3 — Miscellaneous === 
    123126 * Atmospheric pressure forcing: change to a systematic call of sbc_apr in step.F90 (with or without BDY) and remove its call from sbcmod 
    124127 * remove key_vectopt_loop from all the code except in vectopt_loop_substitute.h90 (it is an obsolescent feature only adapted to vector computers) 
    125128 * remove all "!CDIR " lines = NEC vector compiler instructions 
    126129 
    127   '''                             [[BR]]                             [[BR]]                             III. Phasing of momentum trends    '''                    ===>>> OK see '''                    revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5777 5777]                     & [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5778 5778]                     and   [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5782 5782]                     with SETTE OK''' 
    128  
    129 '''III.1 —''' '''LDF on dynamics'''  - viscous trends 
    130  
     130== [[BR]][[BR]][[BR]]III. Phasing of momentum trends == 
     131  ===>>> ''' OK'''  see revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5777 5777]                                   & [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5778 5778]                                   and   [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5782 5782]                                   with SETTE OK 
     132 
     133=== [[BR]]III.1 — LDF on dynamics  - viscous trends === 
    131134''operator'': [[BR]]- laplacian operator: re-entrant laplacian for iso-level operators (routine dyn_ldf_lap found in dynldf_lap_blp);[[BR]]- bilaplacian operator: dynldf_blp.F90 module: use of the re-entrant iso-level laplacian (routine dyn_ldf_blp found in dynldf_lap_blp.F90)[[BR]]- suppression of dynnept.F90  to finalize the suppression of Neptune effect param. ;[[BR]]- suppression of dynldf_lap.F90 and dynldf_bilap.F90 replaced by dynldf_lap_blp.F90 (which contains dyn_ldf_lap & dyn_ldf_blp routines) ; dynldf_bilapg.F90 (remove old and approximative rotated bi-laplacian on momentum)[[BR]]- rotb and rotn arrays suppressed (even from the restart file) NB: the viscous operator now uses the full before velocity field (i.e. including the asselin filter)[[BR]]- hdivb array is suppressed. hdivn and hdivb are removed from restart[[BR]]- associate with rotn and rotb suppression comes the suppression of no-slip accurate option (key_noslip_accurate is removed)[[BR]]- divcur.F90 becomes divhor.F90 and only computes the horizontal divergence 
    132135 
     
    163166[[BR]]- default value of the namelist: ''no operator chosen'': ln_dynldf_lap=dyndf_blp=0   ==>>>   No lateral diffusion applied on momentum[[BR]]- create the 2D and 3D ahmt and ahmf file for ORCA_R2      '''===>>>  TO BE DONE for ORCA_R1''' . nn_ahm_ijk_t must be set to -20 or -30 for ORCA2 and ORCA1 (read in a file) [[BR]]- both laplacian and bi-laplacian coef. are always 3D arrays defined at T- and F- points. Bi-laplacian eddy coefficient defined as SQRT(bhm)    [[BR]]'''                  ====>>> TO BE DONE: explore the possibility of u- and v-points'''[[BR]]- redesign of space variation of the eddy viscosity: suppression of: ldfdyn_substitute.h90 ; ldfdyn_c1d.h90 , ldfdyn_c2d.h90 and ldfdyn_c3d.h90 (replaced by ldfc1d_c2d.F90, a module share with ldftra.F90) ; ldfdyn_oce.F90 (now included in ldfdyn.F90)[[BR]]- remove ldfdyn_smag.F90 (suppression of smagorinsky option)  '''==>>> TO BE re-add in the new framework by  someone...'''[[BR]]- suppression of key_esopa in dynldf.F90[[BR]]- suppression of key_dynldf_c1d, key_dynldf_c2d, key_dynldf_c3d[[BR]]- change in all standard namelist_cfg and 1_namelist_cfg [[BR]]- Namelist default values : NO operator ; NO direction  ===>>> No lateral mixing applied on momentum   ===>>> must be specified in all CONFIG 
    164167 
    165 '''[[BR]]III.2 —''' '''ADV on dynamics''' - advective trends : ===>>> OK see '''revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5778 5778]''' and  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5786 5786]with SETTE OK 
     168=== [[BR]]III.2 —''' '''ADV on dynamics''' - advective trends''' === 
     169  ===>>> ''' OK'''  see revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5778 5778]  and  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5786 5786] with SETTE OK 
    166170 
    167171''dynvor.F90 (impact also dynspg_ts.F90)''[[BR]]                   - remove key_esopa[[BR]]                   - remove dyn_vor_mix : now successive call of den_vor_ene (Coriolis) and din_vor_ens (relative voricity)[[BR]]                   - replace rotn by its calculation everywhere in dynvor.F90[[BR]]                   - remove the use of fmask from standard vorticity calculation in dynvor.F90 but add a namelist parameter (ln_dynvor_msk) to multiply by fmask the vorticity term[[BR]]- add an namelist option to mask or not the vorticity (including Coriolis) '''CAUTION''' : the mask option does not work: set to FALSE by default with comment DO NOT set it to TRUE  (see '''  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5827 5827]''' )[[BR]]- change ln_dynvor_een_old into nn_een_e3f = 0/1 
     
    185189namlist_ref and all CONFIG namelists updated 
    186190 
    187 '''[[BR]]II.3''' '''Miscellaneous :''' 
    188  
    189  * key_esopa has been remove from the whole NEMO code ''' '''DONE see rev'''. [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5778 5778]''' 
    190  * remove key_noslip_accurate from dom_oce.F90 and domsk.F90. '''DONE see rev'''.''' [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5829 5829]''' 
    191  * remove duplicate print of "W A R N I N G" and "E R R O R" in ctl_nam routine  '''DONE see rev'''.''' [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5829 5829]''' 
    192  * remove ll_is_orca and its associated use in domvvl.F90 (no used anymore)  '''DONE see rev'''.''' [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5829 5829]''' 
     191=== [[BR]]III.3 Miscellaneous === 
     192 * key_esopa has been remove from the whole NEMO code '''DONE''' see rev. [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5778 5778] 
     193 * remove key_noslip_accurate from dom_oce.F90 and domsk.F90. '''DONE''' see rev. [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5829 5829] 
     194 * remove duplicate print of "W A R N I N G" and "E R R O R" in ctl_nam routine  '''DONE''' see rev. [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5829 5829] 
     195 * remove ll_is_orca and its associated use in domvvl.F90 (no used anymore)  '''DONE''' see rev [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5829 5829] 
    193196 * remove ttrdmp & strdmp arrays (not used anymore)     '''DONE see rev'''.''' [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5830 5830]''' 
    194  * remove the remaining use of ua,va as workspace (changes in trazdf_imp.F90, zdfevd.F90, zdftmx.F90 and oce_trc.F90)   '''DONE see rev'''.''' [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5831 5831]''' 
    195  
    196 [[BR]]'''         IV. Pending issues : need to be solved before v3.7 release''' 
    197  
     197 * remove the remaining use of ua,va as workspace (changes in trazdf_imp.F90, zdfevd.F90, zdftmx.F90 and oce_trc.F90)   '''DONE''' see rev. [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5831 5831] 
     198 
     199== [[BR]]IV. Pending issues : need to be solved before v3.7 release == 
    198200'''•''' Update the documentation. 
    199201 
    200202'''•''' ensure the restartability & reproducibility for triad operator. 
    201203 
    202 '''• '''                                           specification of eddy viscosity/diffusivity coefficients in case of grid-size dependency. 
     204'''• ''' specification of eddy viscosity/diffusivity coefficients in case of grid-size dependency. 
    203205 
    204206Issue:  define the grid-size dependency in such a way that does not require the Equator being inside the domain.[[BR]]Solution: [[BR]]'''- add''' a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain and use this scalar to compute the grid-size dependency of the coefficients. [[BR]]In addition:[[BR]]- '''add''' in NEMOGCM/TOOLS directory a program that read a coordinates.nc file apply a reduction of scale factors in some straits, and create the associated extended coordinates file (coordinates_e1e2u_v.nc)[[BR]]- '''create''' the extended coordinates files form ORCA 2°, 1°, and 0.5°. ===>>> Done for ORCA 2° and 1°,  '''1/2° and 1/4° missing...[[BR]]'''- '''explore''' the possibility of defining ahm coef. at u- and v-points.  This will improve the velocity dependent case. 
    205207 
    206 '''• '''specification of lateral friction at the coast.[[BR]]Issue:  the different values of fmask at the coast have been removed so that this lateral boundary condition doesn't affect the advective term ('''                                           double check that'''                                            !). fmask is still used for laplacian and bilaplacian viscosities. Nevertheless, the magnitude of lateral friction depends on the magnitude of ahm (bhm, reap.). It seems better to define this magnitude [[BR]]Solution:  
    207  
    208   '''                   [[BR]]               V. Pending issues : to be solved in 2016 ?''' 
    209  
     208'''• '''specification of lateral friction at the coast.[[BR]]Issue:  the different values of fmask at the coast have been removed so that this lateral boundary condition doesn't affect the advective term ('''                                           double check that'''                                            !). fmask is still used for laplacian and bilaplacian viscosities. Nevertheless, the magnitude of lateral friction depends on the magnitude of ahm (bhm, reap.). It seems better to define this magnitude [[BR]]Solution: 
     209 
     210== [[BR]][[BR]]V. Pending issues : to be solved in 2016 ? == 
    210211'''(V.1)''' Add a proper coding of Smagorinsky eddy viscosity and diffusivity... 
    211212 
    212213'''(V.2)''' It should be possible to remove hdivn ... think about that 
    213214 
    214   [[BR]]                     '''                   Next Step :''' 
     215  [[BR]]                                   '''                                 Next Step :''' 
    215216 
    216217Starting from this branch, another branch is created ('''given the name here''') which will contain the following item (random order): 
     
    243244 
    244245---- 
    245 '''Testing''' 
    246  
    247 Testing could consider (where appropriate) other configurations in addition to SETTE]. 
    248  
    249 || SETTE Tested || YES || 
    250 || Other model configurations || NO || 
    251 || Processor configurations tested || [ Enter processor configs tested here ] || 
    252 || If adding new functionality please confirm that the [[BR]]New code doesn't change results when it is switched off [[BR]]and !''works!'' when switched on || NO || 
    253  
    254 'Please add further summary details here' 
    255  
    256  * Processor configurations tested 
    257  * etc---- 
    258  
    259 === Bit Comparability === 
    260 || Does this change preserve answers in your tested standard configurations (to the last bit) ? || NO || 
    261 || Does this change bit compare across various processor configurations. (1xM, Nx1 and MxN are recommended) || YES || 
    262 || Is this change expected to preserve answers in all possible model configurations? || YES || 
    263 || Is this change expected to preserve all diagnostics? [[BR]]!,,!''Preserving answers in model runs does not necessarily imply preserved diagnostics. !'' || YES || 
    264  
    265 If you answered !'''NO!''' to any of the above, please provide further details: 
    266  
    267  * Which routine(s) are causing the difference?   all LDF and DYN/TRA advection/diffusion modules 
    268  * Why the changes are not protected by a logical switch or new section-version : changes affect the deep kernel of the code 
    269  * What is needed to achieve regression with the previous model release (e.g. a regression branch, hand-edits etc). If this is not possible, explain why not. 
    270  * What do you expect to see occur in the test harness jobs? 
    271  * Which diagnostics have you altered and why have they changed?Please add details here........ 
    272  
    273 ---- 
    274 === System Changes === 
    275 || Does your change alter namelists? || YES || 
    276 || Does your change require a change in compiler options? || NO || 
    277  
    278 If any of these apply, please document the changes required here : see above in '''Description''' 
    279  
    280 ---- 
    281 === Resources === 
    282 !''Please !''summarize!'' any changes in runtime or memory use caused by this change......!''      :-) 
    283  
    284 ---- 
    285 === IPR issues === 
    286 || Has the code been wholly (100%) produced by NEMO developers staff working exclusively on NEMO? || !'''YES/ NO !''' || 
    287  
    288 If No: 
    289  
    290  * Identify the collaboration agreement details 
    291  * Ensure the code routine header is in accordance with the agreement, (Copyright/Redistribution etc).Add further details here if required..........