Changes between Version 44 and Version 45 of ticket/1593_CNRS9_NOC3_LDF


Ignore:
Timestamp:
2015-10-31T06:56:54+01:00 (5 years ago)
Author:
gm
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • ticket/1593_CNRS9_NOC3_LDF

    v44 v45  
    88 
    99'''WP2015 Action''' : CNRS-9 and NOC-3 
     10 
     11'''===>>>   NOW''' moved on the '''trunk''' (revision: [https://forge.ipsl.jussieu.fr/nemo/log/trunk/NEMOGCM?rev=5838 ​5836]) 
    1012 
    1113---- 
     
    2426 
    2527== I. Phasing of horizontal scale factors == 
    26   ===>>> '''     OK'''      see revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                                                            '''                                                           + minor correction'''                                                            revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                                                       (SETTE OK) 
     28  ===>>> '''       OK'''        see revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                                                              '''                                                             + minor correction'''                                                              revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737]                                                         (SETTE OK) 
    2729 
    2830=== (I.1)  standardisation of the name === 
     
    3032 
    3133=== (I.2) domhgr: add a optional read of surface scale factors === 
    32   An optional read of surface scale factors at velocity points ( e1e2u and e1e2v) is needed in coordinate file. Indeed, in case of reduction of a scale factor (e1u or e2v) in a strait, the surface at u- and v-points must remain unchanged.[[BR]]       This allows to suppress the dom_vvl_orca_fix routine from dlmvvl.F90 module.[[BR]]    ''    Note that this change modifies the model results''    , as it contains a better handling of reduced strait width (i.e. reduced face between 2 adjacent T-points, but unchanged U and V points volume).[[BR]]       The implementation performed here is a first step to the full simplification of domhgr.F90. We kept here the hard coded reduction of scale factor in some straits for some given ORCA configuration. [[BR]]       A last step (see IV) will be to suppress the hard coded reduction of some scale factor as it will be always given in the coordinates.nc file together with the e1e2u & e1e2v surfaces.  ===>>> OK see '''    revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5755]    ''' 
     34  An optional read of surface scale factors at velocity points ( e1e2u and e1e2v) is needed in coordinate file. Indeed, in case of reduction of a scale factor (e1u or e2v) in a strait, the surface at u- and v-points must remain unchanged.[[BR]]         This allows to suppress the dom_vvl_orca_fix routine from dlmvvl.F90 module.[[BR]]      ''      Note that this change modifies the model results''      , as it contains a better handling of reduced strait width (i.e. reduced face between 2 adjacent T-points, but unchanged U and V points volume).[[BR]]         The implementation performed here is a first step to the full simplification of domhgr.F90. We kept here the hard coded reduction of scale factor in some straits for some given ORCA configuration. [[BR]]         A last step (see IV) will be to suppress the hard coded reduction of some scale factor as it will be always given in the coordinates.nc file together with the e1e2u & e1e2v surfaces.  ===>>> OK see '''      revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5755]      ''' 
    3335 
    3436== [[BR]][[BR]]II. Phasing of the advective/diffusive trends on tracers == 
    3537=== II.1 —''' '''LDF on tracers''' (both TRA & TRC) - Diffusive trends''' === 
    36   ===>>> '''  OK'''   see revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5758]    &  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5759]    and  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5760]    with SETTE OK 
    37  
    38   '''  ====>>>> Bug in triad operator TO BE CHECKED'''  [[BR]]    triad operator is neither restartable not repro  in the branche (it was the case in v3.6 stable) 
     38  ===>>> '''    OK'''     see revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5758]      &  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5759]      and  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5760]      with SETTE OK 
     39 
     40  '''    ====>>>> Bug in triad operator TO BE CHECKED'''    [[BR]]      triad operator is neither restartable not repro  in the branche (it was the case in v3.6 stable) 
    3941 
    4042''operator'': [[BR]]- laplacian operator: re-entrant laplacian for iso-level, standard iso-neutral, and triad iso-neutral operators ;[[BR]]- bilaplacian operator: traldf_blp.F90 module: use of the re-entrant laplacian [[BR]]- both standard and triad iso-neutral operators includes  the Method of Stabilizing Correction (Lemarié et al. (2012) which allows bilaplacian along iso-neutral surfaces ;[[BR]]- triad operator: introduce Beckers et al. (2000) compact stencil in the cross-isoneutral direction ; make the triad operator available in TOP[[BR]]- change name:  traldf_iso_grif.F90 becomes traldf_iso_triad.F90[[BR]]- suppression of traadv_eiv.F90 ; traldf_bilap.F90 ; traldf_bilapg.F90 ;[[BR]]- remove the possibility to compute the lateral diffusion from T-S anomalies (key_traldf_ano) 
     
    9698 
    9799=== [[BR]]II.2 — Advective trends (TRA/traadv....) === 
    98   ===>>> ''' OK'''  see revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5770]  &  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5771]    ===>> SETTE OK with revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5774]  &  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5775] 
     100  ===>>> '''   OK'''    see revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5770]    &  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5771]      ===>> SETTE OK with revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5774]    &  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5775] 
    99101 
    100102 * traadv_muscl2.F90  removed[[BR]]- traadv_muscl.F90 renamed traadv_mus.F90[[BR]]- traadv_cen2.F90  replaced by traadv_cen which provides 2nd and 4th order centered scheme on both horizontal and vertical directions.[[BR]]- name TVD has been changed to the more commonly used FCT (Flux Correction Transport)[[BR]]- FCT offers now 2nd and 4th order centered scheme on both horizontal and vertical directions.[[BR]]- UBS offers now in option either a 2nd order FCT or a 4th order COMPACT scheme in the vertical direction[[BR]]- NB in case of 4th order in the vertical, CEN, UBS and FCT use a compact 4th order scheme[[BR]]- key_esopa removed from traadv.F90 
     
    129131 
    130132== [[BR]][[BR]][[BR]]III. Phasing of momentum trends == 
    131   ===>>> ''' OK'''  see revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5777 5777]                                   & [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5778 5778]                                   and   [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5782 5782]                                   with SETTE OK 
     133  ===>>> '''   OK'''    see revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5777 5777]                                     & [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5778 5778]                                     and   [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5782 5782]                                     with SETTE OK 
    132134 
    133135=== [[BR]]III.1 — LDF on dynamics  - viscous trends === 
     
    167169 
    168170=== [[BR]]III.2 —''' '''ADV on dynamics''' - advective trends''' === 
    169   ===>>> ''' OK'''  see revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5778 5778]  and  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5786 5786] with SETTE OK 
     171  ===>>> '''   OK'''    see revision  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5778 5778]    and  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5786 5786]  with SETTE OK 
    170172 
    171173''dynvor.F90 (impact also dynspg_ts.F90)''[[BR]]                   - remove key_esopa[[BR]]                   - remove dyn_vor_mix : now successive call of den_vor_ene (Coriolis) and din_vor_ens (relative voricity)[[BR]]                   - replace rotn by its calculation everywhere in dynvor.F90[[BR]]                   - remove the use of fmask from standard vorticity calculation in dynvor.F90 but add a namelist parameter (ln_dynvor_msk) to multiply by fmask the vorticity term[[BR]]- add an namelist option to mask or not the vorticity (including Coriolis) '''CAUTION''' : the mask option does not work: set to FALSE by default with comment DO NOT set it to TRUE  (see '''  [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5827 5827]''' )[[BR]]- change ln_dynvor_een_old into nn_een_e3f = 0/1 
     
    213215'''(V.2)''' It should be possible to remove hdivn ... think about that 
    214216 
    215   [[BR]]                                   '''                                 Next Step :''' 
    216  
    217 Starting from this branch, another branch is created ('''given the name here''') which will contain the following item (random order): 
    218  
    219 remove all remaining hard coded parts specific to a configuration (especially ORCA2) 
     217---- 
     218= [[BR]] Next Step = 
     219Starting from the '''trunk''' (revision: [https://forge.ipsl.jussieu.fr/nemo/log/trunk/NEMOGCM?rev=5838 ​5836]), which has been phased with the branch described here, several branches are created which will contain the following item: 
     220 
     221Non linear free surface by default ([https://forge.ipsl.jussieu.fr/nemo/browser/branches/2015/dev_r5836_NOC3_vvl_by_default ​dev_r5836_NOC3_vvl_by_default]). see Wiki page [https://forge.ipsl.jussieu.fr/nemo/wiki/ticket/5836_NOC3_vvl_by_default 5836_NOC3_vvl_by_default] 
    220222 
    221223• ZDF simplification: introduce a vertical physics manager that allows to save MPP communications. remove avmu, avmv. remove all key_zdfxxx 
     
    223225• create trptra.F90 which compute the effective velocity for both TRC and TRA 
    224226 
    225 vertical scale factors defined systematically in vvl case (no more domzgr_substitute.h90) 
     227remove all remaining hard coded parts specific to a configuration (especially ORCA2): see a description of the remaining work here: [https://forge.ipsl.jussieu.fr/nemo/wiki/2014WP/2014_SystemSimplification_hard_coding SystemSimplification_hard_coding] 
    226228 
    227229• remove most of the remaining CPP keys (key_trabbl, key_zdf...) 
     
    230232 
    231233---- 
    232 '''To be CHECKED''' (not necessary associated with this branch) 
     234= To be CHECKED = 
     235(not necessary associated with this branch) 
    233236 
    234237 * find ''!!gm'' everywhere in the fortran code, and try to solve the issues raised !