New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
ticket/1620_MERCATOR_SOLVER_SIMPLIFICATION (diff) – NEMO

Changes between Version 2 and Version 3 of ticket/1620_MERCATOR_SOLVER_SIMPLIFICATION


Ignore:
Timestamp:
2015-11-18T18:43:13+01:00 (8 years ago)
Author:
jchanut
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • ticket/1620_MERCATOR_SOLVER_SIMPLIFICATION

    v2 v3  
    11Author: '''Jérôme Chanut, Mercator Océan''' 
    22 
    3 Page related to ticket: #1620 and associated to the following development branch: 
    4 [​https://forge.ipsl.jussieu.fr/nemo/browser/branches/2015/dev_r5847_MERCATOR9_solveur_simplification] 
     3Page related to ticket: #1620 and associated to the following development branch: [​https://forge.ipsl.jussieu.fr/nemo/browser/branches/2015/dev_r5847_MERCATOR9_solveur_simplification] 
    54 
    65This development is part of the shared simplication process, task: SIMPLIF-2: Removal of filtered free surface. Split explicit and explicit free surface only. 
     
    87'''Step 1: Remove filtered free surface option and associated key_dynspg_flt key''' 
    98 
    10   
    11 1) Remove parts of the code specific to "key_dynspg_flt" or lk_dynspg_flt=T and the need for solver modules in the code.[[BR]] 
    12 2) Suppress SOL directory and dynspg_flt module[[BR]] 
     9 1) Remove parts of the code specific to "key_dynspg_flt" or lk_dynspg_flt=T and the need for solver modules in the code.[[BR]] 2) Suppress SOL directory and dynspg_flt module[[BR]] 
    1310 
    14 3) Clean momentum trend routines related to filtered free surface (trddyn, trdken, trd_oce).[[BR]] 
    15 4) Update reference configurations: [[BR]] 
    16 - Replace key_dynspg_flt by key_dynspg_ts if needed in CONFIG/* directories. [[BR]] 
    17 - Remove namsol block in namelist_* and references to flt variables (trends) in field_def.xml[[BR]] 
    18 - SETTE: update sette.sh, to remove modifications of namelist variables related to solver. [[BR]] 
     113) Clean momentum trend routines related to filtered free surface (trddyn, trdken, trd_oce).[[BR]] 4) Update reference configurations: [[BR]] 
     12 
     13 * Replace key_dynspg_flt by key_dynspg_ts if needed in CONFIG/* directories. [[BR]] 
     14 * Remove namsol block in namelist_* and references to flt variables (trends) in field_def.xml[[BR]] 
     15 * SETTE: update sette.sh, to remove modifications of namelist variables related to solver. [[BR]] 
    1916 
    2017NB: one should change "solver.stat" file and numsol names in stp_ctl and in_out_manager... keep it as is for the time being[[BR]] 
    2118 
    22 ==> '''Commit changes to revision 5868''' 
    23 [https://forge.ipsl.jussieu.fr/nemo/changeset?old_path=%2Fbranches%2F2015%2Fdev_r5847_MERCATOR9_solveur_simplification&old=5867&new_path=%2Fbranches%2F2015%2Fdev_r5847_MERCATOR9_solveur_simplification&new=5868]  
     19==> '''Commit changes to revision 5868''' [https://forge.ipsl.jussieu.fr/nemo/changeset?old_path=%2Fbranches%2F2015%2Fdev_r5847_MERCATOR9_solveur_simplification&old=5867&new_path=%2Fbranches%2F2015%2Fdev_r5847_MERCATOR9_solveur_simplification&new=5868] 
    2420 
    25 GYRE        restartability  passed 
    26 ORCA2LIMPIS restartability  passed 
    27 ORCA2OFFPIS restartability  passed 
    28 AMM12       restartability  passed 
    29 ORCA2LIM3   restartability  passed 
    30 SAS         restartability  inconclusive (  solver.stat  not found ) 
    31 GYRE        reproducibility passed 
    32 ORCA2LIMPIS reproducibility passed 
    33 ORCA2OFFPIS reproducibility passed 
    34 AMM12       reproducibility passed 
    35 ORCA2LIM3   reproducibility passed 
    36 SAS         reproducibility inconclusive (  solver.stat  not found ) 
    37 ORCA2_LIM_AGRIF runability passed 
    38 ORCA2_LIM_AGRIF code corruption test passed 
     21GYRE        restartability  passed ORCA2LIMPIS restartability  passed ORCA2OFFPIS restartability  passed AMM12       restartability  passed ORCA2LIM3   restartability  passed SAS         restartability  inconclusive (  solver.stat  not found ) GYRE        reproducibility passed ORCA2LIMPIS reproducibility passed ORCA2OFFPIS reproducibility passed AMM12       reproducibility passed ORCA2LIM3   reproducibility passed SAS         reproducibility inconclusive (  solver.stat  not found ) ORCA2_LIM_AGRIF runability passed ORCA2_LIM_AGRIF code corruption test passed 
    3922 
    40 ==> Pass Sette tests:YES 
     23==> Passes Sette tests:YES 
    4124 
    4225'''Step 2: Suppress implicit pressure gradient option, ln_hpg_imp=T ''' 
    4326 
    44 Since this option is not supported with the now default split explicit free surface: remove it ( => simpler step routine). 
    45 ln_hpg_imp namelist variable suppressed in reference namelist.[[BR]] 
     27Since this option is not supported with the now default split explicit free surface: remove it ( => simpler step routine). ln_hpg_imp namelist variable suppressed in reference namelist.[[BR]] 
    4628 
    4729==> '''Commit changes to revision 5869'''[ https://forge.ipsl.jussieu.fr/nemo/changeset?old_path=%2Fbranches%2F2015%2Fdev_r5847_MERCATOR9_solveur_simplification&old=5868&new_path=%2Fbranches%2F2015%2Fdev_r5847_MERCATOR9_solveur_simplification&new=5869] [[BR]] 
     
    5133'''Step 3: Time Stepping readibility '''[[BR]] 
    5234 
    53 1)''' dynzdf'''[[BR]] 
    54 Make time stepping identical in explicit or split-explicit cases => assume that "after" velocities not tendencies are available after vertical diffusion of momentum (as for tracers) => modify dynzdf/dynnxt routines 
     351)''' dynzdf'''[[BR]] Make time stepping identical in explicit or split-explicit cases => assume that "after" velocities not tendencies are available after vertical diffusion of momentum (as for tracers) => modify dynzdf/dynnxt routines 
    5536 
    56372) '''step'''[[BR]] 
    57 - Group all dynamical trends at the same place (at the beginning of the time stepping). Still keep dynnxt after tracer time stepping at the end.[[BR]] 
    58 - Assuming ua/va are not used anymore during tracer computation as working arrays, remove temporary 3d arrays ua_sv, va_sv 
    5938 
    60 ==> Commit changes to revision: ???[[BR]] 
    61 ==> Pass Sette tests:??? 
     39 * Group all dynamical trends at the same place (at the beginning of the time stepping). Still keep dynnxt after tracer time stepping at the end.[[BR]] 
     40 * Assuming ua/va are not used anymore during tracer computation as working arrays, remove temporary 3d arrays ua_sv, va_sv 
    6241 
    63 '''Step 4: additional simplifications/corrections''' 
    64 - Correct momentum trend computation with time splitting 
    65 - Agrif cleaning and compatibility with explicit free surface 
    66 - Remove key_dynspg_ts and key_dynspg_exp cpp keys (create namelist block to choose between the two) 
    67 - Suppress dynspg_oce module ? 
    68 - Others ? 
     423) Suppress obsolete dynspg_oce module, remove key_dynspg_ts / key_dynspg_exp (add namelist variables instead) 
    6943 
    70 ==> Commit changes to revision: ???[[BR]] 
    71 ==> Pass Sette tests:??? 
     44==> Commit changes to revision: ???[[BR]] ==> Passes Sette tests:??? 
     45 
     46'''Step 4: Additional simplifications/corrections''' 
     47 
     48 * Correct momentum trend computation with time splitting 
     49 * Agrif cleaning and compatibility with explicit free surface 
     50 * Remove filtered free surface from documentation 
     51 * Others ? 
     52 
     53==> Commit changes to revision: ???[[BR]] ==> Pass Sette tests:???