Changes between Version 2 and Version 3 of ticket/1753


Ignore:
Timestamp:
2017-11-23T09:46:46+01:00 (3 years ago)
Author:
timgraham
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • ticket/1753

    v2 v3  
     1= '''''AGRIF-3_Jerome-vvl: Agrif compatible with vvl''''' = 
     2 
     3 
     4 
     5== Summary == #summary 
     6|| '''Action''' || AGRIF-3_Jerome-vvl Agrif compatible with vvl                          || 
     7|| '''PI(S)''' || Jérôme Chanut                                                          || 
     8{{{#!td 
     9'''Digest''' 
     10}}} 
     11{{{#!td 
     12Enable online nesting (i.e. AGRIF) with non-linear free surface (z* coordinate, eventually z~). 
     13* Ensure correct fluxes at child grid edges from parent level with time varying vertical thicknesses. 
     14* Ensure correct update of vertical grid at child grid open boundaries. 
     15* Implement update of vertical scale factors and volume weighted update of tracers. 
     16}}} 
     17|- 
     18|| '''Dependencies''' || ''Depends on: -''                                               || 
     19|| '''Target'''       || ''- Expected end 2017:development OK; running OK.''             || 
     20|| '''Trac Ticket'''  || #1965                                                           || 
     21|| '''SVN branch'''   || [source:/branches/2017/dev_r8624_AGRIF3_VVL]                    || 
     22|| '''Previewer(s)''' || ''Tim Graham''                                                  || 
     23|| '''Reviewer(s)'''  || ''Tim Graham''                                                  || 
     24|| '''Status'''       || ''Under review''                                                || 
     25|| '''Link'''         || [[ExtractUrl(.)]]                                               || 
     26 
     27 
     28{{{#!comment 
     29DON'T REMOVE THIS VOID HEADING OR IT WILL BREAK THE INCLUDE FEATURE BETWEEN WIKI PAGES 
     30}}} 
     31==  == 
     32{{{#!comment 
     33DON'T REMOVE THIS VOID HEADING OR IT WILL BREAK THE INCLUDE FEATURE BETWEEN WIKI PAGES 
     34}}} 
     35 
     36{{{#!Fold title=Abstract tag=h2 [=#abstract] 
     37 
     38This section should be completed before starting to develop the code, in order to find agreement on the method beforehand. 
     39 
     40{{{#!TracForm #!subcontext abstract #!submit_label 'Save Abstract' #!keep_history yes 
     41 
     42=== Description === 
     43  [tf.textarea:description -id=piform -class=taform 'Describe the goal of development, and the methodology.\n\nAdd reference documents or publications if relevant.' 0 20] 
     44 
     45=== Implementation === 
     46  [tf.textarea:implementation -id=piform -class=taform 'Describe flow chart of the changes in the code.\n\nList the .F90 files and modules to be changed.\n\nDetailed list of new variables (including namelists) to be defined.\nGive for each the chosen name (following coding rules) and definition.' 0 20] 
     47 
     48=== Reference manual and web pages updates === 
     49  [tf.textarea:manual -id=piform -class=taform 'Using part 1 and 2, define the summary of changes to be done in the NEMO reference manual (tex files), and in the content of web pages.' 0 20] 
     50 
     51'''''Updated on [tf.form_updated_on:] by [tf.form_updater:]''''' 
     52 
     53}}} 
     54 
     55Once the PI has completed this section, he should send a mail to the previewer(s) asking them to preview the work within two weeks. 
     56 
     57}}} 
     58 
     59{{{#!Fold title=Preview tag=h2 [=#preview] 
     60 
     61Since the preview step must be completed before the PI starts the coding, the previewer(s) answers are expected to be completed within the two weeks after the PI has sent his request.[[BR]]For each question, an iterative process should take place between PI and previewer(s) in order to reach a "YES" answer for each of the following questions. 
     62 
     63{{{#!TracForm #!subcontext preview_ #!submit_label 'Save Preview' 
     64 
     65|| Questions || Answer || Comment || 
     66|| Does the previewer agree with the proposed methodology? || [tf.select:2.1 -id=preform '' Yes No NR] || [tf.textarea:2.1c -id=preform 'Add a comment?' 50 10] || 
     67|| Does the previewer agree with the proposed flowchart and list of routines to be changed? || [tf.select:2.2 -id=preform '' Yes No NR] || [tf.textarea:2.2c -id=preform 'Add a comment?' 50 10] || 
     68|| Does the previewer agree with the proposed new list of variables, including agreement with coding rules? || [tf.select:2.3 -id=preform '' Yes No NR] || [tf.textarea:2.3c -id=preform 'Add a comment?' 50 10] || 
     69|| Does the previewer agree with the proposed summary of updates in reference manual? || [tf.select:2.4 -id=preform '' Yes No NR] || [tf.textarea:2.4c -id=preform 'Add a comment?' 50 10] || 
     70|| ... ... ... || [tf.select:2.X -id=preform '' Yes No NR] || [tf.textarea:2.Xc -id=preform 'Add a comment?' 50 10] || 
     71 
     72'''''Updated on [tf.form_updated_on:] by [tf.form_updater:]''''' 
     73 
     74}}} 
     75 
     76Once all "YES" have been reached, the PI can start the development into his development branch. 
     77 
     78}}} 
     79 
     80{{{#!Fold title=Tests tag=h2 [=#tests] 
     81 
     82Once the development is done, the PI should complete this section below and ask the reviewers to start their review in the lower section. 
     83 
     84{{{#!TracForm #!subcontext tests #!submit_label 'Save Tests' 
     85 
     86|| Questions || Answer || Comment || 
     87|| Can this change be shown to produce expected impact? (if option activated)? || [tf.select:3.1 -id=piform '' Yes No NR] || [tf.textarea:3.1c -id=piform 'Add a comment?' 50 10] || 
     88|| Can this change be shown to have a null impact? (if option not activated) || [tf.select:3.2 -id=piform '' Yes No NR] || [tf.textarea:3.2c -id=piform 'Add a comment?' 50 10] || 
     89|| Detailed results of restartability and reproducibility when the option is activated. Please indicate the configuration used for this test || [tf.select:3.3 -id=piform '' Yes No NR] || [tf.textarea:3.3c -id=piform 'Add a comment?' 50 10] || 
     90|| Detailed results of SETTE tests (restartability and reproducibility for each of the reference configuration) || [tf.select:3.4 -id=piform '' Yes No NR] || [tf.textarea:3.4c -id=piform 'Add a comment?' 50 10] || 
     91|| Results of the required bit comparability tests been run: Are there no differences when activating the development? || [tf.select:3.5 -id=piform '' Yes No NR] || [tf.textarea:3.5c -id=piform 'Add a comment?' 50 10] || 
     92|| If some differences appear, is reason for the change valid/understood? || [tf.select:3.6 -id=piform '' Yes No NR] || [tf.textarea:3.6c -id=piform 'Add a comment?' 50 10] || 
     93|| If some differences appear, is the !ticket describing in detail the impact this change will have on model configurations? || [tf.select:3.7 -id=piform '' Yes No NR] || [tf.textarea:3.7c -id=piform 'Add a comment?' 50 10] || 
     94|| Is this change expected to preserve all diagnostics? || [tf.select:3.8 -id=piform '' Yes No NR] || [tf.textarea:3.8c -id=piform 'Add a comment?' 50 10] || 
     95|| If no, is reason for the change valid/understood? || [tf.select:3.9 -id=piform '' Yes No NR] || [tf.textarea:3.9c -id=piform 'Add a comment?' 50 10] || 
     96|| Are there significant changes in run time/memory? || [tf.select:3.10 -id=piform '' Yes No NR] || [tf.textarea:3.10c -id=piform 'Add a comment?' 50 10] || 
     97|| ... ... ... || [tf.select:3.XX -id=piform '' Yes No NR] || [tf.textarea:3.XXc -id=piform 'Add a comment?' 50 10] || 
     98 
     99'''''Updated on [tf.form_updated_on:] by [tf.form_updater:]''''' 
     100 
     101}}} 
     102 
     103}}} 
     104 
     105{{{#!Fold title=Review tag=h2 [=#review] 
     106 
     107A successful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November). 
     108 
     109{{{#!TracForm #!subcontext review #!submit_label 'Save Review' 
     110 
     111=== Code changes and documentation === 
     112|| Question || Answer || Comment || 
     113|| Is the proposed methodology now implemented? || [tf.select:3.11 -id=revform '' Yes No NR] || [tf.textarea:3.11c -id=revform 'Add a comment?' 50 10] || 
     114|| Are the code changes in agreement with the flowchart defined at Preview step? || [tf.select:3.12 -id=revform '' Yes No NR] || [tf.textarea:3.12c -id=revform 'Add a comment?' 50 10] || 
     115|| Are the code changes in agreement with list of routines and variables as proposed at Preview step?[[BR]]If not, are the discrepancies acceptable? || [tf.select:3.13 -id=revform '' Yes No NR] || [tf.textarea:3.13c -id=revform 'Add a comment?' 50 10] || 
     116|| Is the in-line documentation accurate and sufficient? || [tf.select:3.14 -id=revform '' Yes No NR] || [tf.textarea:3.14c -id=revform 'Add a comment?' 50 10] || 
     117|| Do the code changes comply with NEMO coding standards? || [tf.select:3.15 -id=revform '' Yes No NR] || [tf.textarea:3.15c -id=revform 'Add a comment?' 50 10] || 
     118|| Is the !ticket of development documented with sufficient details for others to understand the impact of the change? || [tf.select:3.16 -id=revform '' Yes No NR] || [tf.textarea:3.16c -id=revform 'Add a comment?' 50 10] || 
     119|| Are the reference manual tex files now updated following the proposed summary in preview section? || [tf.select:3.17 -id=revform '' Yes No NR] || [tf.textarea:3.17c -id=revform 'Add a comment?' 50 10] || 
     120|| Is there a need for some documentation on the web pages (in addition to in-line and reference manual)?[[BR]]If yes, please describe and ask PI. A yes answer must include all documentation available. || [tf.select:3.18 -id=revform '' Yes No NR] || [tf.textarea:3.18c -id=revform 'Add a comment?' 50 10] || 
     121|| ... ... ... || [tf.select:3.XX -id=revform '' Yes No NR] || [tf.textarea:3.XXc -id=revform 'Add a comment?' 50 10] || 
     122 
     123==== Review Summary ==== 
     124Is the review fully successful? [tf.select:status -id=revform '' Yes No] 
     125 
     126[tf.textarea:comment -id=revform 'If not, please indicate what is still missing.' 50 10] 
     127 
     128'''''Updated on [tf.form_updated_on:] by [tf.form_updater:]''''' 
     129 
     130}}} 
     131 
     132Once review is successful, the development must be scheduled for merge during next Merge Party Meeting. 
     133 
     134}}}